From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B46C433EF for ; Sun, 30 Jan 2022 14:59:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355325AbiA3O7x (ORCPT ); Sun, 30 Jan 2022 09:59:53 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:44822 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355329AbiA3O7T (ORCPT ); Sun, 30 Jan 2022 09:59:19 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A51BF61211; Sun, 30 Jan 2022 14:59:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13D82C340E4; Sun, 30 Jan 2022 14:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643554756; bh=W6hUYxXfpCmTkoC0wP2SzdldEImzpCHUF1VB5w/7jH4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GGo6dWALPKTmqwzp/Lti7mY+KzjFixmMjN4KuKwfTYOYYCr3obhINSaRVSRTwBvCf tH6rPniTrgzfxS5M6Q/JxrATzimluByc+mVaezwD7OpqcUN2Z9X/G/Y73dwS2xSUIk vRGwhnCPP3YNEYQZ94kQJkM7PmCXirpDrSaAqgz+fKabuAWeIo/7MEVsjzFYWU/BbZ HmA9V18/seI6F0JjbWckq3Bsm26A+4XFBnBCxzts8f1xZPWQxMrZL9a+J8uViZ0kVp LwoLDx0mVigHW3XHbqGVMG++4Nng9Ljv812gscNC2A9LWnbuIaEWAhJhnoJnvQ3qWo nG0uQmwfXjVjw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEBfd-004Ak7-Tv; Sun, 30 Jan 2022 14:59:14 +0000 Date: Sun, 30 Jan 2022 14:59:13 +0000 Message-ID: <87mtjdxoam.wl-maz@kernel.org> From: Marc Zyngier To: Guo Ren Cc: Samuel Holland , Anup Patel , Thomas Gleixner , Palmer Dabbelt , Linux Kernel Mailing List , linux-riscv , devicetree , Guo Ren Subject: Re: [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic dt parse in opensbi In-Reply-To: References: <20220129162726.1154501-1-guoren@kernel.org> <20220129162726.1154501-3-guoren@kernel.org> <87r18qxui9.wl-maz@kernel.org> <35b1838d-ef80-1816-46f6-9cba7afc813e@sholland.org> <87o83ty0ti.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: guoren@kernel.org, samuel@sholland.org, anup@brainfault.org, tglx@linutronix.de, palmer@dabbelt.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, guoren@linux.alibaba.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 30 Jan 2022 13:09:21 +0000, Guo Ren wrote: > > On Sun, Jan 30, 2022 at 6:28 PM Marc Zyngier wrote: > > > > On Sun, 30 Jan 2022 04:39:34 +0000, > > Guo Ren wrote: > > > > > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init); > > > I think we should give clear info in /proc/interrupts. I hope we could > > > keep thead_plic_init. > > > > Why? There is no material difference at the driver level, and > > /proc/interrupts won't be the target of a branding exercise (which > > this series seems to be all about). > It's not a branding exercise, the series just correct the broken code > & incorrect /proc/interrupts display. There is *nothing* incorrect in /proc/interrupt. If anything, changing the string *is* an ABI change, for no good reason. M. -- Without deviation from the norm, progress is not possible.