* [PATCH v4 0/2] dt-bindings: interrupt-controller: sifive, plic: Miscellaneous improvements @ 2022-01-28 9:03 Geert Uytterhoeven 2022-01-28 9:03 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive,plic: Fix number of interrupts Geert Uytterhoeven 2022-01-28 9:03 ` [PATCH v4 2/2] dt-bindings: interrupt-controller: sifive,plic: Group interrupt tuples Geert Uytterhoeven 0 siblings, 2 replies; 8+ messages in thread From: Geert Uytterhoeven @ 2022-01-28 9:03 UTC (permalink / raw) To: Thomas Gleixner, Marc Zyngier, Palmer Dabbelt, Paul Walmsley, Sagar Kadam Cc: Rob Herring, linux-kernel, devicetree, linux-riscv, Geert Uytterhoeven Hi all, This patch series contains two improvements for the SiFive PLIC DT bindings. Changes compared to v3[1]: - Use architectural maximum instead of practical maximum of 9, Changes compared to v2[2]: - Add Acked-by, Reviewed-by. Changes compared to v1[3]: - Split in two patches, - Improve patch description and document limit rationale. Thanks! [1] https://lore.kernel.org/r/cover.1639744106.git.geert@linux-m68k.org/ [2] https://lore.kernel.org/r/cover.1639661878.git.geert@linux-m68k.org [3] https://lore.kernel.org/r/20211125152233.162868-1-geert@linux-m68k.org Geert Uytterhoeven (2): dt-bindings: interrupt-controller: sifive,plic: Fix number of interrupts dt-bindings: interrupt-controller: sifive,plic: Group interrupt tuples .../interrupt-controller/sifive,plic-1.0.0.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.25.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive,plic: Fix number of interrupts 2022-01-28 9:03 [PATCH v4 0/2] dt-bindings: interrupt-controller: sifive, plic: Miscellaneous improvements Geert Uytterhoeven @ 2022-01-28 9:03 ` Geert Uytterhoeven 2022-01-28 9:06 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive, plic: " Anup Patel 2022-01-28 17:57 ` Conor Dooley 2022-01-28 9:03 ` [PATCH v4 2/2] dt-bindings: interrupt-controller: sifive,plic: Group interrupt tuples Geert Uytterhoeven 1 sibling, 2 replies; 8+ messages in thread From: Geert Uytterhoeven @ 2022-01-28 9:03 UTC (permalink / raw) To: Thomas Gleixner, Marc Zyngier, Palmer Dabbelt, Paul Walmsley, Sagar Kadam Cc: Rob Herring, linux-kernel, devicetree, linux-riscv, Geert Uytterhoeven, Rob Herring The number of interrupts lacks an upper bound, thus assuming one, causing properly grouped "interrupts-extended" properties to be flagged as an error by "make dtbs_check". Fix this by adding the missing "maxItems", using the architectural maximum of 15872 interrupts. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Rob Herring <robh@kernel.org> --- v4: - Use architectural maximum instead of practical maximum of 9, v3: - Add Acked-by, v2: - Split in two patches, - Improve patch description and document limit rationale. --- .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml index 28b6b17fe4b26778..57c06126c99502fa 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml @@ -62,6 +62,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 15872 description: Specifies which contexts are connected to the PLIC, with "-1" specifying that a context is not present. Each node pointed to should be a -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive, plic: Fix number of interrupts 2022-01-28 9:03 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive,plic: Fix number of interrupts Geert Uytterhoeven @ 2022-01-28 9:06 ` Anup Patel 2022-01-28 17:57 ` Conor Dooley 1 sibling, 0 replies; 8+ messages in thread From: Anup Patel @ 2022-01-28 9:06 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Thomas Gleixner, Marc Zyngier, Palmer Dabbelt, Paul Walmsley, Sagar Kadam, Rob Herring, linux-kernel@vger.kernel.org List, DTML, linux-riscv, Rob Herring On Fri, Jan 28, 2022 at 2:34 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems", using the architectural > maximum of 15872 interrupts. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Rob Herring <robh@kernel.org> Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup > --- > v4: > - Use architectural maximum instead of practical maximum of 9, > > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 28b6b17fe4b26778..57c06126c99502fa 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -62,6 +62,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 15872 > description: > Specifies which contexts are connected to the PLIC, with "-1" specifying > that a context is not present. Each node pointed to should be a > -- > 2.25.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive, plic: Fix number of interrupts 2022-01-28 9:03 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive,plic: Fix number of interrupts Geert Uytterhoeven 2022-01-28 9:06 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive, plic: " Anup Patel @ 2022-01-28 17:57 ` Conor Dooley 2022-01-28 18:51 ` Marc Zyngier 1 sibling, 1 reply; 8+ messages in thread From: Conor Dooley @ 2022-01-28 17:57 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Thomas Gleixner, Marc Zyngier, Palmer Dabbelt, Paul Walmsley, Sagar Kadam, Rob Herring, linux-kernel, devicetree, linux-riscv, Rob Herring > The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems", using the architectural > maximum of 15872 interrupts. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Rob Herring <robh@kernel.org> > --- > v4: > - Use architectural maximum instead of practical maximum of 9, > > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 28b6b17fe4b26778..57c06126c99502fa 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -62,6 +62,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 15872 > description: > Specifies which contexts are connected to the PLIC, with "-1" specifying > that a context is not present. Each node pointed to should be a > -- > 2.25.1 As with the clint - clears errors on the icicle dt, so fwiw: Acked-by: Conor Dooley <conor.dooley@microchip.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive, plic: Fix number of interrupts 2022-01-28 17:57 ` Conor Dooley @ 2022-01-28 18:51 ` Marc Zyngier 2022-01-28 19:40 ` Conor Dooley 0 siblings, 1 reply; 8+ messages in thread From: Marc Zyngier @ 2022-01-28 18:51 UTC (permalink / raw) To: Conor Dooley Cc: Geert Uytterhoeven, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley, Sagar Kadam, Rob Herring, linux-kernel, devicetree, linux-riscv, Rob Herring On Fri, 28 Jan 2022 17:57:04 +0000, Conor Dooley <mail@conchuod.ie> wrote: > > [1 PGP/MIME version identification <application/pgp-encrypted (7bit)>] > [2 OpenPGP encrypted message <application/octet-stream (7bit)>] Please refrain from posting encrypted messages to the mailing lists. M. -- Without deviation from the norm, progress is not possible. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive, plic: Fix number of interrupts 2022-01-28 18:51 ` Marc Zyngier @ 2022-01-28 19:40 ` Conor Dooley 0 siblings, 0 replies; 8+ messages in thread From: Conor Dooley @ 2022-01-28 19:40 UTC (permalink / raw) To: Marc Zyngier Cc: Geert Uytterhoeven, Thomas Gleixner, Palmer Dabbelt, Paul Walmsley, Sagar Kadam, Rob Herring, linux-kernel, devicetree, linux-riscv, Rob Herring On 28/01/2022 18:51, Marc Zyngier wrote: > On Fri, 28 Jan 2022 17:57:04 +0000, > Conor Dooley <mail@conchuod.ie> wrote: >> >> [1 PGP/MIME version identification <application/pgp-encrypted (7bit)>] >> [2 OpenPGP encrypted message <application/octet-stream (7bit)>] > > Please refrain from posting encrypted messages to the mailing lists. > > M. Apologies - not my usual mail client. It appears to have decided that you (and Rob) should get it encrypted even though I had that disabled. Actually doing so also would appear to be non trivial. I am hoping but not expecting to have fixed it. The mail to the list itself looks to be fine however. > > -- > Without deviation from the norm, progress is not possible. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v4 2/2] dt-bindings: interrupt-controller: sifive,plic: Group interrupt tuples 2022-01-28 9:03 [PATCH v4 0/2] dt-bindings: interrupt-controller: sifive, plic: Miscellaneous improvements Geert Uytterhoeven 2022-01-28 9:03 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive,plic: Fix number of interrupts Geert Uytterhoeven @ 2022-01-28 9:03 ` Geert Uytterhoeven 2022-01-28 9:06 ` Anup Patel 1 sibling, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2022-01-28 9:03 UTC (permalink / raw) To: Thomas Gleixner, Marc Zyngier, Palmer Dabbelt, Paul Walmsley, Sagar Kadam Cc: Rob Herring, linux-kernel, devicetree, linux-riscv, Geert Uytterhoeven, Rob Herring To improve human readability and enable automatic validation, the tuples in "interrupts-extended" properties should be grouped using angle brackets. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by: Rob Herring <robh@kernel.org> --- v4: - No changes, v3: - Add Reviewed-by, v2: - Split in two patches. --- .../interrupt-controller/sifive,plic-1.0.0.yaml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml index 57c06126c99502fa..0dfa6b26e09910a8 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml @@ -91,12 +91,11 @@ examples: #interrupt-cells = <1>; compatible = "sifive,fu540-c000-plic", "sifive,plic-1.0.0"; interrupt-controller; - interrupts-extended = < - &cpu0_intc 11 - &cpu1_intc 11 &cpu1_intc 9 - &cpu2_intc 11 &cpu2_intc 9 - &cpu3_intc 11 &cpu3_intc 9 - &cpu4_intc 11 &cpu4_intc 9>; + interrupts-extended = <&cpu0_intc 11>, + <&cpu1_intc 11>, <&cpu1_intc 9>, + <&cpu2_intc 11>, <&cpu2_intc 9>, + <&cpu3_intc 11>, <&cpu3_intc 9>, + <&cpu4_intc 11>, <&cpu4_intc 9>; reg = <0xc000000 0x4000000>; riscv,ndev = <10>; }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: interrupt-controller: sifive,plic: Group interrupt tuples 2022-01-28 9:03 ` [PATCH v4 2/2] dt-bindings: interrupt-controller: sifive,plic: Group interrupt tuples Geert Uytterhoeven @ 2022-01-28 9:06 ` Anup Patel 0 siblings, 0 replies; 8+ messages in thread From: Anup Patel @ 2022-01-28 9:06 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Thomas Gleixner, Marc Zyngier, Palmer Dabbelt, Paul Walmsley, Sagar Kadam, Rob Herring, linux-kernel@vger.kernel.org List, DTML, linux-riscv, Rob Herring On Fri, Jan 28, 2022 at 2:34 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > To improve human readability and enable automatic validation, the tuples > in "interrupts-extended" properties should be grouped using angle > brackets. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Reviewed-by: Rob Herring <robh@kernel.org> Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup > --- > v4: > - No changes, > > v3: > - Add Reviewed-by, > > v2: > - Split in two patches. > --- > .../interrupt-controller/sifive,plic-1.0.0.yaml | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 57c06126c99502fa..0dfa6b26e09910a8 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -91,12 +91,11 @@ examples: > #interrupt-cells = <1>; > compatible = "sifive,fu540-c000-plic", "sifive,plic-1.0.0"; > interrupt-controller; > - interrupts-extended = < > - &cpu0_intc 11 > - &cpu1_intc 11 &cpu1_intc 9 > - &cpu2_intc 11 &cpu2_intc 9 > - &cpu3_intc 11 &cpu3_intc 9 > - &cpu4_intc 11 &cpu4_intc 9>; > + interrupts-extended = <&cpu0_intc 11>, > + <&cpu1_intc 11>, <&cpu1_intc 9>, > + <&cpu2_intc 11>, <&cpu2_intc 9>, > + <&cpu3_intc 11>, <&cpu3_intc 9>, > + <&cpu4_intc 11>, <&cpu4_intc 9>; > reg = <0xc000000 0x4000000>; > riscv,ndev = <10>; > }; > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-01-28 19:40 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-01-28 9:03 [PATCH v4 0/2] dt-bindings: interrupt-controller: sifive, plic: Miscellaneous improvements Geert Uytterhoeven 2022-01-28 9:03 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive,plic: Fix number of interrupts Geert Uytterhoeven 2022-01-28 9:06 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: sifive, plic: " Anup Patel 2022-01-28 17:57 ` Conor Dooley 2022-01-28 18:51 ` Marc Zyngier 2022-01-28 19:40 ` Conor Dooley 2022-01-28 9:03 ` [PATCH v4 2/2] dt-bindings: interrupt-controller: sifive,plic: Group interrupt tuples Geert Uytterhoeven 2022-01-28 9:06 ` Anup Patel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).