From: Miquel Raynal <miquel.raynal@bootlin.com>
To: sashiko-bot@kernel.org
Cc: sashiko-reviews@lists.linux.dev, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v9 01/10] clk: nuvoton: ma35d1: Use clk_hw pointers as mux parents
Date: Thu, 15 Oct 2026 14:57:35 +0200 [thread overview]
Message-ID: <87o6cvunnk.fsf@bootlin.com> (raw)
In-Reply-To: <sashiko-outbox-172810@kernel.org> (sashiko-bot@kernel.org's message of "Thu, 15 Oct 2026 12:34:43 +0000")
On 15/10/2026 at 12:34:43 GMT, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] clk: ma35d1: unmanaged mux clocks leak and cause UAF on probe failure
[...]
> While a later patch in this series addresses a similar issue for fixed clocks
> by switching to a devm_ variant, ma35d1_clk_mux() still uses the unmanaged
> clk_hw_register_mux_hws(). Should this be updated to use the appropriate
> managed devm_ variant to prevent this regression?
I should have converted those to devm_ registration as well. I will just
do the same move with the muxes than with the fixed rates since I'm
already migrating them to a slightly different API.
This is the solution to both problems raised by Sashiko this time.
Miquèl
next prev parent reply other threads:[~2026-10-15 12:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 12:18 [PATCH v9 00/10] clk: nuvoton: ma35d1: Fix mux parenting and peripheral clock rates Miquel Raynal
2026-10-15 12:18 ` [PATCH v9 01/10] clk: nuvoton: ma35d1: Use clk_hw pointers as mux parents Miquel Raynal
2026-10-15 12:34 ` sashiko-bot
2026-10-15 12:57 ` Miquel Raynal [this message]
2026-10-15 12:18 ` [PATCH v9 02/10] clk: nuvoton: ma35d1: Avoid possible error pointer dereferencing Miquel Raynal
2026-10-15 12:18 ` [PATCH v9 03/10] clk: nuvoton: ma35d1: Retrieve HXT/LXT from DT when possible Miquel Raynal
2026-10-15 12:19 ` [PATCH v9 04/10] clk: nuvoton: ma35d1: Reparent the gates correctly Miquel Raynal
2026-10-15 12:19 ` [PATCH v9 05/10] clk: nuvoton: ma35d1: Use device managed helpers for fixed rate clocks Miquel Raynal
2026-10-15 12:32 ` sashiko-bot
2026-10-15 12:19 ` [PATCH v9 06/10] clk: Create devm_clk_hw_register_fixed_rate_parent_hw() Miquel Raynal
2026-10-15 12:19 ` [PATCH v9 07/10] clk: nuvoton: ma35d1: Reparent SYSPLL correctly Miquel Raynal
2026-10-15 12:19 ` [PATCH v9 08/10] MAINTAINERS: Add myself as Nuvoton MA35D1 clock controller Miquel Raynal
2026-10-15 12:19 ` [PATCH v9 09/10] arm64: dts: nuvoton: ma35d1: Drop HXT clock output name Miquel Raynal
2026-10-15 12:19 ` [PATCH v9 10/10] arm64: dts: nuvoton: ma35d1: Add LXT crystal and clock-names Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6cvunnk.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox