From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB36295DBA for ; Fri, 27 Jun 2025 10:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751018822; cv=none; b=PKz0+51m2o0QwsKrCHEMOhPX51XL+rOh2h9uQrPL16jg9U66Rhdzs+HFYgLaj4FLJqjGXf1gh2PVexdQoTT+JiuTm+oEMMNgXGyDe5GQHEDoD7a6mjQAnRcxtGa0LGnrkoKl2Ok6rgcofVAaZ2nNtnNekVYt3IFGbvuDvamTSxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751018822; c=relaxed/simple; bh=+IXYk0BLsk9VOjPdYK0JSoHlaBQmpqTb5SeExnFFEbc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UdVOhXr+W16R8jtYpUJYSYur2ckKom+DoP7jU6fzt1YhH8BzvVe5RLJR4neHkWXJ+KykOmmyIQb649iRb8zmKhwsXiHwfQ6/EQacNXsunge6hXUBSt327CA0NWLMhXRanfRPizZrAXPOo+qyhMDPDkwqv4MnAKnoSKFl43y/NsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yw82fjHd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yw82fjHd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751018819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uYXXAceZfrCUqpQ9OsgNrpmSa7NX1ldTsGlTcQdd5wI=; b=Yw82fjHdKZeVJITIOfPoC3f658ALuFkiTfn1kta0ioOv1oCCOvhzfnRHDh/p7hajlWsd0C D9445z93h9mOtl9GHX8obN2PhLXtKIZXzQsROqk87cyPrQPvznn9JqfWkhoAIUsf+37jUD /0w4anqvXzSzL459ql7xncK21CXniac= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-enOEDRo3OA2Xv3AuSLgm7A-1; Fri, 27 Jun 2025 06:06:58 -0400 X-MC-Unique: enOEDRo3OA2Xv3AuSLgm7A-1 X-Mimecast-MFC-AGG-ID: enOEDRo3OA2Xv3AuSLgm7A_1751018817 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f55ea44dso840804f8f.1 for ; Fri, 27 Jun 2025 03:06:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751018817; x=1751623617; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uYXXAceZfrCUqpQ9OsgNrpmSa7NX1ldTsGlTcQdd5wI=; b=UJOCGQA1veAMHZoIp9ZlEMzYoAvteTH6kwT+zspDBf7NQMghEcYBQ5Yur1dmb7mPKI w8kxWB7E0ESe0phzsAbs5Kii7fYXRVcZJKPZHfgSR+WYKbOFkByT2Pyqb8jDr7SEWsUO 9bmBNiCxij+6ROvA4AXLbWFFQfTKEfEJy2rf25lx/lnrOtUOPnNcEFvBPFABCaJ9PSy0 j+rGH3Tr5xlXkc4q+MtqDA46P/MQrDBV1XkNDKOdf05189FS80V8NMeELURjkn1IOPoV BGHXHoo3jqdef9V8pdlRdlL4ui3fIybA14LzLMGzbpfg+BOXN8uo4ZtN9AzjcuJ3kA46 w3nQ== X-Forwarded-Encrypted: i=1; AJvYcCUXoJuKcG4cIJzs0wikXTdkqWnIEMfHfcAA7uZ3VEdMpnC+VDqD1ltbgnxg2fRwCLqAauh+rQH0uPFZ@vger.kernel.org X-Gm-Message-State: AOJu0YwbPnGi38kYU1Lh4DmQ3Tt8QSmTs3Ke4pcho5AuyHr58Yd+YSWJ FnAuLDRUTPqnBLRw2R8ba/VrbNW/2wq05s6zW1eL8oeoFbL7S6DlI9uAx4B8yleYBvQKRQPbEKR PNJS0q5AxMzxTux8e7SjVbXG4kA+UvNrBd0p4GTRe2zxbTZSPuPnr+FGHkuCbJbQ= X-Gm-Gg: ASbGncsSfPd87RbYX3HMmMqRYkLF2QT5aUQJ+ihAiAZp+54XpYOvovt3mACLKUasXAz m+6m9gLFZvoGqnSj92J7hBbclvOB8r+khjuJl5VyzuzzLneTs75857C5IdaeZr+y8N8VLQk3XgE hYT77rnc02BKdprBlQ3hMDeY6qZhcBI01WjTfpIrbwOg81lNoZA4xj3NDBB9NVg79fyeQiaUsfa 5iyzdnwmeRjuIUFy7C4WAY5HdjLV0UPXJxKJCw3VuQBCKV+ZDVGa+MjvxbZkwCaLWWAJ32bIa3Y W1FzzdsuZH+hj6wT6y85gE4s6WHJGinwILB+YgJWR3djV/z9rEMyMVPkuoPPY+ylFDtFT/vSsRh BJ2QO X-Received: by 2002:a05:6000:23c8:b0:3a4:eef9:818a with SMTP id ffacd0b85a97d-3a8ff51fb85mr1792638f8f.27.1751018816827; Fri, 27 Jun 2025 03:06:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjPZ2YyzP07UvUHeXF1IowQrFwAxVkZWw/RrEy4ehDzyrnnvfw0IfiYAn/CtAHUzPqxVhAtQ== X-Received: by 2002:a05:6000:23c8:b0:3a4:eef9:818a with SMTP id ffacd0b85a97d-3a8ff51fb85mr1792609f8f.27.1751018816340; Fri, 27 Jun 2025 03:06:56 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e5f918sm2247895f8f.100.2025.06.27.03.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 03:06:55 -0700 (PDT) From: Javier Martinez Canillas To: Luca Weiss , Krzysztof Kozlowski Cc: Hans de Goede , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property In-Reply-To: References: <20250623-simple-drm-fb-icc-v2-0-f69b86cd3d7d@fairphone.com> <20250623-simple-drm-fb-icc-v2-1-f69b86cd3d7d@fairphone.com> <20250627-mysterious-optimistic-bird-acaafb@krzk-bin> Date: Fri, 27 Jun 2025 12:06:54 +0200 Message-ID: <87o6u9birl.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Luca Weiss" writes: > Hi Krzysztof, > > On Fri Jun 27, 2025 at 10:08 AM CEST, Krzysztof Kozlowski wrote: >> On Mon, Jun 23, 2025 at 08:44:45AM +0200, Luca Weiss wrote: >>> Document the interconnects property which is a list of interconnect >>> paths that is used by the framebuffer and therefore needs to be kept >>> alive when the framebuffer is being used. >>> >>> Acked-by: Thomas Zimmermann >>> Signed-off-by: Luca Weiss >>> --- >>> Documentation/devicetree/bindings/display/simple-framebuffer.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>> index 296500f9da05e296dbbeec50ba5186b6b30aaffc..f0fa0ef23d91043dfb2b220c654b80e2e80850cd 100644 >>> --- a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>> +++ b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>> @@ -79,6 +79,9 @@ properties: >>> power-domains: >>> description: List of power domains used by the framebuffer. >>> >>> + interconnects: >>> + description: List of interconnect paths used by the framebuffer. >>> + >> >> maxItems: 1, or this is not a simple FB anymore. Anything which needs >> some sort of resources in unknown way is not simple anymore. You need >> device specific bindings. > > The bindings support an arbitrary number of clocks, regulators, > power-domains. Why should I artificially limit the interconnects to only > one? > I agree with Luca here. There are device specific bindings for the device specific drivers. But this is about the generic drivers that are able to scan out using a system provided framebuffer. The display controller is setup by the firmware but it might need a set of clocks, power domains, regulators, etc left enabled in order to work. It's true that the "simple" is a misnomer, probably these drivers should had been named sysfb and sysfbdrm, or something along those lines. > The driver code also has that support added in this series. > > Regards > Luca > >> >> Best regards, >> Krzysztof > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat