Re: [PATCH v3 4/4] irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller

[Thomas Gleixner <tglx@linutronix.de>]

On Wed, Apr 09 2025 at 15:53, Chen Wang wrote:

> On 2025/4/8 13:01, Inochi Amaoto wrote:
>> Add support for Sophgo SG2044 MSI interrupt controller.
>>
>> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>> Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
>> ---
>>   drivers/irqchip/irq-sg2042-msi.c | 61 ++++++++++++++++++++++++++++++--
>>   1 file changed, 58 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-sg2042-msi.c b/drivers/irqchip/irq-sg2042-msi.c
>> index 30a1d2bfd474..2935ca213306 100644
>> --- a/drivers/irqchip/irq-sg2042-msi.c
>> +++ b/drivers/irqchip/irq-sg2042-msi.c
>> @@ -19,8 +19,6 @@
>>   
>>   #include "irq-msi-lib.h"
>>   
>> -#define SG2042_MAX_MSI_VECTOR	32
>> -
>>   struct sg204x_msi_chip_info {
>>   	const struct irq_chip		*irqchip;
>>   	const struct msi_parent_ops	*parent_ops;
>> @@ -44,7 +42,7 @@ struct sg204x_msi_chipdata {
>>   	u32					irq_first;
>>   	u32					num_irqs;
>>   
>> -	DECLARE_BITMAP(msi_map, SG2042_MAX_MSI_VECTOR);
>> +	unsigned long				*msi_map;
>
> Regarding the common parts of SG2042 and SG2044, I noticed that you 
> changed DECLARE_BITMAP back to dynamic application. If there is a next 
> version, I suggest you mention it in the commit information.

Actually that should be part of the previous patch which prepares for
configurable initialization. Then this one just adds the new variant.

Thanks,

        tglx