devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: marvell: Add 7-segment LED display on x530
@ 2024-05-30 23:16 Chris Packham
  2024-07-05 12:37 ` Gregory CLEMENT
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Packham @ 2024-05-30 23:16 UTC (permalink / raw)
  To: andrew, gregory.clement, sebastian.hesselbarth
  Cc: linux-arm-kernel, devicetree, linux-kernel, Chris Packham

The Allied Telesis x530 products have a 7-segment LED display which is
used for node identification when the devices are stacked. Represent
this as a gpio-7-segment device.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
This was originally sent as part of the series that added the seg-led-gpio
driver but wasn't applied with those changes. At the time I said I'd submit
this separately but I forgot about it until now.

 arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
index 5a9ab8410b7b..2fb7304039be 100644
--- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
+++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
@@ -43,6 +43,17 @@ uart0: serial@12000 {
 			};
 		};
 	};
+
+	led-7seg {
+		compatible = "gpio-7-segment";
+		segment-gpios = <&led_7seg_gpio 0 GPIO_ACTIVE_LOW>,
+				<&led_7seg_gpio 1 GPIO_ACTIVE_LOW>,
+				<&led_7seg_gpio 2 GPIO_ACTIVE_LOW>,
+				<&led_7seg_gpio 3 GPIO_ACTIVE_LOW>,
+				<&led_7seg_gpio 4 GPIO_ACTIVE_LOW>,
+				<&led_7seg_gpio 5 GPIO_ACTIVE_LOW>,
+				<&led_7seg_gpio 6 GPIO_ACTIVE_LOW>;
+	};
 };
 
 &pciec {
@@ -149,7 +160,7 @@ i2c@3 {
 			#size-cells = <0>;
 			reg = <3>;
 
-			gpio@20 {
+			led_7seg_gpio: gpio@20 {
 				compatible = "nxp,pca9554";
 				gpio-controller;
 				#gpio-cells = <2>;
-- 
2.45.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: marvell: Add 7-segment LED display on x530
  2024-05-30 23:16 [PATCH] ARM: dts: marvell: Add 7-segment LED display on x530 Chris Packham
@ 2024-07-05 12:37 ` Gregory CLEMENT
  0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2024-07-05 12:37 UTC (permalink / raw)
  To: Chris Packham, andrew, sebastian.hesselbarth
  Cc: linux-arm-kernel, devicetree, linux-kernel, Chris Packham

Chris Packham <chris.packham@alliedtelesis.co.nz> writes:

> The Allied Telesis x530 products have a 7-segment LED display which is
> used for node identification when the devices are stacked. Represent
> this as a gpio-7-segment device.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Applied on mvebu/dt

Thanks,

Gregory
> ---
> This was originally sent as part of the series that added the seg-led-gpio
> driver but wasn't applied with those changes. At the time I said I'd submit
> this separately but I forgot about it until now.
>
>  arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> index 5a9ab8410b7b..2fb7304039be 100644
> --- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> +++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
> @@ -43,6 +43,17 @@ uart0: serial@12000 {
>  			};
>  		};
>  	};
> +
> +	led-7seg {
> +		compatible = "gpio-7-segment";
> +		segment-gpios = <&led_7seg_gpio 0 GPIO_ACTIVE_LOW>,
> +				<&led_7seg_gpio 1 GPIO_ACTIVE_LOW>,
> +				<&led_7seg_gpio 2 GPIO_ACTIVE_LOW>,
> +				<&led_7seg_gpio 3 GPIO_ACTIVE_LOW>,
> +				<&led_7seg_gpio 4 GPIO_ACTIVE_LOW>,
> +				<&led_7seg_gpio 5 GPIO_ACTIVE_LOW>,
> +				<&led_7seg_gpio 6 GPIO_ACTIVE_LOW>;
> +	};
>  };
>  
>  &pciec {
> @@ -149,7 +160,7 @@ i2c@3 {
>  			#size-cells = <0>;
>  			reg = <3>;
>  
> -			gpio@20 {
> +			led_7seg_gpio: gpio@20 {
>  				compatible = "nxp,pca9554";
>  				gpio-controller;
>  				#gpio-cells = <2>;
> -- 
> 2.45.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-07-05 12:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30 23:16 [PATCH] ARM: dts: marvell: Add 7-segment LED display on x530 Chris Packham
2024-07-05 12:37 ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).