From: Thomas Gleixner <tglx@linutronix.de>
To: Changhuang Liang <changhuang.liang@starfivetech.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>,
Jack Zhu <jack.zhu@starfivetech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: 回复: [PATCH v2 2/2] irqchip: Add StarFive external interrupt controller
Date: Tue, 20 Feb 2024 10:28:02 +0100 [thread overview]
Message-ID: <87o7cbiixp.ffs@tglx> (raw)
In-Reply-To: <SHXPR01MB0671BD046F6E3F3A215414A6F252A@SHXPR01MB0671.CHNPR01.prod.partner.outlook.cn>
On Sun, Feb 18 2024 at 02:36, Changhuang Liang wrote:
>> On Mon, Jan 29 2024 at 21:58, Changhuang Liang wrote:
> [...]
>> > +static void starfive_intc_mod(struct starfive_irq_chip *irqc, u32
>> > +reg, u32 mask, u32 data) {
>> > + u32 value;
>> > +
>> > + value = ioread32(irqc->base + reg) & ~mask;
>> > + data &= mask;
>>
>> Why?
>>
>
> If I want to update the reg GENMASK(7, 4) to value 5, the data I
> will pass in 5 << 4
All call sites pass a single bit to set/clear, right? So this GENMASK
argument does not make sense at all.
Thanks,
tglx
next prev parent reply other threads:[~2024-02-20 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 5:58 [PATCH v2 0/2] Add JH8100 external interrupt controller support Changhuang Liang
2024-01-30 5:58 ` [PATCH v2 1/2] dt-bindings: interrupt-controller: Add starfive,jh8100-intc Changhuang Liang
2024-01-30 5:58 ` [PATCH v2 2/2] irqchip: Add StarFive external interrupt controller Changhuang Liang
2024-02-13 9:03 ` Thomas Gleixner
2024-02-18 2:36 ` 回复: " Changhuang Liang
2024-02-20 9:28 ` Thomas Gleixner [this message]
2024-02-20 9:39 ` 回复: " Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7cbiixp.ffs@tglx \
--to=tglx@linutronix.de \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).