From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF8822EAF9; Tue, 9 Jan 2024 09:14:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="naGn6h5G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13FA4C433F1; Tue, 9 Jan 2024 09:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704791644; bh=+06NMjLMy7+S0OcYAENUNHQLBwEXKnqYTwCvjFTXoVo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=naGn6h5G/6LHXS86a+lEsUu6Z0GXyfdbelfib8WBnJgW8wCSOppf2X8p2llo/pSnM /c3R7m5/EQyL4cwZNRgIVXFQmvp+KJg5lTHNLqL/ztc359qhvQaHOQeRtUOB311KjO HhQVXTJw3Nhq0BvsCqw7vuEgkGvJfqo7daporh375JTpqat7AX81VZ2ZzVQ3Lan7h8 haEwOfoNrZmYNPjQQB9nyKmx/9LDDWJRW/1qjFZAH1XHihrWapFpeQejQx2JrvOxPN NbeoHoMkTkaaIOXgmqDbamqDtjHSxyFeYCWwGTb+k2oxYqoGnLfWAWSJBpBhmIXmrs X/5GNfkYry1hA== From: Kalle Valo To: Krzysztof Kozlowski Cc: Bartosz Golaszewski , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Catalin Marinas , Will Deacon , Bjorn Helgaas , Heiko Stuebner , Jernej Skrabec , Chris Morgan , Linus Walleij , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , =?utf-8?Q?N=C3=ADcolas?= F . R . A . Prado , Marek Szyprowski , Peng Fan , Robert Richter , Dan Williams , Jonathan Cameron , Terry Bowman , Kuppuswamy Sathyanarayanan , Ilpo =?utf-8?Q?J=C3=A4rvinen?= , Huacai Chen , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Bartosz Golaszewski Subject: Re: [RFC 7/9] dt-bindings: wireless: ath11k: describe QCA6390 References: <20240104130123.37115-1-brgl@bgdev.pl> <20240104130123.37115-8-brgl@bgdev.pl> <82a669f5-259d-427c-b290-6fa1470fec79@linaro.org> Date: Tue, 09 Jan 2024 11:13:54 +0200 In-Reply-To: <82a669f5-259d-427c-b290-6fa1470fec79@linaro.org> (Krzysztof Kozlowski's message of "Thu, 4 Jan 2024 16:57:52 +0100") Message-ID: <87o7duzx65.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Krzysztof Kozlowski writes: > On 04/01/2024 14:01, Bartosz Golaszewski wrote: > >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> index 817f02a8b481..f584c25f4276 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> @@ -16,6 +16,7 @@ description: | >> properties: >> compatible: >> enum: >> + - pci17cb,1101 # QCA6390 >> - pci17cb,1103 # WCN6855 >> >> reg: >> @@ -27,6 +28,19 @@ properties: >> string to uniquely identify variant of the calibration data for designs >> with colliding bus and device ids >> >> + enable-gpios: >> + description: GPIO line enabling the ATH11K module when asserted. >> + maxItems: 1 >> + >> + vddpmu-supply: >> + description: VDD_PMU supply regulator handle >> + >> + vddpcie1-supply: >> + description: VDD_PCIE1 supply regulator handle >> + >> + vddpcie2-supply: >> + description: VDD_PCIE2 supply regulator handle > > Looks like these are valid only for specific variant, so you should have > allOf:if:then disallowing other properties when not applicable. The same > applies for existing properties which might not exist on qca6390. And it would be good to provide more information in the commit log about the platforms where this is used, otherwise the context might not be clear. Or maybe document that in the bindings file, not sure. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches