From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH] of: Fix cpu node iterator to not ignore disabled cpu nodes Date: Thu, 01 Nov 2018 22:08:46 +1100 Message-ID: <87o9b9dphd.fsf@concordia.ellerman.id.au> References: <20181031144226.26747-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20181031144226.26747-1-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Zigotzky , Frank Rowand List-Id: devicetree@vger.kernel.org Rob Herring writes: > In most cases, nodes with 'status = "disabled";' are treated as if the > node is not present though it is a common bug to forget to check that. > However, cpu nodes are different in that "disabled" simply means offline > and the OS can bring the CPU core online. Commit f1f207e43b8a ("of: Add > cpu node iterator for_each_of_cpu_node()") followed the common behavior > of ignoring disabled cpu nodes. This breaks some powerpc systems (at > least NXP P50XX/e5500). Fix this by dropping the status check. > > Fixes: 651d44f9679c ("of: use for_each_of_cpu_node iterator") > Fixes: f1f207e43b8a ("of: Add cpu node iterator for_each_of_cpu_node()") > Reported-by: Michael Ellerman > Cc: Christian Zigotzky > Cc: Frank Rowand > Signed-off-by: Rob Herring > --- > drivers/of/base.c | 2 -- > 1 file changed, 2 deletions(-) This fixes my machine, thanks. Tested-by: Michael Ellerman It was actually originally reported to me by Christian, so also: Reported-by: Christian Zigotzky cheers > diff --git a/drivers/of/base.c b/drivers/of/base.c > index cc62da278663..e47c5ce6cd58 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -776,8 +776,6 @@ struct device_node *of_get_next_cpu_node(struct device_node *prev) > if (!(of_node_name_eq(next, "cpu") || > (next->type && !of_node_cmp(next->type, "cpu")))) > continue; > - if (!__of_device_is_available(next)) > - continue; > if (of_node_get(next)) > break; > } > -- > 2.19.1