From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [RFT PATCH v2 2/3] ARM: Fix *MIGHT_HAVE_PCI* config from being selected redundantly Date: Mon, 01 Aug 2016 21:10:22 +0200 Message-ID: <87oa5cxq3l.fsf@belgarion.home> References: <1470049950-4697-1-git-send-email-kishon@ti.com> <1470049950-4697-3-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1470049950-4697-3-git-send-email-kishon@ti.com> (Kishon Vijay Abraham, I's message of "Mon, 1 Aug 2016 16:42:29 +0530") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kishon Vijay Abraham I Cc: Mark Rutland , Krzysztof Kozlowski , Tony Lindgren , linux-pci@vger.kernel.org, Nicolas Ferre , Alexandre Belloni , Greg Ungerer , linux-samsung-soc@vger.kernel.org, Viresh Kumar , Magnus Damm , Russell King , Kukjin Kim , helgaas@kernel.org, Jean-Christophe Plagniol-Villard , devicetree@vger.kernel.org, Sascha Hauer , Arnd Bergmann , nsekhar@ti.com, Haojian Zhuang , Simon Horman , Krzysztof Halasa , Santosh Shilimkar , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.orgShiraz Hashim List-Id: devicetree@vger.kernel.org Kishon Vijay Abraham I writes: > *MIGHT_HAVE_PCI* config is already selected in ARCH_MULTIPLATFORM. > Fix it from getting redundantly selected in all > ARCH_MULTIPLATFORM based machines. If that's the purpose, then CM-X255 and CM-X270 don't fall in that category, as they are not part of ARCH_MULTIPLATFORM nor ready for it AFAIK. So the change below shouldn't be done according to the commit message. > diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig > index cd894d6..39f7755 100644 > --- a/arch/arm/mach-pxa/Kconfig > +++ b/arch/arm/mach-pxa/Kconfig > @@ -113,7 +113,6 @@ config MACH_ARMCORE > bool "CompuLab CM-X255/CM-X270 modules" > select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI > select IWMMXT > - select MIGHT_HAVE_PCI > select NEED_MACH_IO_H if PCI > select PXA25x > select PXA27x Cheers. -- Robert