From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E6F43A1D9 for ; Mon, 18 Dec 2023 15:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BcrtJ6qT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702912519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HuaiH4rqzFFEALDPC43fTJimMBRbpfVpYg9fBcqQC3E=; b=BcrtJ6qTULF8wuhx5N+NSkGQ8XUL16roij5hBT36fbpCIsHWFvD74mL+BoU8by/2LUb6tT +iSSDUuF9HFR2EhoJwmYoUKb1wcQCnzfQ7BxgD0/xwTaqRGIN1MMDTOUiJK9G5FAiTDH1n XsVYtKq9KP+TVUMeGTGvPM3njnUCwlA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-5l6JxBP4OO-xrQkeD6pHfA-1; Mon, 18 Dec 2023 10:15:16 -0500 X-MC-Unique: 5l6JxBP4OO-xrQkeD6pHfA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3366d22d650so402993f8f.0 for ; Mon, 18 Dec 2023 07:15:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702912515; x=1703517315; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HuaiH4rqzFFEALDPC43fTJimMBRbpfVpYg9fBcqQC3E=; b=Fy5h/7yFTfU7FnT5QltgnvL+JZrWIGbLCiq79vgZTn4ypDKWuf67wNL0IJW3vAg6Rd s66OWss1ALVfEqQbIYDdQfvncnzAwrgQ0+s0id/XfxfF9oF6axGmEM52IY1HtrxnGEMh KO8EkkiJwLhPQGZHci8a51NUhyojuFxfHBXdE+bw9KPaMF0MAV84g0aFLMLWAuVEZp/m p1Gk8JGnAMhpPQpL9ahrzUXf0q/mQGt+nDRL2RTpqhYQAX7JMeoHrc7x2lpXxbtix4Zi DcYFhMn1pHoh7xyns/1kSHGtBXNrs3uOdfo72PhPsuBTHzENES6CTjUd2azMc4sMnrhU c/yw== X-Gm-Message-State: AOJu0YzN1gG4EGpIezsAmoqwd4tkeo8Zy/3Sbx1hwk2etw4VoSuN0ddC hbSvGgoQncTVLp7fEOH+mnrFXDuifSRCkqO8CooBPGAWOFlUfTXCJ8V/mQs1QiW1XD5kHOgTdL5 21BJ1vB6zS7PjzSJfvH4N7A== X-Received: by 2002:a05:600c:3146:b0:40c:3e7c:9e45 with SMTP id h6-20020a05600c314600b0040c3e7c9e45mr7221908wmo.179.1702912515215; Mon, 18 Dec 2023 07:15:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IH01NYRqs0cLPJmrbSp3Nv2uqyGIyLK81ZTxxjSLq4MH5WQAhaSsNI+INBXpQtGjJJeLQo86Q== X-Received: by 2002:a05:600c:3146:b0:40c:3e7c:9e45 with SMTP id h6-20020a05600c314600b0040c3e7c9e45mr7221888wmo.179.1702912514806; Mon, 18 Dec 2023 07:15:14 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id a16-20020adffad0000000b003366fa08c2dsm41371wrs.83.2023.12.18.07.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 07:15:14 -0800 (PST) From: Javier Martinez Canillas To: Conor Dooley Cc: linux-kernel@vger.kernel.org, Maxime Ripard , Jocelyn Falempe , Krzysztof Kozlowski , Geert Uytterhoeven , Thomas Zimmermann , Peter Robinson , Rob Herring , Conor Dooley , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Maarten Lankhorst , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers In-Reply-To: <20231218-example-envision-b41ca8efa251@spud> References: <20231218132045.2066576-1-javierm@redhat.com> <20231218132045.2066576-2-javierm@redhat.com> <20231218-example-envision-b41ca8efa251@spud> Date: Mon, 18 Dec 2023 16:15:13 +0100 Message-ID: <87plz3leym.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Conor Dooley writes: Hello Conor, Thanks a lot for your feedback. > On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote: [...] >> + >> + - properties: >> + width: >> + default: 96 >> + height: >> + default: 64 > > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml b/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml > index 8feee9eef0fd..ffc939c782eb 100644 > --- a/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml > +++ b/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml > @@ -9,24 +9,24 @@ title: Solomon SSD133x OLED Display Controllers > maintainers: > - Javier Martinez Canillas > > +allOf: > + - $ref: solomon,ssd-common.yaml# > + > properties: > compatible: > enum: > - solomon,ssd1331 > > + width: > + default: 96 > + > + height: > + default: 64 > + > required: > - compatible > - reg > > -allOf: > - - $ref: solomon,ssd-common.yaml# > - > - - properties: > - width: > - default: 96 > - height: > - default: 64 > - > unevaluatedProperties: false > > examples: > > The properties stuff doesn't need to be in the allOf. Although, I took Ok. > the opportunity to look at ssd-common.yaml. How do the height/width here > differ from the vendor prefixed versions in that file? Oh! That is an error in the schema that I introduced when adding the binding for the SSD132x family in commit 2d23e7d6bacb ("dt-bindings: display: Add SSD132x OLED controllers"), and I just copied it to this binding as well making the same mistake... I'll fix that with a preparatory patch to use "solomon,{width,height}" everywhere in v3 and also include your suggested changes for this patch. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat