Re: [PATCH] ARM: dts: dlink-dns327l: fix reg-init PHY

[Gregory CLEMENT <gregory.clement@bootlin.com>]

Daniel González Cabanelas <dgcbueu@gmail.com> writes:

> The marvell PHY reg-init registers for the D-Link DNS-327L are wrong.
> Currently the first field is used to set the page 2, but this is
> pointless. The usage is not correct, and we are setting the wrong
> registers.
>
> Fix it.
>
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> index baa459dd5..2008c6eaa 100644
> --- a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> +++ b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> @@ -247,9 +247,8 @@ &uart1 {
>  &mdio {
>  	phy0: ethernet-phy@0 { /* Marvell 88E1318 */
>  		reg = <0>;
> -		marvell,reg-init = <0x0 0x16 0x0 0x0002>,
> -				<0x0 0x19 0x0 0x0077>,
> -				<0x0 0x18 0x0 0x5747>;
> +		marvell,reg-init = <0x2 0x19 0x0 0x0077>,
> +				   <0x2 0x18 0x0 0x5747>;
>  	};
>  };
>  
> -- 
> 2.27.0
>
>
>
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com