From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [RFC PATCH v2 07/15] usb:cdns3: Adds Device mode support - initialization. Date: Wed, 28 Nov 2018 13:40:34 +0200 Message-ID: <87pnupzaz1.fsf@linux.intel.com> References: <1542535751-16079-1-git-send-email-pawell@cadence.com> <1542535751-16079-8-git-send-email-pawell@cadence.com> <5BFE7D2E.7030702@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: In-Reply-To: <5BFE7D2E.7030702@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Roger Quadros , Pawel Laszczak , devicetree@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com List-Id: devicetree@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: >> +static void cdns3_gadget_config(struct cdns3_device *priv_dev) >> +{ >> + struct cdns3_usb_regs __iomem *regs =3D priv_dev->regs; >> + >> + cdns3_ep0_config(priv_dev); >> + >> + /* enable interrupts for endpoint 0 (in and out) */ >> + writel(EP_IEN_EP_OUT0 | EP_IEN_EP_IN0, ®s->ep_ien); >> + >> + /* enable generic interrupt*/ >> + writel(USB_IEN_INIT, ®s->usb_ien); >> + writel(USB_CONF_CLK2OFFDS | USB_CONF_L1DS, ®s->usb_conf); >> + writel(USB_CONF_DMULT, ®s->usb_conf); >> + writel(USB_CONF_DEVEN, ®s->usb_conf); > > If you are enabling interrupts in this patch you should handle them in th= e ISR. Frankly, I don't understand why this is a series. It's a single driver and splitting it into a series just makes it more difficult to review, actually. Sure, a single patch will be large, but there's no way to have a functional driver until all patches are applied, anyway. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlv+frIACgkQzL64meEa mQaSCA//ba2iHqRFxanq2zE1pQTnNGzW1MK/CdzlJ5L8YYB2g8B0CZZk/Zztvee/ 0c5T/rlv60qUUVcAfXXZWjQoZZg6TUgXce6kR8C4MGnL3EHwh77TvRRYO54X90YR Oytf4QhyAp/5fsL4DGRXVGPiK5OossxZYxIkWpXIiVyORcV7FaZuykjePTNY/vGg Bv1AKPw+F0M+C3CSBphdxxTPqy10Su97GPCdZZql1P5j8jOVsUO6CjcNUIK2WSqn k2r4JVnBWNO1D7v1/tGXybWxIHvUBCuSs6enFMoPdxCPTIRGtkN5ijLBkuAxiMvk LWrV+D7vHLNCdngQmex/A/YezubvjUs0WfMDh8bTy/UjxeLZYIdWcD3JNFQ0IisV i9g9PMfR2Gy5C3XJq3vAYZz9kQgpnzkmuHdMNfpuY56FzzkHdJXEvTVr37EGOEHx VTbe1FkOD+dD5RoXtxK4ImaOYDoSicKQ5SqyjtCk1RypjI7FDXGucOouD6Jca2Z5 Y6fX+75juJQIhsj51s7g3fSTsnqA9IMbPOpJki+xpvGotiVCzYTdQX3Uc6Ti//g2 YjkRKmjvp6uYtqEWYimWIGHXrTJGoqvrFOh17ubF/6T4Ufv7fMBhXSTUjocBo0j2 nObCbcPqwsCs0/PWAgHd1X2kVcFUyPJR+BjmPtFwoFqeDy8W0tw= =lrhC -----END PGP SIGNATURE----- --=-=-=--