From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 3/6] arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv Date: Wed, 22 Nov 2017 17:59:23 +0100 Message-ID: <87po8az1uc.fsf@free-electrons.com> References: <20171109222614.5719-1-robh@kernel.org> <20171109222614.5719-3-robh@kernel.org> <20171121200922.GD30040@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Arnd Bergmann's message of "Tue, 21 Nov 2017 21:45:49 +0100") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Andrew Lunn , Rob Herring , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arm@kernel.org" , Jason Cooper , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Hi Arnd, On mar., nov. 21 2017, Arnd Bergmann wrote: > On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn wrote: >> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote: >>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring wrote: >>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells >>> > property. This is probably because the binding was the precursor to the phy >>> > binding. >>> > >>> > Fixes the following warning in Marvell dts files: >>> > >>> > Warning (phys_property): Missing property '#phy-cells' in node ... >>> > >>> > Signed-off-by: Rob Herring >>> > Cc: Jason Cooper >>> > Cc: Andrew Lunn >>> > Cc: Gregory Clement >>> > Cc: Sebastian Hesselbarth >>> > --- >>> > Please apply to Marvell tree. >>> >>> Ping. >>> >>> Arnd, can you apply if you'd like the warnings fixed and Marvell >>> maintainers don't respond. >> >> Hi Rob >> >> Patches submitted a week before the merge window opens are generally >> deferred to the next cycle. I expect that once -rc1 is out, Gregory >> will pick up this patch. > > These are real bugfixes, I want them in 4.15, since we now get a > loud warning for them. I'd rather not shut up that warning because > it's not a false-positive. As pointed by Andrew, I planned to take them once the 4.15-rc1 would be released. It was not obvious for me that it was real fixes. Actually I would have expected to have first the dts fixed in a release and then the warning enabled. I am fine if you take this patch, especially if it is merged in 4.15-rc1. So for this patch: Acked-by: Gregory CLEMENT Thanks, Gregory > > Arnd -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html