Re: [PATCHv2] ARM: mvebu: Add Netgear ReadyNAS 2120 board

Arnaud Ebalard
2013-11-11T20:53:55Z

Hi Sebastian.

Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

>> + serial@12000 {
>> + clocks = <&coreclk 0>;
>> + status = "okay";
>> + };
>
> For your possible cleanup later: move clocks = <&coreclk 0> to
> armada-370-xp.dtsi and remove this then.
>
> Also for cleanup later: It would be great if most SoC nodes get
> a node label. That way you can just write:
>
> uart0: { status = "okay" };
>
> without replaying node hierarchy over and over again.

I will keep that in mind for later cleanups. Regarding the nits, as you
took the time to report those, I will send a v3 fixing them tomorrow.

Cheers,,