From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Shishkin Subject: Re: [PATCH 4/9] usb: chipidea: ci13xxx-imx: add "dr_mode" property to device tree bindings Date: Thu, 29 Nov 2012 14:54:02 +0200 Message-ID: <87pq2wmuxh.fsf@ashishki-desk.ger.corp.intel.com> References: <1352909950-32555-1-git-send-email-m.grzeschik@pengutronix.de> <1352909950-32555-5-git-send-email-m.grzeschik@pengutronix.de> <878va17oii.fsf@ashishki-desk.ger.corp.intel.com> <20121126094626.GB15740@nchen-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121126094626.GB15740@nchen-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Peter Chen Cc: fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, Michael Grzeschik , gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Peter Chen writes: > On Fri, Nov 16, 2012 at 01:53:09PM +0200, Alexander Shishkin wrote: >> Michael Grzeschik writes: >> I'd prefer this function to live in ci13xxx_imx, since that's where it's >> used and it doesn't really need anything from core.c anyway. Or maybe it >> would make sense to make it even more generic (for other devitetree >> users), since you're saying that other drivers are using this already. >> >> Looks good to me otherwise. > > I think it supplies a way that the platform can override the usb role, > only freescale uses it, but also other platforms may use it. It is a > generic feature, other chipidea users may need it. I'm not objecting against the flags, I just don't like the function in chipidea core. Platform code can just use the flags. It can be either part of the platform driver or a generic dt helper, in case there are more users, it doesn't belong to chipidea core. Regards, -- Alex