From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0891C77B7A for ; Sat, 10 Jun 2023 17:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbjFJRwd (ORCPT ); Sat, 10 Jun 2023 13:52:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjFJRwb (ORCPT ); Sat, 10 Jun 2023 13:52:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E484B3A84 for ; Sat, 10 Jun 2023 10:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686419506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pKSaQZ4znfpr2ozE1Mb7MZQL8rtwbT4mvdyngtft6oE=; b=ZXQGPq3vKajTzwFhJ8V/qjjAMZVSK8dZoeyoHLPr0l5LYLqkawMv83aDNMyFpO3NlOmRVX r+5ga557CVu0ZI6KqQuGKqkasMeonODzKEXygxC0l7P1xlt0g8h3xsPsqeYdQxvEunQ6Ds GqRGd63YnPlmCa9SbjmfhPH/jTxfMDY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-y3QIvfddONeQvibEG3-OKQ-1; Sat, 10 Jun 2023 13:51:44 -0400 X-MC-Unique: y3QIvfddONeQvibEG3-OKQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f5df65fa35so12451555e9.3 for ; Sat, 10 Jun 2023 10:51:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686419503; x=1689011503; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pKSaQZ4znfpr2ozE1Mb7MZQL8rtwbT4mvdyngtft6oE=; b=aCzRAUFcRyJA4YeaSjtUpm6sskQoIaCbja2BmCSZtNbvZEi30y4G8DeWKxUPITJrR3 2TYXe2euU2P9UKnweGtj08DJkvqbaSw5dy1BWJonpimiFwCVxcEwDkzjA4p3suXWaktT l+I8RZ2iTNR2nPo29sQAXGPaR4W3CSmW9HRmpOOjHaFuidgQC8h/UB1IOt0Jj+aLO7Gq rueVZsNiBQjQ8uS9zMU3hLqjq40z8J1E/71e4jkarOj4dOvwNn5YgtGruyT1aE0y4dQf pLNDdbLDXLktW4bSBlWDv7Jd4KcQWhJCFsmu50uoYQDIiDIK0NjAnNSpXSKlM1vY3oa+ A5vw== X-Gm-Message-State: AC+VfDwyz8sux8hf+vJnosIP93LpyNtNecRHTLd1rclCycAgzApTHUYg TzMJIE9j5RXkSFkN/QS1VxXVQ6ESrdvX/XrhsPcuCM6I7h2No4knQZiHCFettxp2F6ScVIjijEE Ngf5k+vVbjO603GmV8nA4/g== X-Received: by 2002:a05:600c:2189:b0:3f7:81e9:2f02 with SMTP id e9-20020a05600c218900b003f781e92f02mr2985116wme.4.1686419503153; Sat, 10 Jun 2023 10:51:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4oloD0EK/STe16UJZzvVaQXGexNAqmk7NaH1zGxsm7M2y6ZMJc4nxV7hPbfHGklvgtsvLviw== X-Received: by 2002:a05:600c:2189:b0:3f7:81e9:2f02 with SMTP id e9-20020a05600c218900b003f781e92f02mr2985110wme.4.1686419502754; Sat, 10 Jun 2023 10:51:42 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id g26-20020a7bc4da000000b003f60e143d38sm6287776wmk.11.2023.06.10.10.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 10:51:42 -0700 (PDT) From: Javier Martinez Canillas To: Conor Dooley Cc: devicetree@vger.kernel.org, Conor Dooley , Thomas Zimmermann , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Maxime Ripard , Rob Herring , Geert Uytterhoeven , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values In-Reply-To: <20230610-opposite-quality-81d4a1561c88@spud> References: <20230609170941.1150941-1-javierm@redhat.com> <20230609170941.1150941-3-javierm@redhat.com> <20230610-opposite-quality-81d4a1561c88@spud> Date: Sat, 10 Jun 2023 19:51:35 +0200 Message-ID: <87r0qj19zs.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Conor Dooley writes: > On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: >> A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 >> anymore. Instead is set to a width and height that's controller dependent. > > Did that change to the driver not break backwards compatibility with > existing devicetrees that relied on the default values to get 96x16? > It would but I don't think it is an issue in pratice. Most users of these panels use one of the multiple libraries on top of the spidev interface. For the small userbase that don't, I believe that they will use the rpif kernel and ssd1306-overlay.dtbo DTB overlay, which defaults to width=128 and height=64 [1]. So those users will have to explicitly set a width and height for a 96x16 panel anyways. The intersection of users that have a 96x16 panel, assumed that default and consider the DTB a stable ABI, and only update their kernel but not the DTB should be very small IMO. [1]: https://github.com/raspberrypi/linux/blob/rpi-6.1.y/arch/arm/boot/dts/overlays/ssd1306-overlay.dts > Cheers, > Conor. > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat