From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14975C76195 for ; Mon, 27 Mar 2023 16:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbjC0QHi (ORCPT ); Mon, 27 Mar 2023 12:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232787AbjC0QHh (ORCPT ); Mon, 27 Mar 2023 12:07:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E206FBF for ; Mon, 27 Mar 2023 09:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679933212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MTwv4j9Dt3cE1Rn1R2k+nbDL5QUCJu5c21gncHvR2lM=; b=ivp05J9afEKTUiY3LZ++pDW/K95Uj42gfdoMS75DHOdwjiGYm+Qj52zzaLeqHqtY7va/xQ peEzwBAUURKqmcVHdU9fr2CMpbeh/ZehghqhPYTb4DW4L/AsAMyD9jeZmFCBxWNd4mZog+ cyH5tbkh/cXh1FBPrext7vPk5jwC3rA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-AzjhJJtMN8SimxvJrhzJdg-1; Mon, 27 Mar 2023 12:06:45 -0400 X-MC-Unique: AzjhJJtMN8SimxvJrhzJdg-1 Received: by mail-wr1-f71.google.com with SMTP id s28-20020adfa29c000000b002d92bb99383so834120wra.23 for ; Mon, 27 Mar 2023 09:06:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679933205; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MTwv4j9Dt3cE1Rn1R2k+nbDL5QUCJu5c21gncHvR2lM=; b=fWniXd2ohAREwVA0u8we7zUEwUeqvHmvNnkfC7ok8nQXjQJ52FkpGTJS/3YpuSEIKX Tvt+BcWF8SlhbRkwuoY8jhnOk2R63RkyDuhpoIz4/yq7xLSra8hQR+4QjUMU607CJySC mqEcfMwxmo7Md50zhnOjW9p8tfft2FFXi/fQeFHnc2dZfjMgQ2RJMGihwd+xs/yBPyVL CuWvzjWvOrj5p0Vd2HJyKGegWklHLDmqJ4oSn1PUbO1obsRiHnAH9/lPijy8lmUjiV/2 tI+pknOg08Qw9Rz7naLokBS4aMgekK3f4Mdrrxa6hR98a1eGTICNpWEcDkkUc1vK0bMT /OvQ== X-Gm-Message-State: AO0yUKV+mTGycGez5yyH8+WHOOjg8nrQfTfwc6fs+egEePZ4hbWAG/9D x09x+bh3cxSx9YNt/+ZwR7A8YqgsNjE/X1VLYq2thAegJekBfHgc7RcOyv5mFhO++Iz2qAmMk5A vLnt+QH7d9BX7NnSlKjzKWg== X-Received: by 2002:a1c:6a05:0:b0:3ee:138f:be54 with SMTP id f5-20020a1c6a05000000b003ee138fbe54mr9967821wmc.3.1679933204853; Mon, 27 Mar 2023 09:06:44 -0700 (PDT) X-Google-Smtp-Source: AK7set/4VpQPD+Dnoy5eFSGDAYNq2D3uuoqcCuqB5KNtZBlZO7dGv45tAgjmZujpD3LTO+xh5ItTZA== X-Received: by 2002:a1c:6a05:0:b0:3ee:138f:be54 with SMTP id f5-20020a1c6a05000000b003ee138fbe54mr9967801wmc.3.1679933204578; Mon, 27 Mar 2023 09:06:44 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id z4-20020a05600c0a0400b003ef4cd057f5sm9441471wmp.4.2023.03.27.09.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 09:06:44 -0700 (PDT) From: Javier Martinez Canillas To: Heiko =?utf-8?Q?St=C3=BCbner?= , =?utf-8?Q?Ond=C5=99e?= =?utf-8?Q?j?= Jirman Cc: linux-kernel@vger.kernel.org, Robert Mader , Laurent Pinchart , Peter Robinson , Jacopo Mondi , Martijn Braam , Kamil =?utf-8?Q?Trzci=C5=84ski?= , Caleb Connolly , Jarrah Gosbell , Krzysztof Kozlowski , Rob Herring , Tom Fitzhenry , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support In-Reply-To: <1924921.PYKUYFuaPT@diego> References: <20230327074136.1459212-1-javierm@redhat.com> <20230327130147.wgxl2qayhzsi2xak@core> <87wn32rynm.fsf@minerva.mail-host-address-is-not-set> <1924921.PYKUYFuaPT@diego> Date: Mon, 27 Mar 2023 18:06:43 +0200 Message-ID: <87r0tarxf0.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Heiko St=C3=BCbner writes: > Am Montag, 27. M=C3=A4rz 2023, 17:39:57 CEST schrieb Javier Martinez Cani= llas: >> Ond=C5=99ej Jirman writes: >>=20 >> Hell Ond=C5=99ej, >>=20 >> > Hi Javier, >> > >> > I've tried the patch on top of linus/master and it works as expected. = My >> > DRM test app shows 16.669ms between frames. The display output is ok on >> > developer batch pinephone pro, and is corrupted on production version. >> > Display also doesn't come back after blanking. All as expected. >> > >> > Tested-by: Ondrej Jirman >> > >>=20 >> Thanks for testing. >>=20 >> > A few more comments below. >> > >>=20 >> I'm OK with these comments but I did a git diff with your orange-pi-6.3 >> branch just before posting and this was the latest that's in your tree. >>=20 >> So feel free to either post a v3 addressing the things you are pointing >> out or lets land this and we can post any further cleanups on top IMO. > > I would really like to _not_ apply essentially broken code, so really > would prefer the v3-approach. > > Thanks > Heiko > > --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat