From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/2] gpio/omap: maintain GPIO and IRQ usage separately Date: Fri, 27 Sep 2013 11:08:43 -0700 Message-ID: <87r4cajfx0.fsf@linaro.org> References: <1380069414-2922-1-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1380069414-2922-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> (Javier Martinez Canillas's message of "Wed, 25 Sep 2013 02:36:52 +0200") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas Cc: Linus Walleij , Santosh Shilimkar , Stephen Warren , Lars Poeschel , Grant Likely , Mark Rutland , Ian Campbell , Kumar Gala , Pawel Moll , Tomasz Figa , Enric Balletbo i Serra , Jean-Christophe PLAGNIOL-VILLARD , Balaji T K , Tony Lindgren , Jon Hunter , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, r.sricharan-l0cyMroinI0@public.gmane.org, holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org List-Id: devicetree@vger.kernel.org Javier Martinez Canillas writes: > The GPIO OMAP controller pins can be used as IRQ and GPIO > independently so is necessary to keep track GPIO pins and > IRQ lines usage separately to make sure that the bank will > always be enabled while being used. > > Also move gpio_is_input() definition in preparation for the > next patch that setups the controller's irq_chip driver when > a caller requests an interrupt line. > > Signed-off-by: Javier Martinez Canillas I'm fine with this appproach. For both patches: Reviewed-by: Kevin Hilman Also, I gave it a spin across a handful of OMAP boards using v3.12-rc2 + these 2 patches. Boot tested successfully with DT boot: omap3530/beagle omap3730/beagle-xm omap3530/overo (Tobi w/GPIO IRQ networking) omap3730/overo STORM (w/GPIO IRQ for networking) am335x/beaglebone am335x/beaglebone black omap4430/panda omap4460/panda-es omap5912/OSK (omap1) I also verified non-DT boot on the OMAP3 platforms that still support legacy boot. So feel free to also add Tested-by: Kevin Hilman Thanks for your persistence in getting a fix for this upstream. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html