From: Michael Ellerman <mpe@ellerman.id.au>
To: Amit Machhiwal <amachhiw@linux.ibm.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: Lizhi Hou <lizhi.hou@amd.com>, Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm-ppc@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Saravana Kannan <saravanak@google.com>,
Vaibhav Jain <vaibhav@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Vaidyanathan Srinivasan <svaidy@linux.ibm.com>,
Kowshik Jois B S <kowsjois@linux.ibm.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest
Date: Fri, 26 Jul 2024 22:49:31 +1000 [thread overview]
Message-ID: <87sevwuxlw.fsf@mail.lhotse> (raw)
In-Reply-To: <dx32q3sa4oopk3fnm2zyeplotuq6gq3rmnbmaw3mo4q3lgjpe7@gvpgu4rdk4f4>
Amit Machhiwal <amachhiw@linux.ibm.com> writes:
> Hi Bjorn,
>
> On 2024/07/25 03:55 PM, Bjorn Helgaas wrote:
>> On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote:
>> > ...
>> > The crash in question is a critical issue that we would want to have
>> > a fix for soon. And while this is still being figured out, is it
>> > okay to go with the fix I proposed in the V1 of this patch?
>>
>> v6.10 has been released already, and it will be a couple months before
>> the v6.11 release.
>>
>> It looks like the regression is 407d1a51921e, which appeared in v6.6,
>> almost a year ago, so it's fairly old.
>>
>> What target are you thinking about for the V1 patch? I guess if we
>> add it as a v6.11 post-merge window fix, it might get backported to
>> stable kernels before v6.11?
>
> Yes, I think we can go ahead with taking V1 patch for v6.11 post-merge window to
> fix the current bug and ask Ubuntu to pick it while Lizhi's proposed patch goes
> under test and review.
Lizhi's proposed patch (v3?) looks pretty small and straight forward.
It should be possible to get it tested and reviewed and merge it as a
fix during the v6.11-rc series.
Or if the CONFIG option is completely broken as Rob suggests then it
should just be forced off in Kconfig.
cheers
next prev parent reply other threads:[~2024-07-26 12:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 8:07 [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest Amit Machhiwal
2024-07-15 16:20 ` Lizhi Hou
2024-07-15 17:23 ` Bjorn Helgaas
2024-07-15 20:35 ` Lizhi Hou
2024-07-15 18:55 ` Rob Herring
2024-07-15 20:52 ` Lizhi Hou
2024-07-23 16:21 ` Rob Herring
2024-07-23 18:21 ` Lizhi Hou
2024-07-23 19:54 ` Rob Herring
2024-07-23 21:08 ` Lizhi Hou
2024-07-25 17:45 ` Amit Machhiwal
2024-07-25 20:55 ` Bjorn Helgaas
2024-07-26 5:49 ` Amit Machhiwal
2024-07-26 12:49 ` Michael Ellerman [this message]
2024-07-25 23:06 ` Lizhi Hou
2024-07-26 17:52 ` Rob Herring
2024-07-26 18:45 ` Lizhi Hou
2024-07-29 11:13 ` Amit Machhiwal
2024-07-29 16:47 ` Lizhi Hou
2024-07-29 16:55 ` Amit Machhiwal
2024-07-29 18:19 ` Lizhi Hou
2024-07-26 11:37 ` Rob Herring
2024-07-29 13:27 ` Stefan Bader
2024-08-02 16:55 ` Amit Machhiwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sevwuxlw.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=amachhiw@linux.ibm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=kowsjois@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lizhi.hou@amd.com \
--cc=lukas@wunner.de \
--cc=npiggin@gmail.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=svaidy@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).