From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="WtUShqYD" Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D2EC99 for ; Mon, 27 Nov 2023 08:10:48 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-332f4ad27d4so1505899f8f.2 for ; Mon, 27 Nov 2023 08:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1701101447; x=1701706247; darn=vger.kernel.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=vmzncnFs4fYSkC3PHDdKYotCyVOAXBzuHAsUKr2mKcw=; b=WtUShqYDKYA8QqWWqpAvR33vvMf/2K3futJHyHJl9eSLM4w/UOensdzyIgvXLcBhKB g8nm+l5g9IcAjyb4k0rEnJYrcHqTTL8qr67P9SyXsUhA85hBqH/98OX/4lWdf7bh7IdS ewXQWDeCGYaeIBXbbdLuqEGHrtOum+m7of2oU1fF5yEOs5fEeiMvdo6AUpMHBLtIYSGF xF7zhTgwEc1BiIOnz1xgqx3gU1hsh8W18G3NHlSkuDI1uRYfdt0D9y0xk2zy/lB/OQ0k a9JNI0adYMV5idW+L7Vw0qDeEtBJIVocEZ6Uq0N5tamFViF/Ad6UpdS5pP9HJdvDVcF/ LDMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701101447; x=1701706247; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vmzncnFs4fYSkC3PHDdKYotCyVOAXBzuHAsUKr2mKcw=; b=uqONjVoj+Cat7vihYmSAuJv6Fuawrfrx2h7LgpwdwohUVSRoVf3MYU2gNLWVq6W6vB FKXjZc8yj+vdA01S9yz45pEyZkR1WXLapWfPeUfMTlgiK6OCHclxOlMw1EFBZchN4JSK hkUvO9AqeNBnqH8cO4GMkzDk72h2LOInIwOogzO5aalKZV2WC4KySoclUqAZHUVepgY7 /WNPJ+J5NI3RehDrdKzyHN/8rDlr23S3ijJaS3ikscyEssAMgwDq+dd22gJzS/wGb4A2 uRWubREM42A+4//XwajsKnVuNGtZqjs3hV0/guvlqDfRPkVsJQrKN8lwpFK8iPwcZ/9U 51+w== X-Gm-Message-State: AOJu0Yxhq6DnEwSIuTEgXAPYRyXk2M2Oik8DG4RZSRS0hAFx/Nghx6tr 03tUcB2dU9bvfrmwsJ3N1R74tfvg+zmkO5Bbpw9x0w== X-Google-Smtp-Source: AGHT+IHYE4hUc0lRq70z8hugnS2j70zK2Mk9ABl/t7P01RsAFlND8jX08hXv10zeeoZM2zUv5yNFUQ== X-Received: by 2002:adf:f88c:0:b0:332:e2b0:c217 with SMTP id u12-20020adff88c000000b00332e2b0c217mr8485693wrp.62.1701101446552; Mon, 27 Nov 2023 08:10:46 -0800 (PST) Received: from localhost ([2a04:cec2:a:b171:f74e:8fa7:e720:a97e]) by smtp.gmail.com with ESMTPSA id j12-20020adff00c000000b00332eadd7ea4sm9451666wro.78.2023.11.27.08.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:10:45 -0800 (PST) From: Julien Masson To: Laurent Pinchart , Cc: , , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Paul Elder , Fabien Parent , Alexandre Mergnat , Julien Stephan , Suhrid Subramaniam , Ted Larson Subject: Re: [PATCH v2 3/3] arm64: dts: mediatek: Add device tree for MT8365-based Pumpkin i350 In-Reply-To: <20231025210342.30995-4-laurent.pinchart@ideasonboard.com> Date: Mon, 27 Nov 2023 17:10:44 +0100 Message-ID: <87sf4ryy63.fsf@build-fedora.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Thanks laurent for adding the support of this board. On Mon 27 Nov 2023 at 17:01, Laurent Pinchart wrote: > Add a minimal device tree for the Genio i350 Pumpkin development board, > which is based on a MediaTek MT8365. > > The device tree is based on an initial version by Fabien Parent Based > written against the MediaTek BSP kernel ([1]). It has been cleaned up, > some features have been added (GPIO LEDs, ethernet), and some features > removed (audio, camera, display and dual-role USB). Those features will > be added back once the corresponding DT bindings and/or drivers become > available in the upstream kernel. > > [1] https://gitlab.com/mediatek/aiot/bsp/linux/-/blob/mtk-v5.15-dev/arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts > > Co-developed-by: Fabien Parent > Signed-off-by: Fabien Parent > Co-developed-by: Paul Elder > Signed-off-by: Paul Elder > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Drop mmc2 alias > - Reorder properties of i2c, mmc and usb nodes > > Changes compared to the BSP version: > > - Add ethernet controller > - Add GPIO LEDs > - Add reserved memory region for BL31 > - Update board model and compatible > - Rename enable-sdio-wakeup to wakeup-source > - Drop audio support > - Drop display support > - Drop dual role USB support > - Don't use underscores in node names > - Normalize pinmux node names > - Remove unneeded labels > - Drop unneeded always-on > - Drop unused pinmux nodes > - Drop camera GPIO hog > - Update copyright > - Fix formatting > - Sort alphabetically > --- > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../boot/dts/mediatek/mt8365-pumpkin.dts | 541 ++++++++++++++++++ > 2 files changed, 542 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index c99c3372a4b5..bbc232bdadc4 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -53,4 +53,5 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-cherry-tomato-r3.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-demo.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts > new file mode 100644 > index 000000000000..9c75294c9889 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin.dts > @@ -0,0 +1,541 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2021 BayLibre, SAS. > + * Copyright (c) 2023 Ideas on Board Oy > + * > + * Author: Fabien Parent > + */ > + > +/dts-v1/; > + > +#include > +#include > +#include > +#include > + > +#include "mt8365.dtsi" > +#include "mt6357.dtsi" > + > +/ { > + model = "OLogic Pumpkin i350 EVK"; > + compatible = "ologic,pumpkin-i350", "mediatek,mt8365"; > + > + aliases { > + ethernet0 = ðernet_usb; > + mmc0 = &mmc0; > + mmc1 = &mmc1; > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:921600n8"; > + }; > + > + firmware { > + optee { > + compatible = "linaro,optee-tz"; > + method = "smc"; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + led-red { > + gpios = <&gpio_exp 12 GPIO_ACTIVE_HIGH>; > + color = ; > + function = LED_FUNCTION_HEARTBEAT; > + linux,default-trigger = "heartbeat"; > + }; > + > + led-green { > + gpios = <&gpio_exp 13 GPIO_ACTIVE_HIGH>; > + color = ; > + default-state = "off"; > + }; > + }; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0 0x40000000 0 0x80000000>; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + /* 192 KiB reserved for ARM Trusted Firmware (BL31) */ > + secmon@43000000 { > + no-map; > + reg = <0 0x43000000 0 0x30000>; > + }; > + > + /* > + * 12 MiB reserved for OP-TEE (BL32) > + * +-----------------------+ 0x43e0_0000 > + * | SHMEM 2MiB | > + * +-----------------------+ 0x43c0_0000 > + * | | TA_RAM 8MiB | > + * + TZDRAM +--------------+ 0x4340_0000 > + * | | TEE_RAM 2MiB | > + * +-----------------------+ 0x4320_0000 > + */ > + optee@43200000 { > + no-map; > + reg = <0 0x43200000 0 0x00c00000>; > + }; > + }; > + > + usb_otg_vbus: usb-otg-vbus-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "otg_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&pio 25 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > +}; > + > +&cpu0 { > + proc-supply = <&mt6357_vproc_reg>; > + sram-supply = <&mt6357_vsram_proc_reg>; > +}; > + > +&cpu1 { > + proc-supply = <&mt6357_vproc_reg>; > + sram-supply = <&mt6357_vsram_proc_reg>; > +}; > + > +&cpu2 { > + proc-supply = <&mt6357_vproc_reg>; > + sram-supply = <&mt6357_vsram_proc_reg>; > +}; > + > +&cpu3 { > + proc-supply = <&mt6357_vproc_reg>; > + sram-supply = <&mt6357_vsram_proc_reg>; > +}; > + > +&i2c0 { > + clock-frequency = <100000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; > + > + status = "okay"; > +}; > + > +&i2c1 { > + clock-frequency = <100000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + > + status = "okay"; > + > + gpio_exp: gpio@20 { > + compatible = "ti,tca6416"; > + reg = <0x20>; > + reset-gpios = <&pio 78 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&tca6416_pins>; > + > + gpio-controller; > + #gpio-cells = <2>; > + }; > +}; > + > +&i2c2 { > + clock-frequency = <100000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c2_pins>; > + > + status = "okay"; > +}; > + > +&i2c3 { > + clock-frequency = <100000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c3_pins>; > + > + status = "okay"; > +}; > + > +&keypad { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&keypad_pins>; > + > + keypad,num-rows = <2>; > + keypad,num-columns = <1>; > + mediatek,debounce-us = <32000>; > + mediatek,double-keys; > + > + linux,keymap = + MATRIX_KEY(0x01, 0x00, KEY_VOLUMEUP)>; > +}; > + > +/* eMMC */ > +&mmc0 { > + bus-width = <8>; > + max-frequency = <200000000>; > + > + cap-mmc-highspeed; > + cap-mmc-hw-reset; > + hs400-ds-delay = <0x12012>; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + no-sd; > + no-sdio; > + non-removable; > + > + vmmc-supply = <&mt6357_vemc_reg>; > + vqmmc-supply = <&mt6357_vio18_reg>; > + > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc0_pins_default>; > + pinctrl-1 = <&mmc0_pins_uhs>; > + > + assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL>; > + > + status = "okay"; > +}; > + > +/* SD card connector */ > +&mmc1 { > + bus-width = <4>; > + max-frequency = <200000000>; > + > + cap-sd-highspeed; > + cd-gpios = <&pio 76 GPIO_ACTIVE_LOW>; > + sd-uhs-sdr104; > + sd-uhs-sdr50; > + > + vmmc-supply = <&mt6357_vmch_reg>; > + vqmmc-supply = <&mt6357_vmc_reg>; > + > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc1_pins_default>; > + pinctrl-1 = <&mmc1_pins_uhs>; > + > + status = "okay"; > +}; > + > +/* WiFi module */ > +&mmc2 { > + bus-width = <4>; > + max-frequency = <200000000>; > + > + cap-sd-highspeed; > + cap-sdio-irq; > + wakeup-source; > + hs400-ds-delay = <0x12012>; > + keep-power-in-suspend; > + non-removable; > + sd-uhs-sdr104; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + > + vmmc-supply = <&mt6357_vemc_reg>; > + vqmmc-supply = <&mt6357_vio18_reg>; > + > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&mmc2_pins_default>; > + pinctrl-1 = <&mmc2_pins_uhs>; > + > + assigned-clocks = <&topckgen CLK_TOP_MSDC50_2_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL>; > + > + status = "okay"; > +}; > + > +&mt6357_pmic { > + interrupt-parent = <&pio>; > + interrupts = <145 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-controller; > + #interrupt-cells = <2>; > +}; > + > +&pio { > + i2c0_pins: i2c0-pins { > + pins { > + pinmux = , > + ; > + mediatek,pull-up-adv = <3>; > + mediatek,drive-strength-adv = <00>; > + bias-pull-up; > + }; > + }; > + > + > + i2c1_pins: i2c1-pins { > + pins { > + pinmux = , > + ; > + mediatek,pull-up-adv = <3>; > + mediatek,drive-strength-adv = <00>; > + bias-pull-up; > + }; > + }; > + > + i2c2_pins: i2c2-pins { > + pins { > + pinmux = , > + ; > + mediatek,pull-up-adv = <3>; > + mediatek,drive-strength-adv = <00>; > + bias-pull-up; > + }; > + }; > + > + i2c3_pins: i2c3-pins { > + pins { > + pinmux = , > + ; > + mediatek,pull-up-adv = <3>; > + mediatek,drive-strength-adv = <00>; > + bias-pull-up; > + }; > + }; > + > + keypad_pins: keypad-pins { > + pins { > + pinmux = , > + , > + ; > + }; > + }; > + > + mmc0_pins_default: mmc0-default-pins { > + clk-pins { > + pinmux = ; > + bias-pull-down; > + }; > + > + cmd-dat-pins { > + pinmux = , > + , > + , > + , > + , > + , > + , > + , > + ; > + input-enable; > + bias-pull-up; > + }; > + > + rst-pins { > + pinmux = ; > + bias-pull-up; > + }; > + }; > + > + mmc0_pins_uhs: mmc0-uhs-pins{ > + clk-pins { > + pinmux = ; > + drive-strength = ; > + bias-pull-down = ; > + }; > + > + cmd-dat-pins { > + pinmux = , > + , > + , > + , > + , > + , > + , > + , > + ; > + input-enable; > + drive-strength = ; > + bias-pull-up = ; > + }; > + > + ds-pins { > + pinmux = ; > + drive-strength = ; > + bias-pull-down = ; > + }; > + > + rst-pins { > + pinmux = ; > + drive-strength = ; > + bias-pull-up; > + }; > + }; > + > + mmc1_pins_default: mmc1-default-pins { > + cd-pins { > + pinmux = ; > + bias-pull-up; > + }; > + > + clk-pins { > + pinmux = ; > + bias-pull-down = ; > + }; > + > + cmd-dat-pins { > + pinmux = , > + , > + , > + , > + ; > + input-enable; > + bias-pull-up = ; > + }; > + }; > + > + mmc1_pins_uhs: mmc1-uhs-pins { > + cd-pins { > + pinmux = ; > + bias-pull-up; > + }; > + > + clk-pins { > + pinmux = ; > + drive-strength = ; > + bias-pull-down = ; > + }; > + > + cmd-dat-pins { > + pinmux = , > + , > + , > + , > + ; > + input-enable; > + drive-strength = ; > + bias-pull-up = ; > + }; > + }; > + > + mmc2_pins_default: mmc2-default-pins { > + clk-pins { > + pinmux = ; > + drive-strength = ; > + bias-pull-down = ; > + }; > + > + cmd-dat-pins { > + pinmux = , > + , > + , > + , > + ; > + input-enable; > + drive-strength = ; > + bias-pull-up = ; > + }; > + > + sysrstb-en-pins { > + pinmux = ; > + output-low; > + }; > + }; > + > + mmc2_pins_uhs: mmc2-uhs-pins { > + clk-pins { > + pinmux = ; > + drive-strength = ; > + bias-pull-down = ; > + }; > + > + cmd-dat-pins { > + pinmux = , > + , > + , > + , > + ; > + input-enable; > + drive-strength = ; > + bias-pull-up = ; > + }; > + > + ds-pins { > + pinmux = ; > + drive-strength = ; > + bias-pull-down = ; > + }; > + > + sysrstb-en-pins { > + pinmux = ; > + output-high; > + }; > + }; > + > + tca6416_pins: tca6416-pins { > + rst-n-pins { > + pinmux = ; > + output-high; > + }; > + > + int-n-pins { > + pinmux = ; > + input-enable; > + bias-pull-up; > + }; > + }; > + > + usb_pins: usb-pins { > + hub-rst-pins { > + pinmux = ; > + output-low; > + }; > + > + id-pins { > + pinmux = ; > + input-enable; > + bias-pull-up; > + }; > + > + vbus-pins { > + pinmux = ; > + }; > + }; > +}; > + > +&ssusb { > + /* Host mode only for now, TUSB322 support is missing. */ > + dr_mode = "host"; > + maximum-speed = "high-speed"; > + vusb33-supply = <&mt6357_vusb33_reg>; > + > + pinctrl-0 = <&usb_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > +}; > + > +&uart0 { > + status = "okay"; > +}; > + > +&usb_host { > + #address-cells = <1>; > + #size-cells = <0>; > + > + vusb33-supply = <&mt6357_vusb33_reg>; > + > + status = "okay"; > + > + hub@2 { > + reg = <2>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet_usb: ethernet@1 { > + compatible = "usb424,ec00"; > + reg = <1>; > + }; > + }; > +}; > -- > Regards, > > Laurent Pinchart > > This patch series conflict with: f2b543a191b6 arm64: dts: mediatek: add device-tree for Genio 1200 EVK board On i350 Pumpkin board (MT8365): Tested-by: Julien Masson -- Julien Masson