devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: dt: fix documented Primecell compatible string
@ 2023-01-04 15:54 Baruch Siach
  2023-04-24  7:24 ` Baruch Siach
  0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2023-01-04 15:54 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski
  Cc: devicetree, Alex Shi, Yanteng Si, Baruch Siach

Only arm,primecell is documented as compatible string for Primecell
peripherals. Current code agrees with that.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 Documentation/devicetree/usage-model.rst                    | 2 +-
 Documentation/translations/zh_CN/devicetree/usage-model.rst | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/usage-model.rst b/Documentation/devicetree/usage-model.rst
index b6a287955ee5..0717426856b2 100644
--- a/Documentation/devicetree/usage-model.rst
+++ b/Documentation/devicetree/usage-model.rst
@@ -415,6 +415,6 @@ When using the DT, this creates problems for of_platform_populate()
 because it must decide whether to register each node as either a
 platform_device or an amba_device.  This unfortunately complicates the
 device creation model a little bit, but the solution turns out not to
-be too invasive.  If a node is compatible with "arm,amba-primecell", then
+be too invasive.  If a node is compatible with "arm,primecell", then
 of_platform_populate() will register it as an amba_device instead of a
 platform_device.
diff --git a/Documentation/translations/zh_CN/devicetree/usage-model.rst b/Documentation/translations/zh_CN/devicetree/usage-model.rst
index c6aee82c7e6e..19ba4ae0cd81 100644
--- a/Documentation/translations/zh_CN/devicetree/usage-model.rst
+++ b/Documentation/translations/zh_CN/devicetree/usage-model.rst
@@ -325,6 +325,6 @@ Primecell设备。然而,棘手的一点是,AMBA总线上的所有设备并
 
 当使用DT时,这给of_platform_populate()带来了问题,因为它必须决定是否将
 每个节点注册为platform_device或amba_device。不幸的是,这使设备创建模型
-变得有点复杂,但解决方案原来并不是太具有侵略性。如果一个节点与“arm,amba-primecell”
+变得有点复杂,但解决方案原来并不是太具有侵略性。如果一个节点与“arm,primecell”
 兼容,那么of_platform_populate()将把它注册为amba_device而不是
 platform_device。
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: dt: fix documented Primecell compatible string
  2023-01-04 15:54 [PATCH] docs: dt: fix documented Primecell compatible string Baruch Siach
@ 2023-04-24  7:24 ` Baruch Siach
  2023-04-24  8:16   ` Yanteng Si
  0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2023-04-24  7:24 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski; +Cc: devicetree, Alex Shi, Yanteng Si

Hi Rob, Krzysztof,

On Wed, Jan 04 2023, Baruch Siach wrote:
> Only arm,primecell is documented as compatible string for Primecell
> peripherals. Current code agrees with that.

I guess this fell between the cracks. I can't find this patch in
patchwork. Maybe the Chinese text made patchwork reject this path. But
the email is archived at lore:

  https://lore.kernel.org/linux-devicetree/8ced22f59980fdfdae869acb91119dadd34987c0.1672847681.git.baruch@tkos.co.il/

Should I send separate patches for the main document and its
translation?

baruch

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  Documentation/devicetree/usage-model.rst                    | 2 +-
>  Documentation/translations/zh_CN/devicetree/usage-model.rst | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/usage-model.rst b/Documentation/devicetree/usage-model.rst
> index b6a287955ee5..0717426856b2 100644
> --- a/Documentation/devicetree/usage-model.rst
> +++ b/Documentation/devicetree/usage-model.rst
> @@ -415,6 +415,6 @@ When using the DT, this creates problems for of_platform_populate()
>  because it must decide whether to register each node as either a
>  platform_device or an amba_device.  This unfortunately complicates the
>  device creation model a little bit, but the solution turns out not to
> -be too invasive.  If a node is compatible with "arm,amba-primecell", then
> +be too invasive.  If a node is compatible with "arm,primecell", then
>  of_platform_populate() will register it as an amba_device instead of a
>  platform_device.
> diff --git a/Documentation/translations/zh_CN/devicetree/usage-model.rst
> b/Documentation/translations/zh_CN/devicetree/usage-model.rst
> index c6aee82c7e6e..19ba4ae0cd81 100644
> --- a/Documentation/translations/zh_CN/devicetree/usage-model.rst
> +++ b/Documentation/translations/zh_CN/devicetree/usage-model.rst
> @@ -325,6 +325,6 @@ Primecell设备。然而,棘手的一点是,AMBA总线上的所有设备并
>  
>  当使用DT时,这给of_platform_populate()带来了问题,因为它必须决定是否将
>  每个节点注册为platform_device或amba_device。不幸的是,这使设备创建模型
> -变得有点复杂,但解决方案原来并不是太具有侵略性。如果一个节点与“arm,amba-primecell”
> +变得有点复杂,但解决方案原来并不是太具有侵略性。如果一个节点与“arm,primecell”
>  兼容,那么of_platform_populate()将把它注册为amba_device而不是
>  platform_device。


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: dt: fix documented Primecell compatible string
  2023-04-24  7:24 ` Baruch Siach
@ 2023-04-24  8:16   ` Yanteng Si
  0 siblings, 0 replies; 3+ messages in thread
From: Yanteng Si @ 2023-04-24  8:16 UTC (permalink / raw)
  To: Baruch Siach, Rob Herring, Krzysztof Kozlowski; +Cc: devicetree, Alex Shi


在 4/24/23 15:24, Baruch Siach 写道:
> Hi Rob, Krzysztof,
>
> On Wed, Jan 04 2023, Baruch Siach wrote:
>> Only arm,primecell is documented as compatible string for Primecell
>> peripherals. Current code agrees with that.
> I guess this fell between the cracks. I can't find this patch in
> patchwork. Maybe the Chinese text made patchwork reject this path. But
> the email is archived at lore:
>
>    https://lore.kernel.org/linux-devicetree/8ced22f59980fdfdae869acb91119dadd34987c0.1672847681.git.baruch@tkos.co.il/
>
> Should I send separate patches for the main document and its
> translation?

Yes, we will split this patch in most cases.


Thanks,

yanteng

>
> baruch
>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>>   Documentation/devicetree/usage-model.rst                    | 2 +-
>>   Documentation/translations/zh_CN/devicetree/usage-model.rst | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/usage-model.rst b/Documentation/devicetree/usage-model.rst
>> index b6a287955ee5..0717426856b2 100644
>> --- a/Documentation/devicetree/usage-model.rst
>> +++ b/Documentation/devicetree/usage-model.rst
>> @@ -415,6 +415,6 @@ When using the DT, this creates problems for of_platform_populate()
>>   because it must decide whether to register each node as either a
>>   platform_device or an amba_device.  This unfortunately complicates the
>>   device creation model a little bit, but the solution turns out not to
>> -be too invasive.  If a node is compatible with "arm,amba-primecell", then
>> +be too invasive.  If a node is compatible with "arm,primecell", then
>>   of_platform_populate() will register it as an amba_device instead of a
>>   platform_device.
>> diff --git a/Documentation/translations/zh_CN/devicetree/usage-model.rst
>> b/Documentation/translations/zh_CN/devicetree/usage-model.rst
>> index c6aee82c7e6e..19ba4ae0cd81 100644
>> --- a/Documentation/translations/zh_CN/devicetree/usage-model.rst
>> +++ b/Documentation/translations/zh_CN/devicetree/usage-model.rst
>> @@ -325,6 +325,6 @@ Primecell设备。然而,棘手的一点是,AMBA总线上的所有设备并
>>   
>>   当使用DT时,这给of_platform_populate()带来了问题,因为它必须决定是否将
>>   每个节点注册为platform_device或amba_device。不幸的是,这使设备创建模型
>> -变得有点复杂,但解决方案原来并不是太具有侵略性。如果一个节点与“arm,amba-primecell”
>> +变得有点复杂,但解决方案原来并不是太具有侵略性。如果一个节点与“arm,primecell”
>>   兼容,那么of_platform_populate()将把它注册为amba_device而不是
>>   platform_device。
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-24 10:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-04 15:54 [PATCH] docs: dt: fix documented Primecell compatible string Baruch Siach
2023-04-24  7:24 ` Baruch Siach
2023-04-24  8:16   ` Yanteng Si

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).