From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Pawel Laszczak <pawell@cadence.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"rogerq@ti.com" <rogerq@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Pawel Jez <pjez@cadence.com>, Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver.
Date: Mon, 11 Feb 2019 15:20:04 +0200 [thread overview]
Message-ID: <87sgwu5unv.fsf@linux.intel.com> (raw)
In-Reply-To: <BYAPR07MB4709A40204EF528F8A04E1EDDD640@BYAPR07MB4709.namprd07.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
Hi,
Pawel Laszczak <pawell@cadence.com> writes:
>>>> +/**
>>>> + * usb_decode_ctrl - Returns human readable representation of control request.
>>>> + * @str: buffer to return a human-readable representation of control request.
>>>> + * This buffer should have about 200 bytes.
>>>
>>> "about 200 bytes" is not very specific.
>>>
>>> Pass in the length so we know we don't overflow it.
>>
>>agree.
> I also agree and I will add such parameter.
https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=next&id=7790b3556fccc555ae422f1576e97bf34c8ab8b6
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-02-11 13:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 11:52 [PATCH v3 0/6] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2019-01-31 11:52 ` [PATCH v3 1/6] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2019-02-13 22:48 ` Rob Herring
2019-02-14 6:08 ` Pawel Laszczak
2019-02-14 14:00 ` Rob Herring
2019-02-15 1:56 ` Peter Chen
2019-01-31 11:52 ` [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver Pawel Laszczak
2019-02-04 11:45 ` Greg KH
2019-02-04 14:17 ` Felipe Balbi
2019-02-04 14:47 ` Greg KH
2019-02-11 12:56 ` Pawel Laszczak
2019-02-11 13:20 ` Felipe Balbi [this message]
2019-02-11 13:30 ` Pawel Laszczak
2019-02-05 8:13 ` Pawel Laszczak
2019-02-05 8:25 ` Felipe Balbi
2019-02-04 11:45 ` Greg KH
2019-01-31 11:52 ` [PATCH v3 3/6] usb:common Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2019-01-31 11:52 ` [PATCH v3 4/6] usb:common Simplify usb_decode_get_set_descriptor function Pawel Laszczak
2019-01-31 12:27 ` Andy Shevchenko
2019-02-04 11:47 ` Greg KH
2019-02-11 12:21 ` Pawel Laszczak
2019-01-31 11:52 ` [PATCH v3 5/6] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2019-02-04 11:48 ` Greg KH
2019-02-05 8:33 ` Pawel Laszczak
2019-01-31 11:52 ` [PATCH v3 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgwu5unv.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).