* [PATCH 0/2] usb: gadget: udc: renesas_usb3: add support for r8a77990 @ 2018-10-02 11:58 Yoshihiro Shimoda 2018-10-02 11:58 ` [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings " Yoshihiro Shimoda 2018-10-02 11:58 ` [PATCH 2/2] usb: gadget: udc: renesas_usb3: add support " Yoshihiro Shimoda 0 siblings, 2 replies; 7+ messages in thread From: Yoshihiro Shimoda @ 2018-10-02 11:58 UTC (permalink / raw) To: balbi, robh+dt, mark.rutland Cc: gregkh, linux-usb, linux-renesas-soc, devicetree, Yoshihiro Shimoda This patch set is based on the latest Greg's usb.git / usb-testing branch. Yoshihiro Shimoda (2): dt-bindings: usb: renesas_usb3: add bindings for r8a77990 usb: gadget: udc: renesas_usb3: add support for r8a77990 Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + drivers/usb/gadget/udc/renesas_usb3.c | 11 +++++++++++ 2 files changed, 12 insertions(+) -- 1.9.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990 2018-10-02 11:58 [PATCH 0/2] usb: gadget: udc: renesas_usb3: add support for r8a77990 Yoshihiro Shimoda @ 2018-10-02 11:58 ` Yoshihiro Shimoda 2018-10-02 12:17 ` Felipe Balbi 2018-10-02 11:58 ` [PATCH 2/2] usb: gadget: udc: renesas_usb3: add support " Yoshihiro Shimoda 1 sibling, 1 reply; 7+ messages in thread From: Yoshihiro Shimoda @ 2018-10-02 11:58 UTC (permalink / raw) To: balbi, robh+dt, mark.rutland Cc: gregkh, linux-usb, linux-renesas-soc, devicetree, Yoshihiro Shimoda This patch adds bindings for r8a77990 (R-Car E3). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt b/Documentation/devicetree/bindings/usb/renesas_usb3.txt index b22f0a5..d366555 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt @@ -6,6 +6,7 @@ Required properties: - "renesas,r8a7795-usb3-peri" - "renesas,r8a7796-usb3-peri" - "renesas,r8a77965-usb3-peri" + - "renesas,r8a77990-usb3-peri" - "renesas,rcar-gen3-usb3-peri" for a generic R-Car Gen3 or RZ/G2 compatible device -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990 2018-10-02 11:58 ` [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings " Yoshihiro Shimoda @ 2018-10-02 12:17 ` Felipe Balbi 2018-10-02 12:35 ` Yoshihiro Shimoda 0 siblings, 1 reply; 7+ messages in thread From: Felipe Balbi @ 2018-10-02 12:17 UTC (permalink / raw) To: Yoshihiro Shimoda, robh+dt, mark.rutland Cc: gregkh, linux-usb, linux-renesas-soc, devicetree [-- Attachment #1: Type: text/plain, Size: 1051 bytes --] Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: > This patch adds bindings for r8a77990 (R-Car E3). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > index b22f0a5..d366555 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > @@ -6,6 +6,7 @@ Required properties: > - "renesas,r8a7795-usb3-peri" > - "renesas,r8a7796-usb3-peri" > - "renesas,r8a77965-usb3-peri" > + - "renesas,r8a77990-usb3-peri" > - "renesas,rcar-gen3-usb3-peri" for a generic R-Car Gen3 or RZ/G2 > compatible device oops: checking file Documentation/devicetree/bindings/usb/renesas_usb3.txt Hunk #1 FAILED at 6. 1 out of 1 hunk FAILED could you rebase against testing/next? -- balbi [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990 2018-10-02 12:17 ` Felipe Balbi @ 2018-10-02 12:35 ` Yoshihiro Shimoda 2018-10-02 12:52 ` Felipe Balbi 0 siblings, 1 reply; 7+ messages in thread From: Yoshihiro Shimoda @ 2018-10-02 12:35 UTC (permalink / raw) To: Felipe Balbi, robh+dt@kernel.org, mark.rutland@arm.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org Hi Felipe-san, > From: Felipe Balbi, Sent: Tuesday, October 2, 2018 9:18 PM > > Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: > > > This patch adds bindings for r8a77990 (R-Car E3). > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > index b22f0a5..d366555 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > @@ -6,6 +6,7 @@ Required properties: > > - "renesas,r8a7795-usb3-peri" > > - "renesas,r8a7796-usb3-peri" > > - "renesas,r8a77965-usb3-peri" > > + - "renesas,r8a77990-usb3-peri" > > - "renesas,rcar-gen3-usb3-peri" for a generic R-Car Gen3 or RZ/G2 > > compatible device > > oops: > > checking file Documentation/devicetree/bindings/usb/renesas_usb3.txt > Hunk #1 FAILED at 6. > 1 out of 1 hunk FAILED > > could you rebase against testing/next? Sorry for lack information. If possible, would you review/apply the following patch at first? https://patchwork.kernel.org/patch/10574879/ Greg-san's repo already merged the patch like below: commit 28da90f19cdec24d669d75942fec227f4de37abd Author: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Date: Fri Aug 24 08:56:15 2018 +0100 usb: gadget: udc: renesas_usb3: Add r8a774a1 support Document RZ/G2M (R8A774A1) SoC bindings. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Rob Herring <robh@kernel.org> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> I think that almost all patches I or other guys sent for usb gadget are already merged into Greg-san's repo like below: 29f7915 Merge 4.19-rc6 into usb-next <snip> 4d2a863 usb: renesas_usbhs: add support for R-Car E3 bcddbd3 dt-bindings: usb: renesas_usbhs: add bindings for r8a77990 6b983ac usb: renesas_usbhs: rcar3: Use OTG mode for R-Car D3 eb757ff Revert "usb: renesas_usbhs: set the mode by using extcon state for non-o 91b20c5 Revert "usb: renesas_usbhs: add extcon notifier to set mode for non-otg <snip> 3df0e24 usb: renesas_usbhs: Add multiple clocks management 8e0d368 dt-bindings: usb: renesas_usbhs: add clock-names property f181dbb usb: renesas_usbhs: Add reset_control <snip> 28da90f usb: gadget: udc: renesas_usb3: Add r8a774a1 support 3938e13 dt-bindings: usb: renesas_usbhs: Add r8a774a1 support ... Best regards, Yoshihiro Shimoda > -- > balbi ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990 2018-10-02 12:35 ` Yoshihiro Shimoda @ 2018-10-02 12:52 ` Felipe Balbi 2018-10-02 17:36 ` gregkh 0 siblings, 1 reply; 7+ messages in thread From: Felipe Balbi @ 2018-10-02 12:52 UTC (permalink / raw) To: Yoshihiro Shimoda, robh+dt@kernel.org, mark.rutland@arm.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 2428 bytes --] Hi, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: > Hi Felipe-san, > >> From: Felipe Balbi, Sent: Tuesday, October 2, 2018 9:18 PM >> >> Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: >> >> > This patch adds bindings for r8a77990 (R-Car E3). >> > >> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> > --- >> > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt >> b/Documentation/devicetree/bindings/usb/renesas_usb3.txt >> > index b22f0a5..d366555 100644 >> > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt >> > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt >> > @@ -6,6 +6,7 @@ Required properties: >> > - "renesas,r8a7795-usb3-peri" >> > - "renesas,r8a7796-usb3-peri" >> > - "renesas,r8a77965-usb3-peri" >> > + - "renesas,r8a77990-usb3-peri" >> > - "renesas,rcar-gen3-usb3-peri" for a generic R-Car Gen3 or RZ/G2 >> > compatible device >> >> oops: >> >> checking file Documentation/devicetree/bindings/usb/renesas_usb3.txt >> Hunk #1 FAILED at 6. >> 1 out of 1 hunk FAILED >> >> could you rebase against testing/next? > > Sorry for lack information. > If possible, would you review/apply the following patch at first? > > https://patchwork.kernel.org/patch/10574879/ > > Greg-san's repo already merged the patch like below: > > commit 28da90f19cdec24d669d75942fec227f4de37abd > Author: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Date: Fri Aug 24 08:56:15 2018 +0100 > > usb: gadget: udc: renesas_usb3: Add r8a774a1 support > > Document RZ/G2M (R8A774A1) SoC bindings. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > Reviewed-by: Rob Herring <robh@kernel.org> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > I think that almost all patches I or other guys sent for usb gadget are already > merged into Greg-san's repo like below: oh, understood. I can rebase my pull request on Greg's branch, then. Greg, would you prefer that to avoid duplicated commits? -- balbi [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings for r8a77990 2018-10-02 12:52 ` Felipe Balbi @ 2018-10-02 17:36 ` gregkh 0 siblings, 0 replies; 7+ messages in thread From: gregkh @ 2018-10-02 17:36 UTC (permalink / raw) To: Felipe Balbi Cc: Yoshihiro Shimoda, robh+dt@kernel.org, mark.rutland@arm.com, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org On Tue, Oct 02, 2018 at 03:52:38PM +0300, Felipe Balbi wrote: > > Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: > > Hi Felipe-san, > > > >> From: Felipe Balbi, Sent: Tuesday, October 2, 2018 9:18 PM > >> > >> Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: > >> > >> > This patch adds bindings for r8a77990 (R-Car E3). > >> > > >> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > >> > --- > >> > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + > >> > 1 file changed, 1 insertion(+) > >> > > >> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > >> b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > >> > index b22f0a5..d366555 100644 > >> > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > >> > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > >> > @@ -6,6 +6,7 @@ Required properties: > >> > - "renesas,r8a7795-usb3-peri" > >> > - "renesas,r8a7796-usb3-peri" > >> > - "renesas,r8a77965-usb3-peri" > >> > + - "renesas,r8a77990-usb3-peri" > >> > - "renesas,rcar-gen3-usb3-peri" for a generic R-Car Gen3 or RZ/G2 > >> > compatible device > >> > >> oops: > >> > >> checking file Documentation/devicetree/bindings/usb/renesas_usb3.txt > >> Hunk #1 FAILED at 6. > >> 1 out of 1 hunk FAILED > >> > >> could you rebase against testing/next? > > > > Sorry for lack information. > > If possible, would you review/apply the following patch at first? > > > > https://patchwork.kernel.org/patch/10574879/ > > > > Greg-san's repo already merged the patch like below: > > > > commit 28da90f19cdec24d669d75942fec227f4de37abd > > Author: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Date: Fri Aug 24 08:56:15 2018 +0100 > > > > usb: gadget: udc: renesas_usb3: Add r8a774a1 support > > > > Document RZ/G2M (R8A774A1) SoC bindings. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > I think that almost all patches I or other guys sent for usb gadget are already > > merged into Greg-san's repo like below: > > oh, understood. I can rebase my pull request on Greg's branch, > then. Greg, would you prefer that to avoid duplicated commits? duplicated commits are fine, I don't mind them :) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] usb: gadget: udc: renesas_usb3: add support for r8a77990 2018-10-02 11:58 [PATCH 0/2] usb: gadget: udc: renesas_usb3: add support for r8a77990 Yoshihiro Shimoda 2018-10-02 11:58 ` [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings " Yoshihiro Shimoda @ 2018-10-02 11:58 ` Yoshihiro Shimoda 1 sibling, 0 replies; 7+ messages in thread From: Yoshihiro Shimoda @ 2018-10-02 11:58 UTC (permalink / raw) To: balbi, robh+dt, mark.rutland Cc: gregkh, linux-usb, linux-renesas-soc, devicetree, Yoshihiro Shimoda Since r8a77990 (R-Car E3) doesn't have VBUS detect pin and number of ramif is 4, this patch adds a new renesas_usb3_priv variable for the SoC. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/gadget/udc/renesas_usb3.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index e1656f3..100e9fa 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2600,6 +2600,13 @@ static void renesas_usb3_init_ram(struct renesas_usb3 *usb3, struct device *dev, .ramsize_per_pipe = SZ_4K, }; +static const struct renesas_usb3_priv renesas_usb3_priv_r8a77990 = { + .ramsize_per_ramif = SZ_16K, + .num_ramif = 4, + .ramsize_per_pipe = SZ_4K, + .workaround_for_vbus = true, +}; + static const struct of_device_id usb3_of_match[] = { { .compatible = "renesas,r8a7795-usb3-peri", @@ -2618,6 +2625,10 @@ static void renesas_usb3_init_ram(struct renesas_usb3 *usb3, struct device *dev, .soc_id = "r8a7795", .revision = "ES1.*", .data = &renesas_usb3_priv_r8a7795_es1, }, + { + .soc_id = "r8a77990", + .data = &renesas_usb3_priv_r8a77990, + }, { /* sentinel */ }, }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-02 17:36 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-10-02 11:58 [PATCH 0/2] usb: gadget: udc: renesas_usb3: add support for r8a77990 Yoshihiro Shimoda 2018-10-02 11:58 ` [PATCH 1/2] dt-bindings: usb: renesas_usb3: add bindings " Yoshihiro Shimoda 2018-10-02 12:17 ` Felipe Balbi 2018-10-02 12:35 ` Yoshihiro Shimoda 2018-10-02 12:52 ` Felipe Balbi 2018-10-02 17:36 ` gregkh 2018-10-02 11:58 ` [PATCH 2/2] usb: gadget: udc: renesas_usb3: add support " Yoshihiro Shimoda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).