* [PATCH RESEND v2] mfd: sm501: Add device property
@ 2016-06-29 16:56 Yoshinori Sato
2016-06-30 7:48 ` Lee Jones
[not found] ` <1467219419-22901-1-git-send-email-ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
0 siblings, 2 replies; 6+ messages in thread
From: Yoshinori Sato @ 2016-06-29 16:56 UTC (permalink / raw)
To: Lee Jones
Cc: Yoshinori Sato, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Yoshinori Sato <ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
---
Documentation/devicetree/bindings/mfd/sm501.txt | 45 +++++++++++++++++++++++++
drivers/mfd/sm501.c | 9 +++++
2 files changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/sm501.txt
diff --git a/Documentation/devicetree/bindings/mfd/sm501.txt b/Documentation/devicetree/bindings/mfd/sm501.txt
new file mode 100644
index 0000000..9290094
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/sm501.txt
@@ -0,0 +1,45 @@
+* SM SM501
+
+The SM SM501 is a LCD controller, with proper hardware, it can also
+drive DVI monitors.
+
+Required properties:
+- compatible : should be "smi,sm501".
+- reg : contain two entries:
+ - First entry: System Configuration register
+ - Second entry: IO space (Display Controller register)
+- interrupts : SMI interrupt to the cpu should be described here.
+- interrupt-parent : the phandle for the interrupt controller that
+ services interrupts for this device.
+
+Optional properties:
+- mode : select a video mode:
+ <xres>x<yres>[-<bpp>][@<refresh>]
+- edid : verbatim EDID data block describing attached display.
+ Data from the detailed timing descriptor will be used to
+ program the display controller.
+- little-endian: available on big endian systems, to
+ set different foreign endian.
+- big-endian: available on little endian systems, to
+ set different foreign endian.
+- smi,devices: function block enable bitmap.
+ bit0: USB host
+ bit1: USB slave
+ bit2: SSP Ch0
+ bit3: SSP Ch1
+ bit4: UART Ch0
+ bit5: UART Ch1
+ bit6: Accelerator
+ bit7: AC97
+ bit8: I2S
+ bit9: GPIO
+
+Example for MPC5200:
+ display@1,0 {
+ compatible = "smi,sm501";
+ reg = <1 0x00000000 0x00800000
+ 1 0x03e00000 0x00200000>;
+ interrupts = <1 1 3>;
+ mode = "640x480-32@60";
+ edid = [edid-data];
+ };
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index 65cd0d2..e2e3f9b 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -21,6 +21,7 @@
#include <linux/pci.h>
#include <linux/i2c-gpio.h>
#include <linux/slab.h>
+#include <linux/of.h>
#include <linux/sm501.h>
#include <linux/sm501-regs.h>
@@ -1377,6 +1378,8 @@ static int sm501_plat_probe(struct platform_device *dev)
{
struct sm501_devdata *sm;
int ret;
+ struct sm501_platdata private_platdata;
+ struct sm501_initdata private_initdata;
sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL);
if (sm == NULL) {
@@ -1388,6 +1391,12 @@ static int sm501_plat_probe(struct platform_device *dev)
sm->dev = &dev->dev;
sm->pdev_id = dev->id;
sm->platdata = dev_get_platdata(&dev->dev);
+ if (!sm->platdata) {
+ of_property_read_u32(dev->dev.of_node, "smi,devices",
+ (u32 *)&private_initdata.devices);
+ private_platdata.init = &private_initdata;
+ sm->platdata = &private_platdata;
+ }
ret = platform_get_irq(dev, 0);
if (ret < 0) {
--
2.7.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH RESEND v2] mfd: sm501: Add device property
2016-06-29 16:56 [PATCH RESEND v2] mfd: sm501: Add device property Yoshinori Sato
@ 2016-06-30 7:48 ` Lee Jones
2016-06-30 15:56 ` Yoshinori Sato
[not found] ` <1467219419-22901-1-git-send-email-ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
1 sibling, 1 reply; 6+ messages in thread
From: Lee Jones @ 2016-06-30 7:48 UTC (permalink / raw)
To: Yoshinori Sato; +Cc: devicetree, linux-kernel
On Thu, 30 Jun 2016, Yoshinori Sato wrote:
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> Documentation/devicetree/bindings/mfd/sm501.txt | 45 +++++++++++++++++++++++++
> drivers/mfd/sm501.c | 9 +++++
> 2 files changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/sm501.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/sm501.txt b/Documentation/devicetree/bindings/mfd/sm501.txt
> new file mode 100644
> index 0000000..9290094
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/sm501.txt
> @@ -0,0 +1,45 @@
> +* SM SM501
> +
> +The SM SM501 is a LCD controller, with proper hardware, it can also
> +drive DVI monitors.
> +
> +Required properties:
> +- compatible : should be "smi,sm501".
> +- reg : contain two entries:
> + - First entry: System Configuration register
> + - Second entry: IO space (Display Controller register)
> +- interrupts : SMI interrupt to the cpu should be described here.
> +- interrupt-parent : the phandle for the interrupt controller that
> + services interrupts for this device.
> +
> +Optional properties:
> +- mode : select a video mode:
> + <xres>x<yres>[-<bpp>][@<refresh>]
> +- edid : verbatim EDID data block describing attached display.
> + Data from the detailed timing descriptor will be used to
> + program the display controller.
> +- little-endian: available on big endian systems, to
> + set different foreign endian.
> +- big-endian: available on little endian systems, to
> + set different foreign endian.
> +- smi,devices: function block enable bitmap.
> + bit0: USB host
> + bit1: USB slave
> + bit2: SSP Ch0
> + bit3: SSP Ch1
> + bit4: UART Ch0
> + bit5: UART Ch1
> + bit6: Accelerator
> + bit7: AC97
> + bit8: I2S
> + bit9: GPIO
> +
> +Example for MPC5200:
> + display@1,0 {
> + compatible = "smi,sm501";
> + reg = <1 0x00000000 0x00800000
> + 1 0x03e00000 0x00200000>;
> + interrupts = <1 1 3>;
> + mode = "640x480-32@60";
> + edid = [edid-data];
> + };
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index 65cd0d2..e2e3f9b 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -21,6 +21,7 @@
> #include <linux/pci.h>
> #include <linux/i2c-gpio.h>
> #include <linux/slab.h>
> +#include <linux/of.h>
>
> #include <linux/sm501.h>
> #include <linux/sm501-regs.h>
> @@ -1377,6 +1378,8 @@ static int sm501_plat_probe(struct platform_device *dev)
> {
> struct sm501_devdata *sm;
> int ret;
> + struct sm501_platdata private_platdata;
> + struct sm501_initdata private_initdata;
>
> sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL);
> if (sm == NULL) {
> @@ -1388,6 +1391,12 @@ static int sm501_plat_probe(struct platform_device *dev)
> sm->dev = &dev->dev;
> sm->pdev_id = dev->id;
> sm->platdata = dev_get_platdata(&dev->dev);
> + if (!sm->platdata) {
> + of_property_read_u32(dev->dev.of_node, "smi,devices",
> + (u32 *)&private_initdata.devices);
> + private_platdata.init = &private_initdata;
> + sm->platdata = &private_platdata;
> + }
I've asked about this 3 times now.
What consumes this platform data?
It also looks ugly and fragile.
> ret = platform_get_irq(dev, 0);
> if (ret < 0) {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH RESEND v2] mfd: sm501: Add device property
2016-06-30 7:48 ` Lee Jones
@ 2016-06-30 15:56 ` Yoshinori Sato
[not found] ` <87wpl6d60k.wl-ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Yoshinori Sato @ 2016-06-30 15:56 UTC (permalink / raw)
To: Lee Jones; +Cc: devicetree, linux-kernel
On Thu, 30 Jun 2016 16:48:00 +0900,
Lee Jones wrote:
>
> On Thu, 30 Jun 2016, Yoshinori Sato wrote:
>
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> > Documentation/devicetree/bindings/mfd/sm501.txt | 45 +++++++++++++++++++++++++
> > drivers/mfd/sm501.c | 9 +++++
> > 2 files changed, 54 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mfd/sm501.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/sm501.txt b/Documentation/devicetree/bindings/mfd/sm501.txt
> > new file mode 100644
> > index 0000000..9290094
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/sm501.txt
> > @@ -0,0 +1,45 @@
> > +* SM SM501
> > +
> > +The SM SM501 is a LCD controller, with proper hardware, it can also
> > +drive DVI monitors.
> > +
> > +Required properties:
> > +- compatible : should be "smi,sm501".
> > +- reg : contain two entries:
> > + - First entry: System Configuration register
> > + - Second entry: IO space (Display Controller register)
> > +- interrupts : SMI interrupt to the cpu should be described here.
> > +- interrupt-parent : the phandle for the interrupt controller that
> > + services interrupts for this device.
> > +
> > +Optional properties:
> > +- mode : select a video mode:
> > + <xres>x<yres>[-<bpp>][@<refresh>]
> > +- edid : verbatim EDID data block describing attached display.
> > + Data from the detailed timing descriptor will be used to
> > + program the display controller.
> > +- little-endian: available on big endian systems, to
> > + set different foreign endian.
> > +- big-endian: available on little endian systems, to
> > + set different foreign endian.
> > +- smi,devices: function block enable bitmap.
> > + bit0: USB host
> > + bit1: USB slave
> > + bit2: SSP Ch0
> > + bit3: SSP Ch1
> > + bit4: UART Ch0
> > + bit5: UART Ch1
> > + bit6: Accelerator
> > + bit7: AC97
> > + bit8: I2S
> > + bit9: GPIO
> > +
> > +Example for MPC5200:
> > + display@1,0 {
> > + compatible = "smi,sm501";
> > + reg = <1 0x00000000 0x00800000
> > + 1 0x03e00000 0x00200000>;
> > + interrupts = <1 1 3>;
> > + mode = "640x480-32@60";
> > + edid = [edid-data];
> > + };
> > diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> > index 65cd0d2..e2e3f9b 100644
> > --- a/drivers/mfd/sm501.c
> > +++ b/drivers/mfd/sm501.c
> > @@ -21,6 +21,7 @@
> > #include <linux/pci.h>
> > #include <linux/i2c-gpio.h>
> > #include <linux/slab.h>
> > +#include <linux/of.h>
> >
> > #include <linux/sm501.h>
> > #include <linux/sm501-regs.h>
> > @@ -1377,6 +1378,8 @@ static int sm501_plat_probe(struct platform_device *dev)
> > {
> > struct sm501_devdata *sm;
> > int ret;
> > + struct sm501_platdata private_platdata;
> > + struct sm501_initdata private_initdata;
> >
> > sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL);
> > if (sm == NULL) {
> > @@ -1388,6 +1391,12 @@ static int sm501_plat_probe(struct platform_device *dev)
> > sm->dev = &dev->dev;
> > sm->pdev_id = dev->id;
> > sm->platdata = dev_get_platdata(&dev->dev);
> > + if (!sm->platdata) {
> > + of_property_read_u32(dev->dev.of_node, "smi,devices",
> > + (u32 *)&private_initdata.devices);
> > + private_platdata.init = &private_initdata;
> > + sm->platdata = &private_platdata;
> > + }
>
> I've asked about this 3 times now.
>
> What consumes this platform data?
>
> It also looks ugly and fragile.
It's appropriate to use dev.of_node, isn't it?
If it's misunderstood, I'm sorry.
> > ret = platform_get_irq(dev, 0);
> > if (ret < 0) {
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1467219419-22901-1-git-send-email-ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>]
* Re: [PATCH RESEND v2] mfd: sm501: Add device property
[not found] ` <1467219419-22901-1-git-send-email-ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
@ 2016-07-01 2:16 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2016-07-01 2:16 UTC (permalink / raw)
To: Yoshinori Sato
Cc: Lee Jones, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Thu, Jun 30, 2016 at 01:56:59AM +0900, Yoshinori Sato wrote:
> Signed-off-by: Yoshinori Sato <ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mfd/sm501.txt | 45 +++++++++++++++++++++++++
> drivers/mfd/sm501.c | 9 +++++
> 2 files changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/sm501.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/sm501.txt b/Documentation/devicetree/bindings/mfd/sm501.txt
> new file mode 100644
> index 0000000..9290094
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/sm501.txt
> @@ -0,0 +1,45 @@
> +* SM SM501
> +
> +The SM SM501 is a LCD controller, with proper hardware, it can also
> +drive DVI monitors.
There is already a binding doc in bindings/display/
> +
> +Required properties:
> +- compatible : should be "smi,sm501".
> +- reg : contain two entries:
> + - First entry: System Configuration register
> + - Second entry: IO space (Display Controller register)
> +- interrupts : SMI interrupt to the cpu should be described here.
> +- interrupt-parent : the phandle for the interrupt controller that
> + services interrupts for this device.
> +
> +Optional properties:
> +- mode : select a video mode:
> + <xres>x<yres>[-<bpp>][@<refresh>]
> +- edid : verbatim EDID data block describing attached display.
> + Data from the detailed timing descriptor will be used to
> + program the display controller.
> +- little-endian: available on big endian systems, to
> + set different foreign endian.
> +- big-endian: available on little endian systems, to
> + set different foreign endian.
> +- smi,devices: function block enable bitmap.
> + bit0: USB host
> + bit1: USB slave
> + bit2: SSP Ch0
> + bit3: SSP Ch1
> + bit4: UART Ch0
> + bit5: UART Ch1
> + bit6: Accelerator
> + bit7: AC97
> + bit8: I2S
> + bit9: GPIO
> +
> +Example for MPC5200:
> + display@1,0 {
> + compatible = "smi,sm501";
> + reg = <1 0x00000000 0x00800000
> + 1 0x03e00000 0x00200000>;
> + interrupts = <1 1 3>;
> + mode = "640x480-32@60";
> + edid = [edid-data];
> + };
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index 65cd0d2..e2e3f9b 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -21,6 +21,7 @@
> #include <linux/pci.h>
> #include <linux/i2c-gpio.h>
> #include <linux/slab.h>
> +#include <linux/of.h>
>
> #include <linux/sm501.h>
> #include <linux/sm501-regs.h>
> @@ -1377,6 +1378,8 @@ static int sm501_plat_probe(struct platform_device *dev)
> {
> struct sm501_devdata *sm;
> int ret;
> + struct sm501_platdata private_platdata;
> + struct sm501_initdata private_initdata;
>
> sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL);
> if (sm == NULL) {
> @@ -1388,6 +1391,12 @@ static int sm501_plat_probe(struct platform_device *dev)
> sm->dev = &dev->dev;
> sm->pdev_id = dev->id;
> sm->platdata = dev_get_platdata(&dev->dev);
> + if (!sm->platdata) {
> + of_property_read_u32(dev->dev.of_node, "smi,devices",
> + (u32 *)&private_initdata.devices);
> + private_platdata.init = &private_initdata;
> + sm->platdata = &private_platdata;
> + }
>
> ret = platform_get_irq(dev, 0);
> if (ret < 0) {
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-03 11:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-29 16:56 [PATCH RESEND v2] mfd: sm501: Add device property Yoshinori Sato
2016-06-30 7:48 ` Lee Jones
2016-06-30 15:56 ` Yoshinori Sato
[not found] ` <87wpl6d60k.wl-ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
2016-07-01 8:59 ` Lee Jones
2016-07-03 11:37 ` Yoshinori Sato
[not found] ` <1467219419-22901-1-git-send-email-ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
2016-07-01 2:16 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).