From: Kevin Hilman <khilman@linaro.org>
To: Hebbar Gururaja <gururaja.hebbar@ti.com>
Cc: tony@atomide.com, b-cousson@ti.com, linux-omap@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
davinci-linux-open-source@linux.davincidsp.com,
vaibhav.bedia@ti.com, sudhakar.raj@ti.com
Subject: Re: [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver
Date: Mon, 01 Jul 2013 17:18:54 -0700 [thread overview]
Message-ID: <87sizxn79t.fsf@linaro.org> (raw)
In-Reply-To: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 28 Jun 2013 15:05:05 +0530")
Hi Hebbar,
Hebbar Gururaja <gururaja.hebbar@ti.com> writes:
> rtc-omap driver modules is used both by OMAP1/2, Davinci SoC platforms.
>
> However, rtc wake support on OMAP1 is broken. Hence the
> device_init_wakeup() was removed from rtc-omap driver and moved to
> platform board files that supported it (DA850/OMAP-L138). [1]
>
> However, recently [2] it was suggested that driver should always do a
> device_init_wakeup(dev, true). Platforms that don't want/need
> wakeup support can disable it from userspace via:
>
> echo disabled > /sys/devices/.../power/wakeup
>
> Also, with the new DT boot-up, board file doesn't exist and hence there
> is no way to have device wakeup support rtc.
>
> The fix for above issues, is to hard code device_init_wakeup() inside
> driver and let platforms that don't need this, handle it through the
> sysfs power entry.
This series looks good now, thanks for your persistence.
Kevin
prev parent reply other threads:[~2013-07-02 0:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 9:35 [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver Hebbar Gururaja
[not found] ` <1372412109-986-1-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org>
2013-06-28 9:35 ` [PATCH 1/4] rtc: omap: restore back (hard-code) wakeup support Hebbar Gururaja
2013-07-02 0:06 ` Kevin Hilman
2013-06-28 9:35 ` [PATCH 2/4] davinci: da8xx/omap-l1: Remove hard coding of rtc device wakeup Hebbar Gururaja
[not found] ` <1372412109-986-3-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org>
2013-06-28 10:14 ` Manjunathappa, Prakash
2013-07-02 5:40 ` Sekhar Nori
[not found] ` <51D267BE.8090605-l0cyMroinI0@public.gmane.org>
2013-07-02 5:41 ` Hebbar, Gururaja
2013-07-02 0:07 ` Kevin Hilman
[not found] ` <87a9m5omcw.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-07-02 5:20 ` Hebbar, Gururaja
2013-06-28 9:35 ` [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events Hebbar Gururaja
[not found] ` <1372412109-986-4-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org>
2013-07-02 0:15 ` Kevin Hilman
[not found] ` <871u7hom0q.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-07-02 5:20 ` Hebbar, Gururaja
2013-07-02 6:02 ` Sekhar Nori
2013-07-02 6:04 ` Hebbar, Gururaja
[not found] ` <1BAFE6F6C881BF42822005164F1491C33EC4E7AB-yXqyApvAXouIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-07-02 6:09 ` Sekhar Nori
[not found] ` <51D26E98.9040303-l0cyMroinI0@public.gmane.org>
2013-07-02 6:11 ` Hebbar, Gururaja
[not found] ` <1BAFE6F6C881BF42822005164F1491C33EC4E7CC-yXqyApvAXouIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-07-02 6:16 ` Sekhar Nori
[not found] ` <51D27052.6080303-l0cyMroinI0@public.gmane.org>
2013-07-03 4:56 ` Hebbar, Gururaja
2013-07-03 5:03 ` Hebbar, Gururaja
2013-06-28 9:35 ` [PATCH 4/4] ARM: dts: AM33XX: update rtc node compatibility Hebbar Gururaja
[not found] ` <1372412109-986-5-git-send-email-gururaja.hebbar-l0cyMroinI0@public.gmane.org>
2013-07-02 6:12 ` Sekhar Nori
[not found] ` <51D26F61.7080308-l0cyMroinI0@public.gmane.org>
2013-07-02 6:14 ` Hebbar, Gururaja
2013-07-02 6:19 ` Hebbar, Gururaja
2013-07-03 8:12 ` Sekhar Nori
2013-07-02 0:18 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sizxn79t.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=b-cousson@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gururaja.hebbar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sudhakar.raj@ti.com \
--cc=tony@atomide.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).