From: Thomas Gleixner <tglx@linutronix.de>
To: Yixun Lan <dlan@gentoo.org>, Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alex Elder <elder@riscstar.com>, Yangyu Chen <cyy@cyyself.name>,
Jisheng Zhang <jszhang@kernel.org>,
Jesse Taube <mr.bossman075@gmail.com>,
Inochi Amaoto <inochiama@outlook.com>,
Icenowy Zheng <uwu@icenowy.me>,
Meng Zhang <zhangmeng.kevin@linux.spacemit.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH v7 0/4] riscv: spacemit: add gpio support for K1 SoC
Date: Wed, 26 Feb 2025 16:45:07 +0100 [thread overview]
Message-ID: <87tt8gemm4.ffs@tglx> (raw)
In-Reply-To: <20250226135635-GYA45740@gentoo>
On Wed, Feb 26 2025 at 13:56, Yixun Lan wrote:
> sounds we need to implement .select() or .match() in irq_domain_ops,
> then find the irq_domain.. here is a prototype version
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 995e5e0ec2db..c4d18267e86e 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -553,7 +553,7 @@ struct irq_domain *irq_find_matching_fwspec(struct irq_fwspec *fwspec,
> */
> mutex_lock(&irq_domain_mutex);
> list_for_each_entry(h, &irq_domain_list, link) {
> - if (h->ops->select && bus_token != DOMAIN_BUS_ANY)
> + if (h->ops->select /* && bus_token != DOMAIN_BUS_ANY */)
This breaks existing usage and reintroduces the regression, which was
fixed with the commit which added the bus token check....
Thanks,
tglx
next prev parent reply other threads:[~2025-02-26 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 0:41 [PATCH v7 0/4] riscv: spacemit: add gpio support for K1 SoC Yixun Lan
2025-02-26 0:41 ` [PATCH v7 1/4] dt-bindings: gpio: spacemit: add " Yixun Lan
2025-02-26 15:55 ` Rob Herring (Arm)
2025-02-26 0:41 ` [PATCH v7 2/4] " Yixun Lan
2025-03-25 10:00 ` Yixun Lan
2025-02-26 0:41 ` [PATCH v7 3/4] riscv: dts: spacemit: add gpio " Yixun Lan
2025-02-26 0:41 ` [PATCH v7 4/4] riscv: dts: spacemit: add gpio LED for system heartbeat Yixun Lan
2025-02-26 1:01 ` [PATCH v7 0/4] riscv: spacemit: add gpio support for K1 SoC Yixun Lan
2025-02-26 10:24 ` Linus Walleij
2025-02-26 11:59 ` Yixun Lan
2025-02-26 13:56 ` Yixun Lan
2025-02-26 15:45 ` Thomas Gleixner [this message]
2025-02-27 2:12 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt8gemm4.ffs@tglx \
--to=tglx@linutronix.de \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=cyy@cyyself.name \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mr.bossman075@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=uwu@icenowy.me \
--cc=zhangmeng.kevin@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox