[PATCH 1/2] dt-bindings: net: wireless: ath11k: add ieee80211-freq-limit property

[PATCH 1/2] dt-bindings: net: wireless: ath11k: add ieee80211-freq-limit property

[Robert Marko]

This is an existing optional property that ieee80211.yaml/cfg80211
provides. It's useful to further restrict supported frequencies
for a specified device through device-tree.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 .../devicetree/bindings/net/wireless/qcom,ath11k.yaml          | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
index 672282cdfc2f..907bbb646614 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
@@ -55,6 +55,8 @@ properties:
       phandle to a node describing reserved memory (System RAM memory)
       used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt)
 
+  ieee80211-freq-limit: true
+
   iommus:
     minItems: 1
     maxItems: 2
@@ -88,6 +90,7 @@ required:
 additionalProperties: false
 
 allOf:
+  - $ref: ieee80211.yaml#
   - if:
       properties:
         compatible:
-- 
2.44.0

[PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

[Robert Marko]

The common DT property can be used to limit the available channels
but ath11k has to manually call wiphy_read_of_freq_limits().

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 drivers/net/wireless/ath/ath11k/mac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index c32be587000d..59bde128d351 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
 	if (ret)
 		goto err;
 
+	wiphy_read_of_freq_limits(ar->hw->wiphy);
 	ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
 	ath11k_mac_setup_he_cap(ar, cap);
 
-- 
2.44.0

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

[Christian Lamparter]

On 4/12/24 6:24 PM, Robert Marko wrote:
> The common DT property can be used to limit the available channels
> but ath11k has to manually call wiphy_read_of_freq_limits().
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>

I've seen this before.

https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/

(dt-binding too. it has/had an ack)
https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/

sooo.... this is awkward.

> ---
>   drivers/net/wireless/ath/ath11k/mac.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index c32be587000d..59bde128d351 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
>   	if (ret)
>   		goto err;
>   
> +	wiphy_read_of_freq_limits(ar->hw->wiphy);
>   	ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
>   	ath11k_mac_setup_he_cap(ar, cap);
>   

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

[Robert Marko]

On Fri, 12 Apr 2024 at 21:52, Christian Lamparter
<christian.lamparter@isd.uni-stuttgart.de> wrote:
>
> On 4/12/24 6:24 PM, Robert Marko wrote:
> > The common DT property can be used to limit the available channels
> > but ath11k has to manually call wiphy_read_of_freq_limits().
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
>
> I've seen this before.
>
> https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/
>
> (dt-binding too. it has/had an ack)
> https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/
>
> sooo.... this is awkward.

Definitively,
I completely missed your patch set and we needed this in OpenWrt.

You were, first so your patch set should be applied.

Regards,
Robert



>
> > ---
> >   drivers/net/wireless/ath/ath11k/mac.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> > index c32be587000d..59bde128d351 100644
> > --- a/drivers/net/wireless/ath/ath11k/mac.c
> > +++ b/drivers/net/wireless/ath/ath11k/mac.c
> > @@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
> >       if (ret)
> >               goto err;
> >
> > +     wiphy_read_of_freq_limits(ar->hw->wiphy);
> >       ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
> >       ath11k_mac_setup_he_cap(ar, cap);
> >
>

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

[Jeff Johnson]

On 4/12/2024 12:52 PM, Christian Lamparter wrote:
> On 4/12/24 6:24 PM, Robert Marko wrote:
>> The common DT property can be used to limit the available channels
>> but ath11k has to manually call wiphy_read_of_freq_limits().
>>
>> Signed-off-by: Robert Marko <robimarko@gmail.com>
> 
> I've seen this before.
> 
> https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/
> 
> (dt-binding too. it has/had an ack)
> https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/
> 
> sooo.... this is awkward.

Patchwork indicates Changes Requested
Any idea what changes Kalle is looking for?

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

[Kalle Valo]

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 4/12/2024 12:52 PM, Christian Lamparter wrote:
>> On 4/12/24 6:24 PM, Robert Marko wrote:
>>> The common DT property can be used to limit the available channels
>>> but ath11k has to manually call wiphy_read_of_freq_limits().
>>>
>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>> 
>> I've seen this before.
>> 
>> https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/
>> 
>> (dt-binding too. it has/had an ack)
>> https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/
>> 
>> sooo.... this is awkward.
>
> Patchwork indicates Changes Requested
> Any idea what changes Kalle is looking for?

I can't remember anymore but most likely I assumed based on Krzysztof's
comments there will be v3 and missed that Conor already had acked it.
Sorry about that, I set Christian's patches to New state now so that
they are back in queue. And I'll drop Robert patches. Does this sound ok
to everyone?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

[Robert Marko]

On Mon, 15 Apr 2024 at 18:06, Kalle Valo <kvalo@kernel.org> wrote:
>
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>
> > On 4/12/2024 12:52 PM, Christian Lamparter wrote:
> >> On 4/12/24 6:24 PM, Robert Marko wrote:
> >>> The common DT property can be used to limit the available channels
> >>> but ath11k has to manually call wiphy_read_of_freq_limits().
> >>>
> >>> Signed-off-by: Robert Marko <robimarko@gmail.com>
> >>
> >> I've seen this before.
> >>
> >> https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/
> >>
> >> (dt-binding too. it has/had an ack)
> >> https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/
> >>
> >> sooo.... this is awkward.
> >
> > Patchwork indicates Changes Requested
> > Any idea what changes Kalle is looking for?
>
> I can't remember anymore but most likely I assumed based on Krzysztof's
> comments there will be v3 and missed that Conor already had acked it.
> Sorry about that, I set Christian's patches to New state now so that
> they are back in queue. And I'll drop Robert patches. Does this sound ok
> to everyone?

Sounds good to me, thanks for looking into it.

Regards,
Robert
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 1/2] dt-bindings: net: wireless: ath11k: add ieee80211-freq-limit property

[Rob Herring]

On Fri, Apr 12, 2024 at 06:24:08PM +0200, Robert Marko wrote:
> This is an existing optional property that ieee80211.yaml/cfg80211
> provides. It's useful to further restrict supported frequencies
> for a specified device through device-tree.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
>  .../devicetree/bindings/net/wireless/qcom,ath11k.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index 672282cdfc2f..907bbb646614 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -55,6 +55,8 @@ properties:
>        phandle to a node describing reserved memory (System RAM memory)
>        used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt)
>  
> +  ieee80211-freq-limit: true
> +

Drop this and change additionalProperties to unevaluatedProperties.

>    iommus:
>      minItems: 1
>      maxItems: 2
> @@ -88,6 +90,7 @@ required:
>  additionalProperties: false
>  
>  allOf:
> +  - $ref: ieee80211.yaml#
>    - if:
>        properties:
>          compatible:
> -- 
> 2.44.0
> 

Re: [PATCH 1/2] dt-bindings: net: wireless: ath11k: add ieee80211-freq-limit property

[Robert Marko]

On Tue, 16 Apr 2024 at 15:21, Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Apr 12, 2024 at 06:24:08PM +0200, Robert Marko wrote:
> > This is an existing optional property that ieee80211.yaml/cfg80211
> > provides. It's useful to further restrict supported frequencies
> > for a specified device through device-tree.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> >  .../devicetree/bindings/net/wireless/qcom,ath11k.yaml          | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> > index 672282cdfc2f..907bbb646614 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> > @@ -55,6 +55,8 @@ properties:
> >        phandle to a node describing reserved memory (System RAM memory)
> >        used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt)
> >
> > +  ieee80211-freq-limit: true
> > +
>
> Drop this and change additionalProperties to unevaluatedProperties.

Hi Rob,
This patch series has been dropped as Christian already proposed the
same before and it was reviewed.

Regards,
Robert
>
> >    iommus:
> >      minItems: 1
> >      maxItems: 2
> > @@ -88,6 +90,7 @@ required:
> >  additionalProperties: false
> >
> >  allOf:
> > +  - $ref: ieee80211.yaml#
> >    - if:
> >        properties:
> >          compatible:
> > --
> > 2.44.0
> >