From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA11FC761A6 for ; Tue, 4 Apr 2023 11:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234867AbjDDLnb (ORCPT ); Tue, 4 Apr 2023 07:43:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234606AbjDDLn0 (ORCPT ); Tue, 4 Apr 2023 07:43:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 300F1D8 for ; Tue, 4 Apr 2023 04:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680608560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g43LgwR7XrUP0mLCRkPUDCErg1tewsdsK7C1g51lbMU=; b=VugpXvSz97BafVwLwbKV+1yZXHlSFEs5/5AIKDQVcwopEPszy+AQiI3DA+K0XLy9C9Z1m7 qajjaNhv+bNUrsGHSsbhKNr7OTE3ijculYWY95hmuh3w30NFq20voQoc+cwaNhfpEkJE7F FIn7zdze6i7Ollewgj6QhW5ZAKHsyrw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-3v1E0u_-MfCsOMzHPUHj4A-1; Tue, 04 Apr 2023 07:42:39 -0400 X-MC-Unique: 3v1E0u_-MfCsOMzHPUHj4A-1 Received: by mail-wr1-f69.google.com with SMTP id k16-20020adfd230000000b002cfe7555486so3656827wrh.13 for ; Tue, 04 Apr 2023 04:42:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680608558; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g43LgwR7XrUP0mLCRkPUDCErg1tewsdsK7C1g51lbMU=; b=mlkMzbuTF96JqqJ2DtnThZGzMnI8MBEbzXxMi1ibq+FrL5aQcdELg8RzBMJOV/TVg5 QJMR02rh1SfKmoS3m/7vcjImYnCHJaFGL5ExkBr709eN4nhEbzG4Vu9YJW7SQ7WKQRQN oftYuqTZG+jwbyMgsTPUCTnqQ4BuFEmit/4Y6xTGp83uzA+ZxFv/pmng5uWAZVRdT6Fl Q98/3Z6VBOiQ0/F6j9BEi9P0oKhNjLOUZSGETRS3G0Oyy+q4acR5SAGt3XwGk+p8D3L8 HnQMbhG4E7i3n23oQWYe2NFSbAMdvc9xVr15Mx1nukhpPpuZ7xPphYNRejZ3GjOnAM2T 1AFQ== X-Gm-Message-State: AAQBX9dA2LE/5aeheZmVMt+sx/tbvfdX7naAa5F0IDboCf/HImDhl4a3 L6rY0c02NudHfUUH1VTiBvFrjXYXB8+mOuqaSOOtqvVcpHCIJfLrD2n5N5XZRsppbaqmSVGwYXK BRZcYB0MZ+44SHrwHXTU7SA== X-Received: by 2002:adf:eace:0:b0:2ce:a098:c6b8 with SMTP id o14-20020adfeace000000b002cea098c6b8mr1553458wrn.55.1680608558085; Tue, 04 Apr 2023 04:42:38 -0700 (PDT) X-Google-Smtp-Source: AKy350YFNy2ACkTPYDUy7IvZluDlWudCyXewZR1HLl8dA6ab7O3s3motR/Cir3GQt7z1geCNLF6cnQ== X-Received: by 2002:adf:eace:0:b0:2ce:a098:c6b8 with SMTP id o14-20020adfeace000000b002cea098c6b8mr1553441wrn.55.1680608557825; Tue, 04 Apr 2023 04:42:37 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id o9-20020a05600c4fc900b003ef6bc71cccsm22744629wmq.27.2023.04.04.04.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 04:42:37 -0700 (PDT) From: Javier Martinez Canillas To: Martijn Braam , Heiko =?utf-8?Q?St=C3=BCbner?= , linux-kernel@vger.kernel.org Cc: Peter Robinson , Caleb Connolly , Jarrah Gosbell , Krzysztof Kozlowski , Ondrej Jirman , Rob Herring , Tom Fitzhenry , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: Change serial baud rate for Pinephone Pro to 1.5 MB In-Reply-To: <52d83a29-0f16-cd4c-9810-7c6bd497fe85@brixit.nl> References: <20230403175937.2842085-1-javierm@redhat.com> <3738011.44csPzL39Z@diego> <52d83a29-0f16-cd4c-9810-7c6bd497fe85@brixit.nl> Date: Tue, 04 Apr 2023 13:42:36 +0200 Message-ID: <87ttxvdgb7.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Martijn Braam writes: > On 4/4/23 09:51, Heiko St=C3=BCbner wrote: >> Hi, >> >> Am Montag, 3. April 2023, 19:59:37 CEST schrieb Javier Martinez Canillas: >>> This baud rate is set for the device by mainline u-boot and is also what >>> is set in the Pinebook Pro Device Tree, which is a device similar to the >>> PinePhone Pro but with a different form factor. >>> >>> Otherwise, the baud rate of the firmware and Linux don't match by defau= lt >>> and a 'console=3DttyS2,1500000n8' kernel command line parameter is requ= ired >>> to have proper output for both. >> The interesting question is always if this will break someone else's set= up. >> I've never really understood the strange setting of 1.5MBps, but on the >> other hand it _is_ a reality on most boards. > > It breaks my device test setup at least. The extra speed isn't worth the= =20 > hassle More than the extra speed is to have consistency accross all the rockchip devices in upstream and also sync with mainline u-boot. > of having a few devices at weird baudrates and the bootloader already > starts outputting debug logs at 115200 baud. > And mine starts outputting at 1.5MBps :) I guess that there isn't a one size fits all, so the question is whether the bikeshed color is what was painted in all other rockchip boards or the one that Tow-Boot has chosen. --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat