From: Kalle Valo <kvalo@kernel.org>
To: Anilkumar Kolli <akolli@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v7 2/2] ath11k: Use reserved host DDR addresses from DT for PCI devices
Date: Thu, 09 Dec 2021 10:07:49 +0200 [thread overview]
Message-ID: <87tufi42wa.fsf@codeaurora.org> (raw)
In-Reply-To: <1638789319-2950-2-git-send-email-akolli@codeaurora.org> (Anilkumar Kolli's message of "Mon, 6 Dec 2021 16:45:19 +0530")
Anilkumar Kolli <akolli@codeaurora.org> writes:
> Host DDR memory (contiguous 45 MB in mode-0 or 15 MB in mode-2)
> is reserved through DT entries for firmware usage. Send the base
> address from DT entries.
> If DT entry is available, PCI device will work with
> fixed_mem_region else host allocates multiple segments.
>
> IPQ8074 on HK10 board supports multiple PCI devices.
> IPQ8074 + QCN9074 is tested with this patch.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01838-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
[...]
> @@ -349,8 +372,15 @@ int ath11k_mhi_register(struct ath11k_pci *ab_pci)
> if (!test_bit(ATH11K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
> mhi_ctrl->irq_flags = IRQF_SHARED | IRQF_NOBALANCING;
>
> - mhi_ctrl->iova_start = 0;
> - mhi_ctrl->iova_stop = 0xffffffff;
> + if ((test_bit(ATH11K_FLAG_FIXED_MEM_RGN, &ab->dev_flags))) {
Unnecessary parenthesis, I fixed it in the pending branch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-12-09 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 11:15 [PATCH v7 1/2] dt: bindings: add new DT entry for ath11k PCI device support Anilkumar Kolli
2021-12-06 11:15 ` [PATCH v7 2/2] ath11k: Use reserved host DDR addresses from DT for PCI devices Anilkumar Kolli
2021-12-09 8:07 ` Kalle Valo [this message]
2021-12-07 20:10 ` [PATCH v7 1/2] dt: bindings: add new DT entry for ath11k PCI device support Rob Herring
2021-12-09 8:04 ` Kalle Valo
2021-12-16 15:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tufi42wa.fsf@codeaurora.org \
--to=kvalo@kernel.org \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).