From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D202C64E7B for ; Mon, 30 Nov 2020 14:37:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0946E20731 for ; Mon, 30 Nov 2020 14:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbgK3Ohm (ORCPT ); Mon, 30 Nov 2020 09:37:42 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:55627 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgK3Ohm (ORCPT ); Mon, 30 Nov 2020 09:37:42 -0500 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 55CA5240019; Mon, 30 Nov 2020 14:36:58 +0000 (UTC) From: Gregory CLEMENT To: Tomasz Nowicki , will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, robh+dt@kernel.org, hannah@marvell.com Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, catalin.marinas@arm.com, nadavh@marvell.com, linux-arm-kernel@lists.infradead.org, mw@semihalf.com, d.odintsov@traviangames.com, stable@vger.kernel.org, Tomasz Nowicki Subject: Re: [PATCH 1/1] arm64: dts: marvell: keep SMMU disabled by default for Armada 7040 and 8040 In-Reply-To: <20201105112602.164739-1-tn@semihalf.com> References: <20201105112602.164739-1-tn@semihalf.com> Date: Mon, 30 Nov 2020 15:36:57 +0100 Message-ID: <87tut6j4hi.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, > FW has to configure devices' StreamIDs so that SMMU is able to lookup > context and do proper translation later on. For Armada 7040 & 8040 and > publicly available FW, most of the devices are configured properly, > but some like ap_sdhci0, PCIe, NIC still remain unassigned which > results in SMMU faults about unmatched StreamID (assuming > ARM_SMMU_DISABLE_BYPASS_BY_DEFAUL=y). > > Since there is dependency on custom FW let SMMU be disabled by default. > People who still willing to use SMMU need to enable manually and > use ARM_SMMU_DISABLE_BYPASS_BY_DEFAUL=n (or via kernel command line) > with extra caution. > > Fixes: 83a3545d9c37 ("arm64: dts: marvell: add SMMU support") > Cc: # 5.9+ > Signed-off-by: Tomasz Nowicki Applied on mvebu/dt64 Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-7040.dtsi | 4 ---- > arch/arm64/boot/dts/marvell/armada-8040.dtsi | 4 ---- > 2 files changed, 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-7040.dtsi b/arch/arm64/boot/dts/marvell/armada-7040.dtsi > index 7a3198cd7a07..2f440711d21d 100644 > --- a/arch/arm64/boot/dts/marvell/armada-7040.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-7040.dtsi > @@ -15,10 +15,6 @@ / { > "marvell,armada-ap806"; > }; > > -&smmu { > - status = "okay"; > -}; > - > &cp0_pcie0 { > iommu-map = > <0x0 &smmu 0x480 0x20>, > diff --git a/arch/arm64/boot/dts/marvell/armada-8040.dtsi b/arch/arm64/boot/dts/marvell/armada-8040.dtsi > index 79e8ce59baa8..22c2d6ebf381 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-8040.dtsi > @@ -15,10 +15,6 @@ / { > "marvell,armada-ap806"; > }; > > -&smmu { > - status = "okay"; > -}; > - > &cp0_pcie0 { > iommu-map = > <0x0 &smmu 0x480 0x20>, > -- > 2.25.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com