From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: marvell: armada-7040-db: Add USB current regulators
Date: Tue, 11 Jun 2019 13:39:08 +0200 [thread overview]
Message-ID: <87tvcwpd0j.fsf@FE-laptop> (raw)
In-Reply-To: <20190528090310.31774-1-miquel.raynal@bootlin.com>
Miquel Raynal <miquel.raynal@bootlin.com> writes:
> Armada 7040-db USB ports deliver 500mA by default while they
> could deliver up to 900mA (usually, for USB3 devices).
>
> The board embeds a GPIO controlled regulator on each port which can be
> configured to deliver each amount of current.
>
> Add a vin-supply property to the USB3 Vbus nodes for this purpose. The
> regulator will be automatically 'enabled', ie. set to limit at 900mA
> instead of 500mA.
>
> Suggested-by: Alex Leibovich <alexl@marvell.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> .../arm64/boot/dts/marvell/armada-7040-db.dts | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> index d20d84ce7ca8..f34ee87a0f56 100644
> --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts
> @@ -28,6 +28,32 @@
> ethernet2 = &cp0_eth2;
> };
>
> + cp0_exp_usb3_0_current_regulator: gpio-regulator {
> + compatible = "regulator-gpio";
> + regulator-name = "cp0-usb3-0-current-regulator";
> + regulator-type = "current";
> + regulator-min-microamp = <500000>;
> + regulator-max-microamp = <900000>;
> + gpios = <&expander0 4 GPIO_ACTIVE_HIGH>;
> + states = <500000 0x0
> + 900000 0x1>;
> + enable-active-high;
> + gpios-states = <0>;
> + };
> +
> + cp0_exp_usb3_1_current_regulator: gpio-regulator {
> + compatible = "regulator-gpio";
> + regulator-name = "cp0-usb3-1-current-regulator";
> + regulator-type = "current";
> + regulator-min-microamp = <500000>;
> + regulator-max-microamp = <900000>;
> + gpios = <&expander0 5 GPIO_ACTIVE_HIGH>;
> + states = <500000 0x0
> + 900000 0x1>;
> + enable-active-high;
> + gpios-states = <0>;
> + };
> +
> cp0_reg_usb3_0_vbus: cp0-usb3-0-vbus {
> compatible = "regulator-fixed";
> regulator-name = "usb3h0-vbus";
> @@ -35,6 +61,7 @@
> regulator-max-microvolt = <5000000>;
> enable-active-high;
> gpio = <&expander0 0 GPIO_ACTIVE_HIGH>;
> + vin-supply = <&cp0_exp_usb3_0_current_regulator>;
> };
>
> cp0_reg_usb3_1_vbus: cp0-usb3-1-vbus {
> @@ -44,6 +71,7 @@
> regulator-max-microvolt = <5000000>;
> enable-active-high;
> gpio = <&expander0 1 GPIO_ACTIVE_HIGH>;
> + vin-supply = <&cp0_exp_usb3_1_current_regulator>;
> };
>
> cp0_usb3_0_phy: cp0-usb3-0-phy {
> --
> 2.19.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
prev parent reply other threads:[~2019-06-11 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 9:03 [PATCH] arm64: dts: marvell: armada-7040-db: Add USB current regulators Miquel Raynal
2019-06-11 11:39 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvcwpd0j.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).