From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/6] drm/format-helper: introduce drm_fb_xrgb8888_to_gray2()
Date: Mon, 01 Sep 2025 15:23:07 +0200 [thread overview]
Message-ID: <87v7m2fgsk.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <2b0eee63-2b7d-4ca5-b673-4f3761d2e386@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
Hello Thomas,
> Hi
>
> Am 11.08.25 um 14:06 schrieb Marcus Folkesson:
>> On Mon, Jul 21, 2025 at 01:24:19PM +0200, Javier Martinez Canillas wrote:
>>> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
>>>
>>>> Convert XRGB8888 to 2bit grayscale.
>>>>
>>>> It uses drm_fb_xrgb8888_to_gray8() to convert the pixels to gray8 as an
>>>> intermediate step before converting to gray2.
>>>>
>>>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>>>> ---
>>> I would like Thomas to review it too, but for me the change looks good.
>> A friendly ping to Thomas.
>
> Apologies for the late review.
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
No worries and thanks a lot for your review.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2025-09-01 13:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 10:43 [PATCH v2 0/6] drm/st7571-i2c: add support for grayscale xrgb8888 Marcus Folkesson
2025-07-21 10:43 ` [PATCH v2 1/6] drm/st7571-i2c: correct pixel data format description Marcus Folkesson
2025-07-21 10:43 ` [PATCH v2 2/6] dt-bindings: display: sitronix,st7571: add optional inverted property Marcus Folkesson
2025-07-21 20:16 ` Rob Herring (Arm)
2025-07-21 10:43 ` [PATCH v2 3/6] dt-bindings: display: sitronix,st7567: " Marcus Folkesson
2025-07-21 11:19 ` Javier Martinez Canillas
2025-07-21 20:16 ` Rob Herring (Arm)
2025-07-21 10:43 ` [PATCH v2 4/6] drm/st7571-i2c: add support for inverted pixel format Marcus Folkesson
2025-07-21 10:43 ` [PATCH v2 5/6] drm/format-helper: introduce drm_fb_xrgb8888_to_gray2() Marcus Folkesson
2025-07-21 11:24 ` Javier Martinez Canillas
2025-08-11 12:06 ` Marcus Folkesson
2025-09-01 10:57 ` Thomas Zimmermann
2025-09-01 13:23 ` Javier Martinez Canillas [this message]
2025-07-21 10:43 ` [PATCH v2 6/6] drm/st7571-i2c: add support for 2bit grayscale for XRGB8888 Marcus Folkesson
2025-09-01 13:51 ` [PATCH v2 0/6] drm/st7571-i2c: add support for grayscale xrgb8888 Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7m2fgsk.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcus.folkesson@gmail.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox