devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: armada-370-db: Fix stereo audio input routing on Armada 370
@ 2025-07-23 22:45 Jihed Chaibi
  2025-08-17 22:18 ` Jihed Chaibi
  2025-08-22 13:08 ` Gregory CLEMENT
  0 siblings, 2 replies; 3+ messages in thread
From: Jihed Chaibi @ 2025-07-23 22:45 UTC (permalink / raw)
  To: andrew, gregory.clement, sebastian.hesselbarth, robh, krzk+dt,
	conor+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, jihed.chaibi.dev

The simple-audio-card configuration for the Armada 370 development
board incorrectly routed the left channel signal ("AIN1L") to both
sides of the stereo "In Jack".

This commit corrects the typo for the right channel, changing the
second "AIN1L" entry to "AIN1R" to enable proper stereo input
recording.

Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
---
 arch/arm/boot/dts/marvell/armada-370-db.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/marvell/armada-370-db.dts b/arch/arm/boot/dts/marvell/armada-370-db.dts
index a7dc4c04d..a9a05d826 100644
--- a/arch/arm/boot/dts/marvell/armada-370-db.dts
+++ b/arch/arm/boot/dts/marvell/armada-370-db.dts
@@ -119,7 +119,7 @@ sound {
 			"Out Jack", "HPL",
 			"Out Jack", "HPR",
 			"AIN1L", "In Jack",
-			"AIN1L", "In Jack";
+			"AIN1R", "In Jack";
 		status = "okay";
 
 		simple-audio-card,dai-link@0 {
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: armada-370-db: Fix stereo audio input routing on Armada 370
  2025-07-23 22:45 [PATCH] ARM: dts: armada-370-db: Fix stereo audio input routing on Armada 370 Jihed Chaibi
@ 2025-08-17 22:18 ` Jihed Chaibi
  2025-08-22 13:08 ` Gregory CLEMENT
  1 sibling, 0 replies; 3+ messages in thread
From: Jihed Chaibi @ 2025-08-17 22:18 UTC (permalink / raw)
  To: andrew, gregory.clement, sebastian.hesselbarth, robh, krzk+dt,
	conor+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel

On Thu, Jul 24, 2025 at 12:45 AM Jihed Chaibi
<jihed.chaibi.dev@gmail.com> wrote:
>
> The simple-audio-card configuration for the Armada 370 development
> board incorrectly routed the left channel signal ("AIN1L") to both
> sides of the stereo "In Jack".
>
> This commit corrects the typo for the right channel, changing the
> second "AIN1L" entry to "AIN1R" to enable proper stereo input
> recording.
>
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
> ---
>  arch/arm/boot/dts/marvell/armada-370-db.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-370-db.dts b/arch/arm/boot/dts/marvell/armada-370-db.dts
> index a7dc4c04d..a9a05d826 100644
> --- a/arch/arm/boot/dts/marvell/armada-370-db.dts
> +++ b/arch/arm/boot/dts/marvell/armada-370-db.dts
> @@ -119,7 +119,7 @@ sound {
>                         "Out Jack", "HPL",
>                         "Out Jack", "HPR",
>                         "AIN1L", "In Jack",
> -                       "AIN1L", "In Jack";
> +                       "AIN1R", "In Jack";
>                 status = "okay";
>
>                 simple-audio-card,dai-link@0 {
> --
> 2.39.5
>

Hi there,

Gentle ping for review on this small patch,

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: armada-370-db: Fix stereo audio input routing on Armada 370
  2025-07-23 22:45 [PATCH] ARM: dts: armada-370-db: Fix stereo audio input routing on Armada 370 Jihed Chaibi
  2025-08-17 22:18 ` Jihed Chaibi
@ 2025-08-22 13:08 ` Gregory CLEMENT
  1 sibling, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2025-08-22 13:08 UTC (permalink / raw)
  To: Jihed Chaibi, andrew, sebastian.hesselbarth, robh, krzk+dt,
	conor+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, jihed.chaibi.dev

Jihed Chaibi <jihed.chaibi.dev@gmail.com> writes:

> The simple-audio-card configuration for the Armada 370 development
> board incorrectly routed the left channel signal ("AIN1L") to both
> sides of the stereo "In Jack".
>
> This commit corrects the typo for the right channel, changing the
> second "AIN1L" entry to "AIN1R" to enable proper stereo input
> recording.
>
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>

Applied on mvebu/fixes

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/marvell/armada-370-db.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-370-db.dts b/arch/arm/boot/dts/marvell/armada-370-db.dts
> index a7dc4c04d..a9a05d826 100644
> --- a/arch/arm/boot/dts/marvell/armada-370-db.dts
> +++ b/arch/arm/boot/dts/marvell/armada-370-db.dts
> @@ -119,7 +119,7 @@ sound {
>  			"Out Jack", "HPL",
>  			"Out Jack", "HPR",
>  			"AIN1L", "In Jack",
> -			"AIN1L", "In Jack";
> +			"AIN1R", "In Jack";
>  		status = "okay";
>  
>  		simple-audio-card,dai-link@0 {
> -- 
> 2.39.5
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-08-22 13:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-23 22:45 [PATCH] ARM: dts: armada-370-db: Fix stereo audio input routing on Armada 370 Jihed Chaibi
2025-08-17 22:18 ` Jihed Chaibi
2025-08-22 13:08 ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).