From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914D8C7EE2A for ; Mon, 5 Jun 2023 10:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229584AbjFEKQW (ORCPT ); Mon, 5 Jun 2023 06:16:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbjFEKQV (ORCPT ); Mon, 5 Jun 2023 06:16:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 233B4EA for ; Mon, 5 Jun 2023 03:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685960136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w//PXxvTZrP/Pd4OMnUnywaLbQPL0Fl6oKrPT/BNYWY=; b=PTtp4cXnSFRJwog1CvSKqlGWiR4L3lyCkku6G8bo+p5SGFWA8F79jOXEIoDSHdLMwpvcKI nXtKYQAnCNTBiO60hv4h7LuSQbUg6gWGSI37TIguqDJygZJ4gaCvC5abjwtnBt/AAGiZc2 Wmz+jfHkhU5tcZ/GWZaXBPxR7z1dve4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-ZqkTeGbiMT2Gf3p0pFVQ_w-1; Mon, 05 Jun 2023 06:15:35 -0400 X-MC-Unique: ZqkTeGbiMT2Gf3p0pFVQ_w-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f60911a417so21930595e9.2 for ; Mon, 05 Jun 2023 03:15:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685960134; x=1688552134; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w//PXxvTZrP/Pd4OMnUnywaLbQPL0Fl6oKrPT/BNYWY=; b=dUGJzVvBql3Di/MdAQbcPN0+foaBrtnMf+7gNKKmn0HzsNfMahZ4QmnxSurRB0XK3c YK8jXEVxYXlqwUxNwWgHfrB5MilkMs+dZdh8Oc+nGkvU5+dxhgy48/jdyt0VMi5LYDT3 GYoOmFSKPZpHZDdDinCH0YOGvQ5G7iXCvH+7iSELBedEbuD2Id9IGhDsl8BrcfGhTp2t uIinEpTUCnQ/Pg/USxudsEiAHAPDE2Zbe+lbgv2rwPz3ZjUH8JpCY/zeBHmLW+yTX3AK cdtzaPOkj0cLMjcXkIRjnKyPSLDSBWuWZQE1nPJazhtJkQRPmrlAc5Ik39WCS7g1ykv1 9b8A== X-Gm-Message-State: AC+VfDx4niVxPWeZpGv260asYpe4yNcldTj60kTIU4UTaI2QbWTe64Tb LDhor6izAliSjgpYitaShZiYvDD96o4Q4nZlRoG9KbzG3MKC0UKxT0bOBPuyBuqUfRXq0yZd+U5 JqD4w6hRoqW0GoWUBtnUKzg== X-Received: by 2002:a7b:ce0a:0:b0:3f4:fc5e:fbf2 with SMTP id m10-20020a7bce0a000000b003f4fc5efbf2mr6422025wmc.8.1685960133991; Mon, 05 Jun 2023 03:15:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ774aF+F8xAb+CL5DwQDB+hwugLWEVdNbOkjDsp7YxMoQiVfuXw+ifNZEj/0nkXNmGxevlGLQ== X-Received: by 2002:a7b:ce0a:0:b0:3f4:fc5e:fbf2 with SMTP id m10-20020a7bce0a000000b003f4fc5efbf2mr6422013wmc.8.1685960133687; Mon, 05 Jun 2023 03:15:33 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id m25-20020a7bca59000000b003f7e62d38d4sm1353196wml.25.2023.06.05.03.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 03:15:33 -0700 (PDT) From: Javier Martinez Canillas To: Maxime Ripard Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , Geert Uytterhoeven , Conor Dooley , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values In-Reply-To: <3bluztz3pcyoyjk4ett673ksnvtkl4xrjqjt43mhmd76dugg7t@kkp7rkx3vjjs> References: <20230605074753.562332-1-javierm@redhat.com> <20230605074753.562332-3-javierm@redhat.com> <3bluztz3pcyoyjk4ett673ksnvtkl4xrjqjt43mhmd76dugg7t@kkp7rkx3vjjs> Date: Mon, 05 Jun 2023 12:15:32 +0200 Message-ID: <87v8g2gqpn.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Maxime Ripard writes: Hello Maxime, Thanks for your feedback. > Hi, > > On Mon, Jun 05, 2023 at 09:47:50AM +0200, Javier Martinez Canillas wrote: [...] >> solomon,width: >> $ref: /schemas/types.yaml#/definitions/uint32 >> - default: 96 >> description: >> - Width in pixel of the screen driven by the controller >> + Width in pixel of the screen driven by the controller. >> + The default value is controller-dependent. > > I think we should document it still, either in the comment itself, or > through a conditional and different default values based on the > compatible. > Makes sense. I'll add that in v2. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat