From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 2/2] ASoC: audio-graph-card: add widgets and routing for external amplifier support Date: Fri, 30 Jun 2017 01:10:44 +0000 Message-ID: <87vanei8uc.wl%kuninori.morimoto.gx@renesas.com> References: <1498742798-3128-1-git-send-email-shawnguo@kernel.org> <1498742798-3128-3-git-send-email-shawnguo@kernel.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Return-path: In-Reply-To: <1498742798-3128-3-git-send-email-shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shawn Guo Cc: Mark Brown , Rob Herring , Baoyou Xie , Xin Zhou , Jun Nie , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Shawn Guo List-Id: devicetree@vger.kernel.org Hi Shawn > From: Shawn Guo > > It's very common that audio card has a machine level amplifier which is > controlled by GPIO. The patch adds DAPM widgets and routing support > into audio-graph-card driver, and creates an output driver widget with > event to control the amplifier via GPIO. > > Signed-off-by: Shawn Guo > --- Thank you for your patch. I think patch adds 3 features (= widget/routing/gpio) in 1 patch. widget/routing features are already supported in -utils, so, break down this patch into "widget/routing" patch, and "gpio" patch is easy to understand, IMO. Not a big deal though Acked-by: Kuninori Morimoto Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html