From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 0/10] mmc: Add support to Marvell Xenon SD Host Controller Date: Wed, 23 Nov 2016 09:30:14 +0100 Message-ID: <87vavemwdl.fsf@free-electrons.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Gregory CLEMENT's message of "Mon, 31 Oct 2016 12:09:49 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ulf Hansson Cc: Hilbert Zhang , Andrew Lunn , Romain Perier , Liuliu Zhao , Peng Zhu , linux-kernel@vger.kernel.org, Nadav Haklai , Ziji Hu , Victor Gu , Doug Jones , Jisheng Zhang , Yehu da Yitschak , Marcin Wojtas , Xueping Liu , Shiwu Zhang , Yu Cao , Sebastian Hesselbarth , devicetree@vger.kernel.org, Jason Cooper , Hanna Hawa , Kostya Porotchkin , Rob Herring , Ryan Gao , "Wei(SOCP) Liu" , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Ulf, On lun., oct. 31 2016, Gregory CLEMENT wrote: > Hello, > > This the second version of the series adding support for the SDHCI > Xenon controller. It can be currently found on the Armada 37xx and the > Armada 7K/8K but will be also used in more Marvell SoC (and not only > the mvebu ones actually). > > Some of the remarks had been taking into account since the first > version, according to Ziji Hu, here are the following chcanges: > "Changes in V2: > rebase on v4.9-rc2. > Re-write Xenon bindings. Ajust Xenon DT property naming. > Add a new DT property to indicate eMMC card type, instead of using > variable card_candidate. > Clear quirks SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 in Xenon platform data > Add support to HS400 retuning." > > I think the main open point which remains is about issuing commands > from the ->set_ios() callback (in patch 7). > Ulf, could you comment about it? This part is the last thing missing, we are about to solve the last issues about the binding, but we still didn't have your opinion about issuing commands from the ->set_ios() callback and Adrian required it to take this series. To have more context you can have a look on: http://marc.info/?l=linux-mmc&m=147618996414673&w=2 it is the original email where Adrian wanted your agreement. Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com