From: Felipe Balbi <balbi@ti.com>
To: Arnd Bergmann <arnd@arndb.de>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-usb@vger.kernel.org, linux-sh@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller
Date: Wed, 16 Dec 2015 09:49:34 -0600 [thread overview]
Message-ID: <87wpsefl69.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <7989573.HuGUrIYJy9@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
Hi,
Arnd Bergmann <arnd@arndb.de> writes:
>> +struct renesas_usb3;
>> +struct renesas_usb3_request {
>> + struct usb_request req;
>> + struct list_head queue;
>> +};
>
> There is already a list_head in struct usb_request. Could you use that?
> (I don't know, just asking because this looks odd)
no, no. Don't do that. The list_head in usb_request is for use by the
gadget drivers and the gadget drivers only.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2015-12-16 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 6:54 [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller Yoshihiro Shimoda
2015-12-15 8:09 ` kbuild test robot
2015-12-15 9:30 ` Arnd Bergmann
2015-12-16 1:43 ` Yoshihiro Shimoda
2015-12-16 2:26 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB0919D7F6AC941F8B1456AF26D8EF0-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-12-16 8:55 ` Arnd Bergmann
2015-12-16 15:49 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpsefl69.fsf@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox