From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "Théo Lebrun" <theo.lebrun@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-clk@vger.kernel.org,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>
Subject: Re: [PATCH v4 6/7] MIPS: mobileye: eyeq5: add two Cadence GEM Ethernet controllers
Date: Fri, 28 Nov 2025 10:49:13 +0100 [thread overview]
Message-ID: <87y0nq4hd2.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20251124-macb-phy-v4-6-955c625a81a7@bootlin.com>
Hello Thomas,
> Add both MACB/GEM instances found in the Mobileye EyeQ5 SoC.
>
> Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Can you confirm that you will include this patch and the following one
in your mips-next branch?
As you gave your Acked-by on it, I believe this will be the case, but I
want to be sure they aren't forgotten.
Thanks!
Gregory
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> arch/mips/boot/dts/mobileye/eyeq5.dtsi | 45 ++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/mips/boot/dts/mobileye/eyeq5.dtsi b/arch/mips/boot/dts/mobileye/eyeq5.dtsi
> index 36a73e8a63a1..cec5ad875228 100644
> --- a/arch/mips/boot/dts/mobileye/eyeq5.dtsi
> +++ b/arch/mips/boot/dts/mobileye/eyeq5.dtsi
> @@ -77,6 +77,8 @@ aliases {
> serial0 = &uart0;
> serial1 = &uart1;
> serial2 = &uart2;
> + ethernet0 = &macb0;
> + ethernet1 = &macb1;
> };
>
> cpu_intc: interrupt-controller {
> @@ -231,6 +233,7 @@ olb: system-controller@e00000 {
> #clock-cells = <1>;
> clocks = <&xtal>;
> clock-names = "ref";
> + #phy-cells = <1>;
> };
>
> gic: interrupt-controller@140000 {
> @@ -305,6 +308,48 @@ gpio1: gpio@1500000 {
> #interrupt-cells = <2>;
> resets = <&olb 0 26>;
> };
> +
> + iocu-bus {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> + dma-coherent;
> + dma-ranges = <0x10 0x00000000 0x0 0x0 0x10 0>;
> +
> + macb0: ethernet@2a00000 {
> + compatible = "mobileye,eyeq5-gem";
> + reg = <0x0 0x02a00000 0x0 0x4000>;
> + interrupt-parent = <&gic>;
> + /* One interrupt per queue */
> + interrupts = <GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SHARED 23 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "pclk", "hclk", "tsu_clk";
> + clocks = <&pclk>, <&pclk>, <&tsu_clk>;
> + nvmem-cells = <ð0_mac>;
> + nvmem-cell-names = "mac-address";
> + phys = <&olb 0>;
> + };
> +
> + macb1: ethernet@2b00000 {
> + compatible = "mobileye,eyeq5-gem";
> + reg = <0x0 0x02b00000 0x0 0x4000>;
> + interrupt-parent = <&gic>;
> + /* One interrupt per queue */
> + interrupts = <GIC_SHARED 24 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SHARED 24 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SHARED 24 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SHARED 24 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "pclk", "hclk", "tsu_clk";
> + clocks = <&pclk>, <&pclk>, <&tsu_clk>;
> + nvmem-cells = <ð1_mac>;
> + nvmem-cell-names = "mac-address";
> + phys = <&olb 1>;
> + };
> + };
> +
> };
> };
>
>
> --
> 2.51.2
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-11-28 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 14:41 [PATCH v4 0/7] Add generic PHY driver used by MACB/GEM on EyeQ5 Théo Lebrun
2025-11-24 14:41 ` [PATCH v4 1/7] dt-bindings: soc: mobileye: OLB is an Ethernet PHY provider " Théo Lebrun
2025-11-24 14:41 ` [PATCH v4 2/7] phy: Add driver for EyeQ5 Ethernet PHY wrapper Théo Lebrun
2025-12-10 16:06 ` Luca Ceresoli
2025-11-24 14:41 ` [PATCH v4 3/7] clk: eyeq: use the auxiliary device creation helper Théo Lebrun
2025-12-10 16:06 ` Luca Ceresoli
2025-11-24 14:41 ` [PATCH v4 4/7] clk: eyeq: add EyeQ5 children auxiliary device for generic PHYs Théo Lebrun
2025-12-10 16:06 ` Luca Ceresoli
2025-11-24 14:41 ` [PATCH v4 5/7] reset: eyeq: drop device_set_of_node_from_dev() done by parent Théo Lebrun
2025-11-24 14:41 ` [PATCH v4 6/7] MIPS: mobileye: eyeq5: add two Cadence GEM Ethernet controllers Théo Lebrun
2025-11-28 9:49 ` Gregory CLEMENT [this message]
2025-11-28 9:53 ` Thomas Bogendoerfer
2025-11-28 10:47 ` Gregory CLEMENT
2025-11-28 11:35 ` Thomas Bogendoerfer
2025-11-24 14:41 ` [PATCH v4 7/7] MIPS: mobileye: eyeq5-epm: add two Cadence GEM Ethernet PHYs Théo Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0nq4hd2.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=benoit.monin@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vkoul@kernel.org \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).