From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0554A293B57 for ; Wed, 23 Apr 2025 19:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745436935; cv=none; b=T1jKaU81DSMHKFBjJLontBE8gukP9Dy3BrzR9li8o4hIY9PjG4NRVmNGTqWxtKup9/vb9yqzpSMgH09Y2HmGe0zkPzdN7SA5v/uPEUpTx+NR4eqg9/uPIMzGI6MSed9OoNO+BeK1AnH6KtI122BO0lyUnoUk5Ko+cVyARXXNPxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745436935; c=relaxed/simple; bh=MUZFYYt03FT+VpNLoBtNnK5YADixP5iwgRhQLqAvFzk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=YcyucWocPDCQFVI+MvGEyrer//TLeXvBDapuMVbEutF2qne1x2bpzpI4HikN+0o8UWrvVmKdytF3/d8rvRxPYmCOCx1svRZjqx49LnD+1WUMV69GH5tVYonlDi7cT5+UFswZ9tUIvHZBcjV21nK1j/a0nrZaL6HXiMCJXLwGID0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RkAFCpue; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RkAFCpue" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745436932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mHwM84CGYO+3jNCMTmmYeka00nVSY0LWa8c5ny3yQ7I=; b=RkAFCpue/37DAtODKeya5SjWEsLU3Ei+CxaByI48Jg+Se/l26B2FMTiHXmyeciC5CbnVrR d44gWBgi0IT/Fr4TAcJ1piQoGBd8H57UTj+yq6UB4VBqMAMatCP9bcFrGrwSZbYewtweGC xscZ0Md+tYLNFlLqt5CkOnx/PmOMiq0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-qv2j8UD-OJ-IqsgHNP8NGw-1; Wed, 23 Apr 2025 15:35:31 -0400 X-MC-Unique: qv2j8UD-OJ-IqsgHNP8NGw-1 X-Mimecast-MFC-AGG-ID: qv2j8UD-OJ-IqsgHNP8NGw_1745436930 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so1115305e9.3 for ; Wed, 23 Apr 2025 12:35:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745436930; x=1746041730; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mHwM84CGYO+3jNCMTmmYeka00nVSY0LWa8c5ny3yQ7I=; b=sx9h2nOCSUHcWOH0g1jojfKiI3qQWnakTg56WEOmDDQgdbDVbdHpg+gHjxu/fqCI8+ C+A79POS/mC7+jC7inpO7ww8EcFmniOd1dw0StcFTAvFTYbHr6QAqRidg6lrWgfZKVNY t8zSz0wI0fcw0wJSZ/hOkb/GxmPUT3nhSvzV8jXqQfLspeC9cJSGxHTpU4r3c10U1Ljw duMs+ZwFYqytFS4rxFw0DqcJY66DqymbhkCqYxBO318EO17hi1VrjQuwH3zDONIp+Vbd IcEisijaFOZrJFPERz9ezEFdVkPJbRBt1uhirJvQFMdkZi0JQUWg4oy4YsPMdBMq07Z2 iTBg== X-Forwarded-Encrypted: i=1; AJvYcCWjbTFLbHXFvyVp8A2gyrnUNSwHJTltMa0tV3h5Pd7ID+1jb02guDWdWDFYSJwNxCZmXMMB2ASUDNoW@vger.kernel.org X-Gm-Message-State: AOJu0YyrDfciW/cG/z7WWdksc5ee+aK/BA8eV4AxC9ByvnCS8nH6pqhn 13dBmewV2NZ8TE+cviyG7ddFBVpWzAty7+xyHDw3lEoY0BLy9pFEUpMb2ulT17LNVoXp4kIwVZh AUW46afnp/tQJ9cuzbBE9YE7/1neF59JZ2wxKIyi2ROeio01Y5zaDvs+609I= X-Gm-Gg: ASbGncuPE1e/C2QSt/U/STc+x4/G4T3BDajuhscDsB85lP6vkKl2qUIgfVhR8uPe4C5 cRev9YaxA6D9OMxJbWvTadChANuPpVKIQ+wxMnlN/XWgxZvOuva7WJ72Z/vEwRV5nVecLfAVdDg aAbOIBwOKAAeh96v4kzGoXQzECfVJ8gYwXBiEleytHZeZVEWe0jN86by+E/q8Xk8eGtUdb3hg0x pul4kW1a03lq/ArNR/0zgm5CtwOLQtgk78RV6skZbX472ALe2JX6Zgo7uxUhea4e33aCRiVaMEd J/fhcLyApW2GTzHmlaWlQMnON9m4cHGhT/9RnrcQ7eXZVgUnWtZ0yzPXTQZnaLBtWphT4w== X-Received: by 2002:a05:600c:384b:b0:43d:b85:1831 with SMTP id 5b1f17b1804b1-4406aa872edmr213880915e9.0.1745436930110; Wed, 23 Apr 2025 12:35:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3o9b9voFidMYGql7TPjF6NJBpEq4Fi6/itjQOx6j+R+KZEPRTl/Eo2lQx2cIZP+I8qEWd0Q== X-Received: by 2002:a05:600c:384b:b0:43d:b85:1831 with SMTP id 5b1f17b1804b1-4406aa872edmr213880635e9.0.1745436929653; Wed, 23 Apr 2025 12:35:29 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa433191sm20045996f8f.31.2025.04.23.12.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 12:35:29 -0700 (PDT) From: Javier Martinez Canillas To: Marcus Folkesson , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marcus Folkesson , Thomas Zimmermann Subject: Re: [PATCH v6 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller In-Reply-To: <20250423-st7571-v6-2-e9519e3c4ec4@gmail.com> References: <20250423-st7571-v6-0-e9519e3c4ec4@gmail.com> <20250423-st7571-v6-2-e9519e3c4ec4@gmail.com> Date: Wed, 23 Apr 2025 21:35:28 +0200 Message-ID: <87y0vqacxr.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marcus Folkesson writes: Hello Marcus, > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller. > The controller has a SPI, I2C and 8bit parallel interface, this > driver is for the I2C interface only. > > Reviewed-by: Thomas Zimmermann > Reviewed-by: Javier Martinez Canillas > Signed-off-by: Marcus Folkesson > --- [...] > + > +static void st7571_reset(struct st7571_device *st7571) > +{ > + gpiod_set_value_cansleep(st7571->reset, 1); > + fdelay(20); There's no fdelay() and this leads to a build failure now: make -j16 M=3Ddrivers/gpu/drm/tiny/ ... CC [M] st7571-i2c.o st7571-i2c.c: In function =E2=80=98st7571_reset=E2=80=99: st7571-i2c.c:815:9: error: implicit declaration of function =E2=80=98fdelay= =E2=80=99; did you mean =E2=80=98ndelay=E2=80=99? [-Wimplicit-function-decl= aration] 815 | fdelay(20); | ^~~~~~ | ndelay but I think you meant fsleep() here (which makes sense to me), so I will ap= ply the following fixup to this patch before pushing it: diff --git a/drivers/gpu/drm/tiny/st7571-i2c.c b/drivers/gpu/drm/tiny/st757= 1-i2c.c index ba089a7e2b61..dc410ec41baf 100644 --- a/drivers/gpu/drm/tiny/st7571-i2c.c +++ b/drivers/gpu/drm/tiny/st7571-i2c.c @@ -812,7 +812,7 @@ static int st7571_parse_dt(struct st7571_device *st7571) static void st7571_reset(struct st7571_device *st7571) { gpiod_set_value_cansleep(st7571->reset, 1); - fdelay(20); + fsleep(20); gpiod_set_value_cansleep(st7571->reset, 0); } --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat