From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBECCC77B75 for ; Fri, 5 May 2023 05:50:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230354AbjEEFuO (ORCPT ); Fri, 5 May 2023 01:50:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230397AbjEEFt7 (ORCPT ); Fri, 5 May 2023 01:49:59 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87998156AC for ; Thu, 4 May 2023 22:49:56 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=igor.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puoKI-00046m-Rk; Fri, 05 May 2023 07:49:54 +0200 References: <20230411083045.2850138-1-s.trumtrar@pengutronix.de> <20230411083045.2850138-2-s.trumtrar@pengutronix.de> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Steffen Trumtrar To: Alexandre TORGUE Cc: linux-stm32@st-md-mailman.stormreply.com, Krzysztof Kozlowski , Maxime Coquelin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 01/10] ARM: dts: stm32: Add alternate pinmux for ethernet Date: Fri, 05 May 2023 07:48:57 +0200 In-reply-to: Message-ID: <87y1m31g5c.fsf@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023-05-02 at 17:20 +02, Alexandre TORGUE wrote: > Hi Steffen > > On 4/11/23 10:30, Steffen Trumtrar wrote: >> Add another option for the ethernet0 pins. >> It is almost identical to ethernet0_rgmii_pins_c apart from TXD0/1. >> This is used on the Phycore STM32MP1. >> Signed-off-by: Steffen Trumtrar >> --- >> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 50 ++++++++++++++++++++++++ >> 1 file changed, 50 insertions(+) >> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >> b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >> index a9d2bec990141..1c97db4dbfc6d 100644 >> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >> @@ -341,6 +341,56 @@ pins1 { >> }; >> }; >> + ethernet0_rgmii_pins_d: rgmii-3 { >> + pins1 { >> + pinmux = , /* ETH_RGMII_CLK125 */ >> + , /* ETH_RGMII_TXD0 */ >> + , /* ETH_RGMII_TXD1 */ >> + , /* ETH_RGMII_TXD2 */ >> + , /* ETH_RGMII_TXD3 */ >> + , /* ETH_RGMII_TX_CTL */ >> + ; /* ETH_MDC */ >> + bias-disable; >> + drive-push-pull; >> + slew-rate = <2>; >> + }; >> + pins2 { >> + pinmux = ; /* ETH_MDIO */ >> + bias-disable; >> + drive-push-pull; >> + slew-rate = <0>; >> + }; >> + pins3 { >> + pinmux = , /* ETH_RGMII_RXD0 */ >> + , /* ETH_RGMII_RXD1 */ >> + , /* ETH_RGMII_RXD2 */ >> + , /* ETH_RGMII_RXD3 */ >> + , /* ETH_RGMII_RX_CLK */ >> + ; /* ETH_RGMII_RX_CTL */ >> + bias-disable; >> + }; >> + }; >> + >> + ethernet0_rgmii_sleep_pins_d: rgmii-sleep-8 { > > Mistake here, it should be rgmii-sleep-3 Meh, good catch. You're right of course, will send a v9. Thanks, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |