From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CFE6C6FD19 for ; Mon, 13 Mar 2023 06:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbjCMG4f (ORCPT ); Mon, 13 Mar 2023 02:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjCMG4f (ORCPT ); Mon, 13 Mar 2023 02:56:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CC494D621; Sun, 12 Mar 2023 23:56:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12792B80E1C; Mon, 13 Mar 2023 06:56:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43AD8C433EF; Mon, 13 Mar 2023 06:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678690590; bh=q5NIoj6sHVjFnHkOzQQT84DcmJS5L1Vnj9AJbL0MMaQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RMXER/VZvg0jEyWlzyHEYOykQziCMrz5wcD8XSJRP4/4efKf2MdoEVD9sSHxBl6TR OKMf5NiomJPpzA1r64rXngINUFZfuavqgU+WxOyewhaRvK+NrcFYszvJqJSMwfADBp 6vXvjFNN0O9/rmCTBFwCh109XcmxbDBaeOjJRFOjY1lZiqJPyg13YJuye4Muq8bTAq 7F7yXL5iCl5MiUQ5CvrODKJZVkU4eRGbntCCGjehxq8WSJ+42HNaRoUmILuivlMJ5V 7HzzAIi8uu0qBB0PNjadWTOSA0ngggRneSwq5QaOwCD3WdhOey/XaSLdDeyUaJzvjU 8tvWbzq8BbtKg== From: Kalle Valo To: Rob Herring Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arend van Spriel , Franky Lin , Hante Meuleman , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Subject: Re: [PATCH] net: Use of_property_present() for testing DT property presence References: <20230310144716.1544083-1-robh@kernel.org> Date: Mon, 13 Mar 2023 08:56:21 +0200 In-Reply-To: <20230310144716.1544083-1-robh@kernel.org> (Rob Herring's message of "Fri, 10 Mar 2023 08:47:16 -0600") Message-ID: <87y1o1nnqi.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Rob Herring writes: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring > --- > drivers/net/mdio/of_mdio.c | 4 ++-- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) For wireless: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches