devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe@balbi.sh>
To: Piyush Mehta <piyush.mehta@amd.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	michal.simek@amd.com, siva.durga.prasad.paladugu@amd.com,
	Manish Narani <manish.narani@xilinx.com>
Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt
Date: Fri, 23 Sep 2022 15:43:23 +0300	[thread overview]
Message-ID: <87y1uab6re.fsf@balbi.sh> (raw)
In-Reply-To: <20220912085730.390555-1-piyush.mehta@amd.com>


Hi,

Piyush Mehta <piyush.mehta@amd.com> writes:
> From: Manish Narani <manish.narani@xilinx.com>
>
> The hibernation feature enabled for Xilinx ZynqMP SoC in DWC3 IP.
> Added the below interrupt-names in the binding schema for the same.
>
> dwc_usb3: dwc3 core interrupt-names
> otg: otg interrupt-names
> hiber: hibernation interrupt-names
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 1779d08ba1c0..618fa7bd32be 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -53,6 +53,8 @@ properties:
>        - const: dwc_usb3
>        - items:
>            enum: [host, peripheral, otg]
> +      - items:
> +          enum: [dwc_usb3, otg, hiber]

I would spell it out; i.e. `hibernation' instead of `hiber'.

-- 
balbi

  parent reply	other threads:[~2022-09-23 12:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12  8:57 [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt Piyush Mehta
2022-09-13  9:21 ` Krzysztof Kozlowski
2022-09-14 13:15   ` Mehta, Piyush
2022-09-15  8:44     ` Krzysztof Kozlowski
2022-09-15  9:04       ` Michal Simek
2022-09-16 10:10         ` Krzysztof Kozlowski
2022-09-22 11:34           ` Michal Simek
2022-09-23  4:28             ` Mehta, Piyush
2022-09-23  4:38             ` Mehta, Piyush
2022-09-23  9:22               ` Krzysztof Kozlowski
2022-09-23  9:34                 ` Michal Simek
2022-09-23 12:43 ` Felipe Balbi [this message]
2022-09-23 13:25   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1uab6re.fsf@balbi.sh \
    --to=felipe@balbi.sh \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=manish.narani@xilinx.com \
    --cc=michal.simek@amd.com \
    --cc=piyush.mehta@amd.com \
    --cc=robh+dt@kernel.org \
    --cc=siva.durga.prasad.paladugu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).