From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v3] dmaengine: rcar-dmac: don't use DMAC error interrupt
Date: Fri, 15 Jun 2018 07:15:35 +0000
Message-ID: <87y3fgbk34.wl-kuninori.morimoto.gx@renesas.com>
References: <87lgbgswl5.wl%kuninori.morimoto.gx@renesas.com>
        <CAMuHMdU_csJSYQ==Z+MOMGMi1LJ07_ZOojYADyUwaDcFLTT9dA@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAMuHMdU_csJSYQ==Z+MOMGMi1LJ07_ZOojYADyUwaDcFLTT9dA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: vkoul@kernel.org, Dan Williams <dan.j.williams@intel.com>, Magnus Damm <magnus.damm@gmail.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran@ksquared.org.uk>, Geert Uytterhoeven <geert+renesas@glider.be>, dmaengine@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>
List-Id: devicetree@vger.kernel.org


Hi Geert

> > rcar-dmac has 2 types of interrupt, 1) error IRQ (for all),
> > 2) IRQ for each channels.
> > If error happens on some channels, the error IRQ will be handled
> > by 1), and "all" channels will be restarted.
> > But in this design, error handling itself will be problem for
> > non error channel users.
> > This patch removes 1) handler, and handles error IRQ on 2)
> 
> Thank you, that explains the rationale!

Thanks

> BTW, how can you trigger an error, for testing?

We created local patch to break address alignment.

Best regards
---
Kuninori Morimoto