From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Leach Subject: Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Date: Wed, 11 May 2016 19:18:31 +0100 Message-ID: <87y47gwj9k.fsf@mattleach.net> References: <1462950412-16681-1-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1462950412-16681-1-git-send-email-k.kozlowski@samsung.com> (Krzysztof Kozlowski's message of "Wed, 11 May 2016 09:06:52 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Krzysztof, Sorry for not acting on the feedback sooner - I lost the email in my Inbox! I've tested the patch on my Origen board and it works fine. One small comment in-line. Krzysztof Kozlowski writes: > From: Matthew Leach > > Enable the Origen's usb phy and ohci devices in the device tree. Also > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so > the AX88760 hub is powered. > > Signed-off-by: Matthew Leach > [k.kozlowski: Extend nodes by label notation instead of path] > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts > index 8bca699b7f20..4c59bdb0e6f3 100644 > --- a/arch/arm/boot/dts/exynos4412-origen.dts > +++ b/arch/arm/boot/dts/exynos4412-origen.dts > @@ -77,12 +77,29 @@ > clock-frequency = <24000000>; > }; > }; > + I think we could loose this line break? Thanks, -- Matt