From mboxrd@z Thu Jan  1 00:00:00 1970
From: Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb
Date: Tue, 23 Feb 2016 21:12:25 +0100
Message-ID: <87y4abuqxi.fsf@belgarion.home>
References: <1456139297-5854-1-git-send-email-ynvich@gmail.com>
	<87oab8wyfe.fsf@belgarion.home> <1456228901.23036.9.camel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1456228901.23036.9.camel@gmail.com> (Sergei Ianovich's message
	of "Tue, 23 Feb 2016 15:01:41 +0300")
Sender: linux-kernel-owner@vger.kernel.org
To: Sergei Ianovich <ynvich@gmail.com>
Cc: linux-kernel@vger.kernel.org, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Russell King <linux@arm.linux.org.uk>, "moderated list:PXA2xx/PXA3xx SUPPORT" <linux-arm-kernel@lists.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>
List-Id: devicetree@vger.kernel.org

Sergei Ianovich <ynvich@gmail.com> writes:

> Hi Robert,=C2=A0
>
> On Mon, 2016-02-22 at 16:35 +0100, Robert Jarzmik wrote:
>> You're right, I haven't seen the pxa2xx.dtsi statement before.
>>=20
>> As such, could you amend a bit your patch please to :
>> =C2=A0- add:
>> Fixes: 0ec1939668e5 ("ARM: dts: pxa: add the usb host controller")
>> =C2=A0- make the same change in pxa3xx.dtsi, as the same error is th=
ere
>> =C2=A0- and more globally align pxa2xx.dtsi, pxa27x.dtsi and pxa3xx.=
dtsi
>> =C2=A0- remove the compatible, reg, interrupts and status from both =
pxa27x.dtsi and
>> =C2=A0=C2=A0=C2=A0pxa3xx.dtsi as they are redundant with the include=
d pxa2xxx.dsti one
>
> No problem. Let's figure out the best approach.
>
>> I'm even wondering if the proper change wouldn't be to scrap the ohc=
i
>> declarations from pxa27x.dtsi and pxa3xx.dtsi, and only add the "clo=
cks"
>> property to pxa2xx.dtsi ...
>
> Since clocks are declared in pxa27x.dtsi and=C2=A0pxa3xx.dtsi, there =
is a
> stronger ground to have node clocks properties set in pxa27x.dtsi
> and=C2=A0pxa3xx.dtsi as well. However, there is already nodes with cl=
ocks
> properties in pxa2xx.dtsi.
>
> I cannot choose, you should make a decision.
I have checked my manuals, and pxa25x doesn't have an USB Host controll=
er.

So I'd rather have :
 - remove the usb0: ohci@4c000000 node from pxa2xx.dtsi
 - add it completely to pxa27x.dtsi and pxa3xx.dtsi, with clocks and ev=
erything,
   in "disabled" status.

Cheers.

--=20
Robert