From: Takashi Iwai <tiwai@suse.de>
To: joakim.zhang@cixtech.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH v3 3/3] ALSA: hda: add CIX IPBLOQ HDA controller support
Date: Mon, 01 Dec 2025 13:53:27 +0100 [thread overview]
Message-ID: <87zf82bby0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251201105700.832715-4-joakim.zhang@cixtech.com>
On Mon, 01 Dec 2025 11:57:00 +0100,
joakim.zhang@cixtech.com wrote:
>
> From: Joakim Zhang <joakim.zhang@cixtech.com>
>
> Add CIX IPBLOQ HDA controller support, which integrated
> in CIX SKY1 SoC.
It'd be more helpful to describe the characteristics about this chip.
e.g. this chip requires special handling for jack polling, and it
needs the address offset, etc.
> +static int __maybe_unused cix_ipbloq_hda_suspend(struct device *dev)
Those __maybe_unused are superfluous when you use
SYSTEM_SLEEP_PM_OPS() or RUNTIME_PM_OPS() in dev_pm_ops definition.
thanks,
Takashi
next prev parent reply other threads:[~2025-12-01 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 10:56 [PATCH v3 0/3] ALSA: hda: add CIX IPBLOQ HDA controller support joakim.zhang
2025-12-01 10:56 ` [PATCH v3 1/3] ALSA: hda: dt-bindings: " joakim.zhang
2025-12-01 10:56 ` [PATCH v3 2/3] ALSA: hda/core: add addr_offset field for bus address translation joakim.zhang
2025-12-01 10:57 ` [PATCH v3 3/3] ALSA: hda: add CIX IPBLOQ HDA controller support joakim.zhang
2025-12-01 12:53 ` Takashi Iwai [this message]
2025-12-02 9:45 ` Joakim Zhang
2025-12-02 0:44 ` kernel test robot
2025-12-02 2:10 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf82bby0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joakim.zhang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).