From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 622EF2C17A0 for ; Fri, 24 Oct 2025 12:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761308425; cv=none; b=U3sQIBSeN8IpQx4YGuuYeUMBT6QhxjWYwiboJc2kBjw71YHqLM3nqkjKPlj2SnG7acdlkTu3GoX4Xyc+gPcroCdMS+3ZWV3gC0pDHVHEtgHC4E3QGXY6Zh6LtPGIhH3n5mh5huSBOKftVBUtBmSaki9+eRU9SDpj/gZADveY4GM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761308425; c=relaxed/simple; bh=f4nLSZUbHXPOAJMornZBUvE6cqRt+o4rLfXHVdki47Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ms0eMYj91DIfBxGNK6CWJ2t4dkhbg19II7n1vnVnZo7dv4jI483i5X+1BBvqiC6ri6XtYaH5QN1gQDI/2P3sbJM0u+43mKIePz+jYyP3EHqH9E4aBprscj3AnTOD+rUnEudlYireKfCOkwqdadoOK7DPd0TQ+QoH+SsoYz9uFN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=ratatoskr.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vCGmD-0000ek-3D; Fri, 24 Oct 2025 14:20:13 +0200 From: Steffen Trumtrar To: Dinh Nguyen Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Matthew Gerlach , kernel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 06/10] arm64: dts: socfpga: agilex5: add dwxgmac compatible In-Reply-To: (Dinh Nguyen's message of "Fri, 24 Oct 2025 07:00:36 -0500") References: <20251024-v6-12-topic-socfpga-agilex5-v5-0-4c4a51159eeb@pengutronix.de> <20251024-v6-12-topic-socfpga-agilex5-v5-6-4c4a51159eeb@pengutronix.de> User-Agent: mu4e 1.12.13; emacs 30.2 Date: Fri, 24 Oct 2025 14:20:09 +0200 Message-ID: <87zf9g7apy.fsf@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Hi Dinh, On 2025-10-24 at 07:00 -05, Dinh Nguyen wrote: > Hi Steffen, > > On 10/24/25 06:49, Steffen Trumtrar wrote: > > The gmac0/1/2 are also compatible to the more generic "snps,dwxgmac" > > compatible. The platform code checks this to decide if it is a GMAC or > > GMAC4 compatible IP core. > > Signed-off-by: Steffen Trumtrar > > --- > > arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi > > b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi > > index 4ccfebfd9d322..d0c139f03541e 100644 > > --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi > > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi > > @@ -536,7 +536,8 @@ qspi: spi@108d2000 { > > gmac0: ethernet@10810000 { > > compatible = "altr,socfpga-stmmac-agilex5", > > - "snps,dwxgmac-2.10"; > > + "snps,dwxgmac-2.10", > > + "snps,dwxgmac"; > > reg = <0x10810000 0x3500>; > > interrupts = ; > > interrupt-names = "macirq"; > > @@ -649,7 +650,8 @@ queue7 { > > gmac1: ethernet@10820000 { > > compatible = "altr,socfpga-stmmac-agilex5", > > - "snps,dwxgmac-2.10"; > > + "snps,dwxgmac-2.10", > > + "snps,dwxgmac"; > > reg = <0x10820000 0x3500>; > > interrupts = ; > > interrupt-names = "macirq"; > > @@ -762,7 +764,8 @@ queue7 { > > gmac2: ethernet@10830000 { > > compatible = "altr,socfpga-stmmac-agilex5", > > - "snps,dwxgmac-2.10"; > > + "snps,dwxgmac-2.10", > > + "snps,dwxgmac"; > > reg = <0x10830000 0x3500>; > > interrupts = ; > > interrupt-names = "macirq"; > > > > I just sent a patch for this yesterday: > > https://lore.kernel.org/all/20251023214012.283600-1-dinguyen@kernel.org/ > ah, I missed that, than this patch is unneccessary. > I'll make sure to include you on future submissions. > > I didn't add it to the bindings document though. > As I always get complains from dt-check bot, I remembered to add it ;) Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |