devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Linux-Kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-DT <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Laurent
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Peter Chen <peter.chen-3arQi8VN3Tc@public.gmane.org>,
	Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>,
	Benoit Parrot <bparrot-l0cyMroinI0@public.gmane.org>,
	Mauro Carvalho Chehab
	<mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Javier Martinez Canillas
	<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
	Sakari Ailus
	<sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Bartlomiej Zolnierkiewicz
	<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 0/6] of_graph_get_remote_endpoint()
Date: Fri, 20 Jan 2017 02:04:21 +0000	[thread overview]
Message-ID: <87ziimlca0.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAL_JsqJEL4jd2gnoC+mygJzuEgPO8H4PQhN5dvmq_rN1mBfVEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>


Hi Rob

> This looks okay, but I think we need to be improving the graph api at
> a higher level. Each user seems to be doing too much open coding of
> walking of the graph. The user typically just wants the remote node
> parent of a given port and endpoint number. Why does the user walk the
> graph to find the endpoint node, then parse remote-endpoint, then walk
> up parents. We have lots of other graph users and you didn't need to
> update them which means they are already using helpers. Maybe the
> drivers here need to be fixed. omapfb in particular looks like it
> duplicates a bunch of helpers we already have, but maybe we're close
> to removing that driver.

Does your "we need to be improving the graph api at a higher level"
mean I need to re-work this patch ?
Or someone (?) will improve OF-graph, and I need to wait it ?
More direct words, will this patch be accepted ??

You know I'm working for OF-graph base HDMI sound now, and actually,
I have some OF-graph new API which is useful for OF-graph HDMI sound support.
(I don't like open coding, I want to have useful/understandable common api)
This get_remote_endpoint is one of them, and was ready for posting.
So, I will post other OF-graph base patches if OF-graph HDMI sound was ready.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-01-20  2:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  6:31 [PATCH 0/6] of_graph_get_remote_endpoint() Kuninori Morimoto
2017-01-19  6:34 ` [PATCH 1/6] of_graph: add of_graph_get_remote_endpoint() Kuninori Morimoto
     [not found] ` <87o9z34l3o.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-01-19  6:34   ` [PATCH 2/6] drm/omapdrm: use of_graph_get_remote_endpoint() Kuninori Morimoto
2017-01-19  6:36   ` Kuninori Morimoto
2017-01-19  6:37   ` [PATCH 4/6] media: ti-vpe: cal: " Kuninori Morimoto
2017-01-19  6:36 ` [PATCH 3/6] drm: rcar-du: " Kuninori Morimoto
2017-01-19  6:37 ` [PATCH 5/6] v4l: of: " Kuninori Morimoto
2017-01-19  6:38 ` [PATCH 6/6] omapfb: " Kuninori Morimoto
2017-01-19 14:34 ` [PATCH 0/6] of_graph_get_remote_endpoint() Rob Herring
     [not found]   ` <CAL_JsqJEL4jd2gnoC+mygJzuEgPO8H4PQhN5dvmq_rN1mBfVEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-20  2:04     ` Kuninori Morimoto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ziimlca0.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx-zm6kxycvzfbbdgjk7y7tuq@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=bparrot-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=peter.chen-3arQi8VN3Tc@public.gmane.org \
    --cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).