From: Eric Anholt <eric@anholt.net>
To: Stefan Wahren <info@lategoodbye.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v3 7/7] ARM: bcm2835: Add VC4 to the device tree.
Date: Mon, 12 Oct 2015 13:57:22 -0700 [thread overview]
Message-ID: <87zizn4xfx.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <561A70C6.4070602@lategoodbye.de>
[-- Attachment #1.1: Type: text/plain, Size: 1800 bytes --]
Stefan Wahren <info@lategoodbye.de> writes:
> Am 09.10.2015 um 23:27 schrieb Eric Anholt:
>> VC4 is the GPU (display and 3D) present on the 2835.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>>
>> v2: Sort by register address, mark HDMI as disabled by default in the
>> SoC file and enable it from -rpi.
>>
>> v3: Add references to the pixel/HSM clocks for HDMI. Rename
>> compatibility strings and clean up node names.
>>
>> arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 ++++
>> arch/arm/boot/dts/bcm2835.dtsi | 42 ++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 46 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
>> index 3572f03..dcaaee2 100644
>> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
>> @@ -56,6 +56,10 @@
>> status = "okay";
>> };
>>
>> +&hdmi {
>> + status = "okay";
>> +};
>> +
>> &sdhci {
>> status = "okay";
>> bus-width = <4>;
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>> index 1e61eb7..21e354a9 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -1,4 +1,5 @@
>> #include <dt-bindings/pinctrl/bcm2835.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/clock/bcm2835.h>
>> #include "skeleton.dtsi"
>>
>> @@ -149,6 +150,18 @@
>> status = "disabled";
>> };
>>
>> + pixelvalve@7e206000 {
>> + compatible = "brcm,bcm2835-pixelvalve0";
>> + reg = <0x7e206000 0x100>;
>> + interrupts = <2 13>; /* pwa2 */
>
> According to BCM2835-ARM-Peripherals this should be pwa0.
>
> Is it just a typo?
> What does pwa mean?
Just a typo. I don't know what pwa means, either, it's just a string so
you can search for it in the docs.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-10-12 20:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 21:27 bcm2835 (Raspberry Pi) KMS driver Eric Anholt
2015-10-09 21:27 ` [PATCH v3 1/7] drm/vc4: Add devicetree bindings for VC4 Eric Anholt
[not found] ` <1444426068-15817-2-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
2015-10-09 23:31 ` Sebastian Reichel
2015-10-13 17:59 ` Eric Anholt
2015-10-13 13:26 ` Rob Herring
2015-10-13 18:17 ` Eric Anholt
2015-10-13 21:56 ` Rob Herring
2015-10-21 8:57 ` Eric Anholt
2015-10-21 22:08 ` Rob Herring
2015-10-09 21:27 ` [PATCH v3 2/7] MAINTAINERS: Add myself for the new VC4 (RPi GPU) graphics driver Eric Anholt
2015-10-09 22:12 ` Emil Velikov
2015-10-09 23:13 ` Eric Anholt
2015-10-09 21:27 ` [PATCH v3 3/7] drm/vc4: Add KMS support for Raspberry Pi Eric Anholt
[not found] ` <1444426068-15817-4-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
2015-10-11 14:02 ` Stefan Wahren
2015-10-13 18:19 ` Eric Anholt
[not found] ` <87io6a3a34.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2015-10-13 18:50 ` Stefan Wahren
2015-10-13 19:01 ` Stefan Wahren
2015-10-09 21:27 ` [PATCH v3 4/7] drm/vc4: Use the fbdev_cma helpers Eric Anholt
2015-10-09 21:27 ` [PATCH v3 5/7] drm/vc4: Allow vblank to be disabled Eric Anholt
2015-10-09 21:27 ` [PATCH v3 6/7] ARM: bcm2835: Add the DDC I2C controller to the device tree Eric Anholt
2015-10-09 21:27 ` [PATCH v3 7/7] ARM: bcm2835: Add VC4 " Eric Anholt
2015-10-11 14:23 ` Stefan Wahren
2015-10-12 20:57 ` Eric Anholt [this message]
[not found] ` <1444426068-15817-1-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
2015-10-11 12:39 ` bcm2835 (Raspberry Pi) KMS driver Stefan Wahren
[not found] ` <561A587D.6020009-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
2015-10-12 20:39 ` Stephen Warren
2015-10-12 20:53 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zizn4xfx.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=info@lategoodbye.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).